From 4f490057e17f51c82ef1bbbd3e07dd0643e3f393 Mon Sep 17 00:00:00 2001 From: Jay Pokale Date: Sat, 21 Nov 2026 20:51:01 +0530 Subject: [PATCH] Fix PrimeCheck returning true for negative odd numbers PrimeCheck only rejected 0, 1 and even numbers, and for a negative odd n the loop condition i * i <= n is false at once, so PrimeCheck(-3) and PrimeCheck(-1) were true. Reject everything below 2. --- Maths/PrimeCheck.js | 3 +-- Maths/test/PrimeCheck.test.js | 5 +++++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/Maths/PrimeCheck.js b/Maths/PrimeCheck.js index 1d0b18ed43..242ba1aae5 100644 --- a/Maths/PrimeCheck.js +++ b/Maths/PrimeCheck.js @@ -9,8 +9,7 @@ const PrimeCheck = (n) => { // input: n: int // output: boolean - if (n === 1) return false - if (n === 0) return false + if (n < 2) return false if (n === 2) return true if (n % 2 === 0) return false diff --git a/Maths/test/PrimeCheck.test.js b/Maths/test/PrimeCheck.test.js index da1cd1b52f..5fbf77d9af 100644 --- a/Maths/test/PrimeCheck.test.js +++ b/Maths/test/PrimeCheck.test.js @@ -11,4 +11,9 @@ describe('PrimeCheck', () => { expect(PrimeCheck(1)).toBeFalsy() expect(PrimeCheck(0)).toBeFalsy() }) + it('should return false for negative numbers', () => { + expect(PrimeCheck(-1)).toBeFalsy() + expect(PrimeCheck(-3)).toBeFalsy() + expect(PrimeCheck(-7)).toBeFalsy() + }) })