Repository navigation
Fix CodeCoverageTracker.Clear and silent null from TestSuiteManager - #101
Merged
Merged
Conversation
Clear(string codeModuleName = null) threw a NullReferenceException for the default value. Null or empty now clears all modules. Clear(name) also removes the module from the tracker, so the report no longer lists it.
TestSuiteManager.InitTestSuite only showed the exception and returned a null suite, so VBA failed later with a meaningless message. The exception is now logged and rethrown as InvalidOperationException with the original message; UI callers already show exceptions themselves. TestSuiteInitialized is raised only on success.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
CodeCoverageTracker.Clear(string codeModuleName = null)threw aNullReferenceExceptionfor the default value. Null or empty now clears all modules;Clear(name)also removes the module from the tracker, so the report no longer lists it.TestSuiteManager.InitTestSuiteonly showed the exception and returned anullsuite, so VBA failed later with a meaningless message. The exception is now logged and rethrown asInvalidOperationException("AccUnit test suite could not be initialized: <original message>").TestSuiteInitializedis raised only on success.TestListAndResultManagershows the exception itself when creating the test window;TestStarteralready caught it.InternalsVisibleTo("AccUnit.VbeAddIn.Tests")added soTestSuiteManagercan be tested.Tests
CodeCoverageTrackerTests(3),TestSuiteManagerTests(1).AccUnit.Assertions.Tests127/127,AccUnit.VbeAddIn.Tests7/7 (MSBuild + vstest, VS 18).Add,Clear(name)andClear()on a real VBProject behave as expected.Not verified / notes
Err.Description) needs the registered VBE add-in and was not tested.Track()still creates unregistered modules without procedure info.