Repository navigation
Release/v6.0.0 - #19
Merged
Merged
Conversation
…der, and OpenFeature DI extensions
…geCondition, and API examples
…ve v6.0.0 details
…v6.0.0 release notes
…NotReady error handling, and provider hooks support to FeatureOneProvider
…FeatureOne IFeatureLogger
…ne library under FeatureOne.OpenFeature namespace
…ication compliance while preserving version history
…cification compliance
OpenFeature review follow-up. Six areas, plus two RelationalCondition bugs surfaced along the way. Context mapping: FormatValue only handled bool and DateTime, then fell through to Value.AsString, which returns null for every other type. Integer, double, list and structure attributes were silently dropped, so conditions targeting them evaluated as disabled with no error. Numbers now format via the invariant culture; lists and structures serialize to JSON. Note AsInteger rounds rather than reporting non-integral values, so integral-ness is decided explicitly - 1.5 must not become "2". The repo's own ToClaims test asserted this and failed. Provider: InitializeAsync assigned a store to an unused local and could not throw, so status never became Error and every error-state guard across the five resolvers was unreachable. It now resolves the store and reports Error when none is available. A missing store resolves as ProviderNotReady rather than FlagNotFound, so a misconfigured app is not mistaken for a typo'd flag key. Hooks moved to an ImmutableList swapped under Interlocked, since the provider is a DI singleton and AddHook could mutate a list another thread was reading. The five near-identical resolvers collapse into one generic Resolve<T>. DI: SetProviderAsync ran as a side effect of the TryAddSingleton factory, so the global provider was only set if something resolved FeatureOneProvider, and it blocked on an async call inside the factory. Moved to an IHostedService. Added an options overload for hooks - FeatureOneLoggingHook existed with no wiring to reach it. Conditions: SafeConditionTypes was a private static allow list with no registration API, so a custom ICondition could not be deserialized without reimplementing IConditionDeserializer, including its private hydration logic. Added ConditionDeserializer.Register<T>(name), validating ICondition, concreteness and a parameterless ctor. Deny-by-default is preserved: types are still resolved from an allow list, never loaded by name from configuration. Bare Exception becomes FeatureOneConfigurationException, and hydration no longer re-parses the JSON once per writable property. RelationalCondition: LessThan fell through to the switch default and always returned false, so toggles using it could never enable. Numeric claims were compared with string.Compare, ranking "9" above "18". Comparison strategy is now chosen from the values - numeric when both parse, ordinal string otherwise - so age > 18 is arithmetic while tier >= "gold" stays lexical. decimal is tried before double to keep large integers exact. String comparison is now ordinal; the culture-sensitive overload made results machine-dependent. Docs: README, wiki and DeveloperGuide gave OpenFeature nearly all the weight and the native IFeatures API almost none. They now present both as peers with paired samples and a comparison table. Corrected every claim of a separate FeatureOne.OpenFeature NuGet package - the provider ships inside FeatureOne under that namespace. Documented the boolean-projection semantics of the non-boolean resolvers, which were undocumented and read as multivariate support. Filled in the four wiki sections its TOC promised but never contained and fixed its relative links, which pointed at docs/ from inside docs/. Behavioural changes for a major release: condition deserialization throws FeatureOneConfigurationException instead of Exception, and numeric RelationalCondition toggles now evaluate arithmetically. 272 tests pass, up from 260 with 4 previously failing.
Nshai
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release v6.0.0 of
FeatureOne,FeatureOne.FileandFeatureOne.SQL. The main addition is an OpenFeature Specification (v1.x) provider, which ships inside the coreFeatureOnepackage under theFeatureOne.OpenFeaturenamespace. There is no separate NuGet package to install.The native
IFeaturesAPI is unchanged and fully supported. OpenFeature is offered as a second way to use the library, not a replacement for the native API.What's new
FeatureOneProvider: an OpenFeatureFeatureProviderthat resolves Boolean, String, Integer, Double and Structure flags. The non-boolean resolvers return a value derived from the boolean toggle result. They do not support multiple variants.InitializeAsync/ShutdownAsync,ProviderStatustracking, andProviderNotReady/ error-state handling across all resolvers.FeatureOneLoggingHook, which routes OpenFeature hook events to FeatureOne'sIFeatureLogger.EvaluationContextExtensionsmaps the OpenFeatureTargetingKeyand attributes to FeatureOne claims.AddFeatureOneOpenFeature(...)forIServiceCollection, including an options overload for hooks. The global provider is registered by anIHostedServiceat startup.ConditionDeserializer.Register<T>("Name")registers user-definedIConditiontypes. Types are still resolved only from an allow list, never loaded by name from configuration.Featuresnow exposes itsFeatureStore.Fixes
EvaluationContextattributes were silently dropped during claims mapping, so conditions that targeted them evaluated as disabled without reporting an error.InitializeAsynccould never fail, so none of the provider's error-state guards could ever run.FlagNotFound. It now reportsProviderNotReady.FeatureOneProvider, and it blocked on an async call inside the DI factory.ImmutableListthat is swapped atomically.ConditionDeserializerre-parsed the toggle JSON once per writable property.RelationalCondition:LessThanwas never implemented and always returnedfalse."9"ranked above"18".Breaking changes
FeatureOneConfigurationExceptioninstead of a bareException.RelationalConditionnow compares numerically when both values parse as numbers, and ordinally otherwise. Toggles that compare numeric claims withGreaterThan,GreaterThanOrEqual,LessThanorLessThanOrEqualwill evaluate differently, and now correctly.Equalsalso treats equivalent numeric forms as equal, so"5.0"now equals"5".Packaging
6.0.0.netstandard2.1;net9.0;net10.0.FeatureOne:OpenFeature2.14.1 andMicrosoft.Extensions.Hosting.Abstractions10.0.5.Docs
DeveloperGuide.md,ClassDiagram.png,CHANGELOG.md, the release summary/table and a newwiki.mdnow live underdocs/.FeatureOne.OpenFeaturepackage.Testing
FeatureOne.OpenFeature.Testsproject, which covers resolution types, context mapping, error codes, lifecycle, hook concurrency, DI registration and global client integration.RelationalCondition.