Repository navigation
Support pathlib paths for PDFKit inputs and output - #278
Open
Aschenbath wants to merge 1 commit into
Open
Aschenbath wants to merge 1 commit into
Aschenbath wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Passing a
pathlib.Pathtofrom_file()currently fails before launching wkhtmltopdf, and Path objects in other command positions can mask conversion errors with aTypeError. Normalize filesystem path objects at the source, executable, and command boundaries, while retaining ordinary strings and file streams.Fixes #235. The README now includes a Path example. Regression tests cover single and mixed-list inputs, a custom bytes-returning path object, CSS, cover/output/executable paths, stdin streams, and error reporting.
Validation on Python 3.12 / Windows:
git diff --checkpasses.The 17 wkhtmltopdf-dependent integration tests were not run; wkhtmltopdf is not installed in this environment.
Developed with assistance from OpenAI Codex.