Skip to content

feat(assets-controller): add real time market stats - #11193

Open
Kriys94 wants to merge 1 commit into
mainfrom
feature/MarketStats
Open

Kriys94 wants to merge 1 commit into
mainfrom
feature/MarketStats

Conversation

@Kriys94

@Kriys94 Kriys94 commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Explanation

https://www.loom.com/share/a7c45936a44344be86349497c916ad0c

Spot prices today come from a poll of GET /v3/spot-prices and are stored on AssetsController as assetsPrice. A screen can only show that polled price, and it does not update until the next poll.

This adds a live quote next to that poll. The gateway already publishes price changes on market-stats.v1. The wallet opens one channel per asset and currency (market-stats.v1.<caip-19>.<currency>), and the gateway sends every change as one batch on market-stats.v1, about every 30 seconds. Chain health arrives on system-notifications.v1.market-stats.v1.

A screen reads two prices:

  • Redux assetsPrice is still the polled price. PriceDataSource writes it, and it is what gets persisted.
  • MarketStatsStore is an in-memory cache of the latest socket quote. A tick updates that store and does not write Redux, so it does not persist and does not notify AssetsController.

The screen shows the live quote when the store has one for that asset. Otherwise it shows the polled price.

PriceDataSource asks for includeWssSupportField=true. After each poll it opens channels, in one subscribe call, for tracked assets whose stored price has wssSupport: true. Hidden assets stay out. Assets without wssSupport, assets the gateway rejects, and assets on a chain reported down stay on the poll. A rejected channel is retried on the next poll. A down chain waits a short delay, then polls again. If MarketStatsService is not registered, every asset stays on the poll.

Screens for an asset the account does not hold (explore, search, an asset page with no balance row) call MarketStatsService:subscribe themselves. That quote lands in the same store. Nothing is written to assetsPrice.

Design notes that are easy to miss:

  • Subscribe and delivery use different channels. The wallet subscribes per asset. Prices arrive later as one batch on market-stats.v1.
  • A channel that is already open is left as it is. A second subscribe does not add another hold, so the caller's unsubscribe closes it. If the asset is also in the tracked set, the next price-poll reconcile opens it again.
  • EVM token addresses are lowercased before the channel is built. The gateway stores them that way, so a checksummed custom token matches the channel the server already accepted.
  • A subscribe the gateway rejects does not reconnect the shared socket. Other consumers of that socket stay up, and the caller keeps polling that asset.
  • An error event with no request id fails only the in-flight market-stats subscribe it names.
  • The first subscribe registers the chain-status callback and the batch callback. There is no init().
  • The gateway caps a session at 200 channels. Tracked assets and screen-driven subscribes share that limit.

@metamask/assets-controller needed two other packages:

  • @metamask/core-backend owns the shared socket, so MarketStatsService lives there. ChannelSubscriptionManager now subscribes and unsubscribes many channels in one frame, which market stats uses and OHLCV keeps using. BackendWebSocketService.subscribe skips channels the socket already has, and a partial subscribe keeps the channels the gateway accepted.
  • @metamask/wallet constructs MarketStatsService and delegates the BackendWebSocketService actions it needs. Wallet does not construct BackendWebSocketService. The host still registers that service. The first subscribe is what starts listening.

Breaking changes

  • AssetsController:priceChanged is removed. Socket ticks are MarketStatsService:pricesUpdated. Polled prices stay in assetsPrice.
  • AssetsControllerMessenger now includes MarketStatsService:subscribe, unsubscribe, getSubscriptions, getChainStatuses, and chainStatusChanged. Delegate them from the root messenger.
  • PriceDataSource requires messenger. The stream is always constructed. With no registered MarketStatsService, every asset stays on the poll.
  • Wallet now registers MarketStatsService. A host that already registers that service on the wallet messenger must remove that registration before upgrading.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

High Risk
Breaking controller/messenger and price event contracts, plus new WebSocket subscription behavior on the shared backend socket that affects how prices are sourced and displayed.

Overview
Adds live spot prices alongside the existing /v3/spot-prices poll: tracked assets with wssSupport open market-stats.v1 channels through new MarketStatsPriceStream wired into PriceDataSource (now requires a messenger with MarketStatsService actions). Polling still covers every tracked asset and requests includeWssSupportField=true; socket ticks are not merged into assetsPrice.

Breaking: removes AssetsController:priceChanged; consumers subscribe to MarketStatsService:pricesUpdated and use the re-exported quote helpers from @metamask/core-backend, which adds MarketStatsService and related WS plumbing. AssetsController reconciles streams after balance writes and reopens channels after currency refresh; BackendWebSocketService now surfaces partial subscribe failures and unsubscribeChannels.

Includes architecture docs, changelogs, and broad test/fixture updates (fungible price shape, Stellar account types, lint suppressions).

Reviewed by Cursor Bugbot for commit 98d550d. Bugbot is set up for automated code reviews on this repo. Configure here.

@Kriys94
Kriys94 force-pushed the feature/MarketStats branch 5 times, most recently from 53683f1 to 366f0e5 Compare November 5, 2026 20:56
@Kriys94
Kriys94 force-pushed the feature/MarketStats branch 4 times, most recently from de1cebf to b34a7ac Compare November 9, 2026 16:38
@Kriys94 Kriys94 changed the title Feature/market stats feat(assets-controller): add real time market stats Nov 10, 2026
@Kriys94
Kriys94 force-pushed the feature/MarketStats branch 3 times, most recently from 57aca30 to 1dc195a Compare November 12, 2026 22:43
@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

🛑 Files requiring codeowner review

To merge this PR, you'll need to get approvals from the following owners.

@MetaMask/core-platform (8 files)
  • packages/wallet/CHANGELOG.md
  • packages/wallet/package.json
  • packages/wallet/src/initialization/instances/index.ts
  • packages/wallet/src/initialization/instances/market-stats-service/market-stats-service.test.ts
  • packages/wallet/src/initialization/instances/market-stats-service/market-stats-service.ts
  • packages/wallet/tsconfig.build.json
  • packages/wallet/tsconfig.json
  • packages/wallet/tsconfig.lint.json
@MetaMask/metamask-assets (55 files)
  • packages/assets-controller/CHANGELOG.md
  • packages/assets-controller/docs/decisions/2026-11-05-market-stats.md
  • packages/assets-controller/README.md
  • packages/assets-controller/src/__fixtures__/MockAssetControllerMessenger.ts
  • packages/assets-controller/src/__fixtures__/scam-token-cleanup/captureTokenApiResponses.ts
  • packages/assets-controller/src/__fixtures__/spamWalletState.ts
  • packages/assets-controller/src/AssetsController-method-action-types.ts
  • packages/assets-controller/src/AssetsController.test.ts
  • packages/assets-controller/src/AssetsController.ts
  • packages/assets-controller/src/data-sources/AccountActivityDataSource.test.ts
  • packages/assets-controller/src/data-sources/AccountActivityDataSource.ts
  • packages/assets-controller/src/data-sources/AccountsApiDataSource.test.ts
  • packages/assets-controller/src/data-sources/index.ts
  • packages/assets-controller/src/data-sources/MarketStatsPriceStream.test.ts
  • packages/assets-controller/src/data-sources/MarketStatsPriceStream.ts
  • packages/assets-controller/src/data-sources/PriceDataSource.test.ts
  • packages/assets-controller/src/data-sources/PriceDataSource.ts
  • packages/assets-controller/src/data-sources/RpcDataSource.test.ts
  • packages/assets-controller/src/data-sources/SnapDataSource.test.ts
  • packages/assets-controller/src/index.ts
  • packages/assets-controller/src/middlewares/ParallelMiddleware.test.ts
  • packages/assets-controller/src/middlewares/RpcFallbackMiddleware.test.ts
  • packages/assets-controller/src/pipeline/buildFastFetchSources.bsc-spam-token-filtering.accounts-api-v6.integration.test.ts
  • packages/assets-controller/src/pipeline/buildWsUpdateSources.price-updates.integration.test.ts
  • packages/assets-controller/src/pipeline/buildWsUpdateSources.test.ts
  • packages/assets-controller/src/README.md
  • packages/assets-controller/src/selectors/balance.test.ts
  • packages/assets-controller/src/types.ts
  • packages/assets-controller/src/utils/assetVisibility.test.ts
  • packages/assets-controller/src/utils/formatExchangeRatesForBridge.test.ts
  • packages/assets-controller/src/utils/native-assets.test.ts
  • packages/core-backend/CHANGELOG.md
  • packages/core-backend/src/api/prices/client.test.ts
  • packages/core-backend/src/api/prices/client.ts
  • packages/core-backend/src/api/prices/types.ts
  • packages/core-backend/src/index.ts
  • packages/core-backend/src/ws/AccountActivityService.test.ts
  • packages/core-backend/src/ws/AccountActivityService.ts
  • packages/core-backend/src/ws/BackendWebSocketService-method-action-types.ts
  • packages/core-backend/src/ws/BackendWebSocketService.test.ts
  • packages/core-backend/src/ws/BackendWebSocketService.ts
  • packages/core-backend/src/ws/ChannelSubscriptionManager.test.ts
  • packages/core-backend/src/ws/ChannelSubscriptionManager.ts
  • packages/core-backend/src/ws/launchpad/LaunchpadTokenDetailsService.test.ts
  • packages/core-backend/src/ws/market-stats/index.ts
  • packages/core-backend/src/ws/market-stats/MarketStatsService-method-action-types.ts
  • packages/core-backend/src/ws/market-stats/MarketStatsService.test.ts
  • packages/core-backend/src/ws/market-stats/MarketStatsService.ts
  • packages/core-backend/src/ws/market-stats/normalize.test.ts
  • packages/core-backend/src/ws/market-stats/normalize.ts
  • packages/core-backend/src/ws/market-stats/types.ts
  • packages/core-backend/src/ws/market-stats/utils.test.ts
  • packages/core-backend/src/ws/market-stats/utils.ts
  • packages/core-backend/src/ws/ohlcv/OHLCVService.test.ts
  • packages/core-backend/vitest.config.ts
@MetaMask/social-ai (1 file)
  • packages/social-controllers/src/SocialRealtimeService.test.ts

ℹ️ Files co-owned by @MetaMask/core-platform (expand for more)

[!NOTE]
For convenience in maintaining this repo, @MetaMask/core-platform co-owns
the following files. It is not required to seek approval from
@MetaMask/core-platform to change these files. This section is purely
informational.

  • packages/assets-controller/CHANGELOG.md
  • packages/core-backend/CHANGELOG.md
  • packages/core-backend/vitest.config.ts

@Kriys94
Kriys94 force-pushed the feature/MarketStats branch 2 times, most recently from 7fcd76f to e80304d Compare November 13, 2026 12:36
@Kriys94

Kriys94 commented Nov 13, 2026

Copy link
Copy Markdown
Contributor Author

@metamaskbot publish-previews

@github-actions

Copy link
Copy Markdown
Contributor

Preview builds have been published. Learn how to use preview builds in other projects.

Expand for full list of packages and versions.
@metamask-previews/account-tree-controller@11.2.0-preview-e80304db4
@metamask-previews/accounts-controller@40.2.0-preview-e80304db4
@metamask-previews/address-book-controller@8.0.0-preview-e80304db4
@metamask-previews/advanced-chart-core@1.1.1-preview-e80304db4
@metamask-previews/ai-controllers@2.0.0-preview-e80304db4
@metamask-previews/analytics-controller@4.3.1-preview-e80304db4
@metamask-previews/analytics-data-regulation-controller@0.0.0-preview-e80304db4
@metamask-previews/announcement-controller@9.0.0-preview-e80304db4
@metamask-previews/app-metadata-controller@3.0.0-preview-e80304db4
@metamask-previews/approval-controller@10.0.0-preview-e80304db4
@metamask-previews/assets-controller@20.4.1-preview-e80304db4
@metamask-previews/assets-controllers@113.3.2-preview-e80304db4
@metamask-previews/authenticated-user-storage@4.1.0-preview-e80304db4
@metamask-previews/base-controller@10.1.0-preview-e80304db4
@metamask-previews/base-data-service@2.1.0-preview-e80304db4
@metamask-previews/bitcoin-regtest-up@2.0.0-preview-e80304db4
@metamask-previews/bridge-controller@83.1.5-preview-e80304db4
@metamask-previews/bridge-status-controller@78.0.3-preview-e80304db4
@metamask-previews/build-utils@4.0.0-preview-e80304db4
@metamask-previews/byte-utils@0.1.0-preview-e80304db4
@metamask-previews/chain-agnostic-permission@2.1.0-preview-e80304db4
@metamask-previews/chomp-api-service@7.1.0-preview-e80304db4
@metamask-previews/claims-controller@1.1.0-preview-e80304db4
@metamask-previews/client-controller@2.0.0-preview-e80304db4
@metamask-previews/client-utils@3.3.1-preview-e80304db4
@metamask-previews/compliance-controller@3.0.0-preview-e80304db4
@metamask-previews/composable-controller@13.0.0-preview-e80304db4
@metamask-previews/config-registry-controller@6.0.0-preview-e80304db4
@metamask-previews/connectivity-controller@1.0.0-preview-e80304db4
@metamask-previews/controller-utils@13.0.0-preview-e80304db4
@metamask-previews/core-backend@14.1.0-preview-e80304db4
@metamask-previews/cryptography@1.1.2-preview-e80304db4
@metamask-previews/delegation-controller@4.0.0-preview-e80304db4
@metamask-previews/earn-controller@13.1.0-preview-e80304db4
@metamask-previews/eip-5792-middleware@4.1.1-preview-e80304db4
@metamask-previews/eip-7702-internal-rpc-middleware@1.0.0-preview-e80304db4
@metamask-previews/eip1193-permission-middleware@3.0.0-preview-e80304db4
@metamask-previews/error-utils@0.1.0-preview-e80304db4
@metamask-previews/eth-block-tracker@16.0.0-preview-e80304db4
@metamask-previews/eth-json-rpc-middleware@26.0.1-preview-e80304db4
@metamask-previews/eth-json-rpc-provider@7.0.0-preview-e80304db4
@metamask-previews/eth-sig-util@10.0.0-preview-e80304db4
@metamask-previews/foundryup@2.0.0-preview-e80304db4
@metamask-previews/gas-fee-controller@27.1.1-preview-e80304db4
@metamask-previews/gator-permissions-controller@6.1.2-preview-e80304db4
@metamask-previews/geolocation-controller@2.0.0-preview-e80304db4
@metamask-previews/java-tron-up@2.0.0-preview-e80304db4
@metamask-previews/json-rpc-engine@11.0.0-preview-e80304db4
@metamask-previews/json-rpc-middleware-stream@9.0.0-preview-e80304db4
@metamask-previews/key-tree@11.0.0-preview-e80304db4
@metamask-previews/keyring-controller@28.2.1-preview-e80304db4
@metamask-previews/kyc-controller@0.16.0-preview-e80304db4
@metamask-previews/local-node-utils@2.0.0-preview-e80304db4
@metamask-previews/logging-controller@10.0.0-preview-e80304db4
@metamask-previews/marketing-consent-controller@1.1.0-preview-e80304db4
@metamask-previews/message-manager@15.0.1-preview-e80304db4
@metamask-previews/messenger@3.0.0-preview-e80304db4
@metamask-previews/messenger-cli@1.0.0-preview-e80304db4
@metamask-previews/mfa-recovery-controller@0.0.0-preview-e80304db4
@metamask-previews/money-account-api-data-service@2.4.0-preview-e80304db4
@metamask-previews/money-account-balance-service@3.2.1-preview-e80304db4
@metamask-previews/money-account-controller@3.0.0-preview-e80304db4
@metamask-previews/money-account-lifecycle-controller@1.0.0-preview-e80304db4
@metamask-previews/money-account-mfa-whitelist@0.2.0-preview-e80304db4
@metamask-previews/money-account-upgrade-controller@7.0.0-preview-e80304db4
@metamask-previews/money-account-utils@2.2.1-preview-e80304db4
@metamask-previews/multichain-account-service@14.1.0-preview-e80304db4
@metamask-previews/multichain-api-middleware@5.1.0-preview-e80304db4
@metamask-previews/multichain-network-controller@4.1.1-preview-e80304db4
@metamask-previews/multichain-transactions-controller@8.0.0-preview-e80304db4
@metamask-previews/name-controller@10.0.0-preview-e80304db4
@metamask-previews/network-connection-banner-controller@1.1.0-preview-e80304db4
@metamask-previews/network-controller@38.0.1-preview-e80304db4
@metamask-previews/network-enablement-controller@7.1.3-preview-e80304db4
@metamask-previews/node-utils@0.1.0-preview-e80304db4
@metamask-previews/notification-services-controller@30.1.0-preview-e80304db4
@metamask-previews/passkey-controller@4.1.0-preview-e80304db4
@metamask-previews/permission-controller@14.1.0-preview-e80304db4
@metamask-previews/permission-log-controller@6.0.0-preview-e80304db4
@metamask-previews/perps-controller@24.0.0-preview-e80304db4
@metamask-previews/phishing-controller@18.3.1-preview-e80304db4
@metamask-previews/platform-api-docs@0.2.1-preview-e80304db4
@metamask-previews/polling-controller@17.0.0-preview-e80304db4
@metamask-previews/preferences-controller@24.0.0-preview-e80304db4
@metamask-previews/profile-controller@3.1.0-preview-e80304db4
@metamask-previews/profile-metrics-controller@5.2.2-preview-e80304db4
@metamask-previews/profile-sync-controller@36.1.2-preview-e80304db4
@metamask-previews/ramps-controller@29.0.0-preview-e80304db4
@metamask-previews/rate-limit-controller@8.0.0-preview-e80304db4
@metamask-previews/react-data-query@2.0.0-preview-e80304db4
@metamask-previews/remote-feature-flag-controller@7.0.0-preview-e80304db4
@metamask-previews/sample-controllers@6.1.0-preview-e80304db4
@metamask-previews/seedless-onboarding-controller@12.0.0-preview-e80304db4
@metamask-previews/selected-network-controller@27.1.0-preview-e80304db4
@metamask-previews/sentinel-api-service@2.1.0-preview-e80304db4
@metamask-previews/shield-controller@7.1.2-preview-e80304db4
@metamask-previews/signature-controller@40.1.1-preview-e80304db4
@metamask-previews/smart-transactions-controller@27.2.3-preview-e80304db4
@metamask-previews/snap-account-service@4.0.0-preview-e80304db4
@metamask-previews/social-controllers@3.22.0-preview-e80304db4
@metamask-previews/solana-test-validator-up@2.0.0-preview-e80304db4
@metamask-previews/stellar-quickstart-up@0.0.0-preview-e80304db4
@metamask-previews/storage-service@2.0.0-preview-e80304db4
@metamask-previews/subscription-controller@15.2.2-preview-e80304db4
@metamask-previews/transaction-controller@74.0.0-preview-e80304db4
@metamask-previews/transaction-pay-controller@31.2.1-preview-e80304db4
@metamask-previews/transaction-pay-middleware@2.0.4-preview-e80304db4
@metamask-previews/type-utils@0.1.0-preview-e80304db4
@metamask-previews/user-operation-controller@42.1.2-preview-e80304db4
@metamask-previews/utils@12.0.2-preview-e80304db4
@metamask-previews/wallet@21.0.3-preview-e80304db4
@metamask-previews/watch-only-account-service@0.1.0-preview-e80304db4

@Kriys94
Kriys94 force-pushed the feature/MarketStats branch 3 times, most recently from 1bf8168 to 70269bb Compare November 18, 2026 15:44
@Kriys94

Kriys94 commented Nov 18, 2026

Copy link
Copy Markdown
Contributor Author

@metamaskbot publish-previews

@github-actions

Copy link
Copy Markdown
Contributor

The "Publish preview" workflow has been updated to a new version that uses OIDC for authentication. Please use the new workflow instead of this one.

To trigger the new workflow, go to the Publish a preview build workflow, click "Run workflow", and enter 11193 as the pull request number.

@github-actions

Copy link
Copy Markdown
Contributor

Preview builds have been published. Learn how to use preview builds in other projects.

Expand for full list of packages and versions.
@metamask-previews/account-tree-controller@11.2.0-preview-70269bbdb
@metamask-previews/accounts-controller@40.2.0-preview-70269bbdb
@metamask-previews/address-book-controller@8.0.0-preview-70269bbdb
@metamask-previews/advanced-chart-core@1.1.2-preview-70269bbdb
@metamask-previews/ai-controllers@2.0.0-preview-70269bbdb
@metamask-previews/analytics-controller@4.3.1-preview-70269bbdb
@metamask-previews/analytics-data-regulation-controller@0.0.0-preview-70269bbdb
@metamask-previews/announcement-controller@9.0.0-preview-70269bbdb
@metamask-previews/app-metadata-controller@3.0.0-preview-70269bbdb
@metamask-previews/approval-controller@10.0.0-preview-70269bbdb
@metamask-previews/assets-controller@20.4.1-preview-70269bbdb
@metamask-previews/assets-controllers@113.3.2-preview-70269bbdb
@metamask-previews/authenticated-user-storage@4.2.0-preview-70269bbdb
@metamask-previews/base-controller@10.1.0-preview-70269bbdb
@metamask-previews/base-data-service@2.1.0-preview-70269bbdb
@metamask-previews/bitcoin-regtest-up@2.0.0-preview-70269bbdb
@metamask-previews/bridge-controller@83.2.0-preview-70269bbdb
@metamask-previews/bridge-status-controller@78.0.3-preview-70269bbdb
@metamask-previews/build-utils@4.0.0-preview-70269bbdb
@metamask-previews/byte-utils@0.1.0-preview-70269bbdb
@metamask-previews/chain-agnostic-permission@2.1.0-preview-70269bbdb
@metamask-previews/chomp-api-service@7.1.0-preview-70269bbdb
@metamask-previews/claims-controller@1.1.0-preview-70269bbdb
@metamask-previews/client-controller@2.0.0-preview-70269bbdb
@metamask-previews/client-utils@3.4.0-preview-70269bbdb
@metamask-previews/compliance-controller@3.0.0-preview-70269bbdb
@metamask-previews/composable-controller@13.0.0-preview-70269bbdb
@metamask-previews/config-registry-controller@6.0.0-preview-70269bbdb
@metamask-previews/connectivity-controller@1.0.0-preview-70269bbdb
@metamask-previews/controller-utils@13.0.0-preview-70269bbdb
@metamask-previews/core-backend@14.1.0-preview-70269bbdb
@metamask-previews/cryptography@1.1.2-preview-70269bbdb
@metamask-previews/delegation-controller@4.0.0-preview-70269bbdb
@metamask-previews/earn-controller@13.1.0-preview-70269bbdb
@metamask-previews/eip-5792-middleware@4.1.1-preview-70269bbdb
@metamask-previews/eip-7702-internal-rpc-middleware@1.0.0-preview-70269bbdb
@metamask-previews/eip1193-permission-middleware@3.0.0-preview-70269bbdb
@metamask-previews/error-utils@0.1.0-preview-70269bbdb
@metamask-previews/eth-block-tracker@16.0.0-preview-70269bbdb
@metamask-previews/eth-json-rpc-middleware@26.0.1-preview-70269bbdb
@metamask-previews/eth-json-rpc-provider@7.0.0-preview-70269bbdb
@metamask-previews/eth-sig-util@10.0.1-preview-70269bbdb
@metamask-previews/foundryup@2.0.0-preview-70269bbdb
@metamask-previews/gas-fee-controller@27.1.1-preview-70269bbdb
@metamask-previews/gator-permissions-controller@6.1.2-preview-70269bbdb
@metamask-previews/geolocation-controller@2.0.0-preview-70269bbdb
@metamask-previews/java-tron-up@2.0.0-preview-70269bbdb
@metamask-previews/json-rpc-engine@11.0.0-preview-70269bbdb
@metamask-previews/json-rpc-middleware-stream@9.0.0-preview-70269bbdb
@metamask-previews/key-tree@11.0.0-preview-70269bbdb
@metamask-previews/keyring-controller@28.2.2-preview-70269bbdb
@metamask-previews/kyc-controller@0.16.0-preview-70269bbdb
@metamask-previews/local-node-utils@2.0.0-preview-70269bbdb
@metamask-previews/logging-controller@10.0.0-preview-70269bbdb
@metamask-previews/marketing-consent-controller@1.1.0-preview-70269bbdb
@metamask-previews/message-manager@15.0.1-preview-70269bbdb
@metamask-previews/messenger@3.0.0-preview-70269bbdb
@metamask-previews/messenger-cli@1.0.0-preview-70269bbdb
@metamask-previews/mfa-recovery-controller@0.1.0-preview-70269bbdb
@metamask-previews/money-account-api-data-service@2.4.0-preview-70269bbdb
@metamask-previews/money-account-balance-service@3.2.1-preview-70269bbdb
@metamask-previews/money-account-controller@3.0.1-preview-70269bbdb
@metamask-previews/money-account-lifecycle-controller@1.1.0-preview-70269bbdb
@metamask-previews/money-account-mfa-whitelist@0.3.0-preview-70269bbdb
@metamask-previews/money-account-upgrade-controller@7.0.0-preview-70269bbdb
@metamask-previews/money-account-utils@2.2.1-preview-70269bbdb
@metamask-previews/multichain-account-service@14.1.0-preview-70269bbdb
@metamask-previews/multichain-api-middleware@5.1.1-preview-70269bbdb
@metamask-previews/multichain-network-controller@4.1.1-preview-70269bbdb
@metamask-previews/multichain-transactions-controller@8.0.0-preview-70269bbdb
@metamask-previews/name-controller@10.0.0-preview-70269bbdb
@metamask-previews/network-connection-banner-controller@1.1.0-preview-70269bbdb
@metamask-previews/network-controller@38.0.1-preview-70269bbdb
@metamask-previews/network-enablement-controller@7.1.3-preview-70269bbdb
@metamask-previews/node-utils@0.1.0-preview-70269bbdb
@metamask-previews/notification-services-controller@30.1.0-preview-70269bbdb
@metamask-previews/passkey-controller@4.1.0-preview-70269bbdb
@metamask-previews/permission-controller@14.1.0-preview-70269bbdb
@metamask-previews/permission-log-controller@6.0.0-preview-70269bbdb
@metamask-previews/perps-controller@24.1.0-preview-70269bbdb
@metamask-previews/phishing-controller@18.3.1-preview-70269bbdb
@metamask-previews/platform-api-docs@0.2.1-preview-70269bbdb
@metamask-previews/polling-controller@17.0.0-preview-70269bbdb
@metamask-previews/preferences-controller@24.0.0-preview-70269bbdb
@metamask-previews/profile-controller@3.1.0-preview-70269bbdb
@metamask-previews/profile-metrics-controller@5.2.2-preview-70269bbdb
@metamask-previews/profile-sync-controller@36.1.2-preview-70269bbdb
@metamask-previews/ramps-controller@30.1.0-preview-70269bbdb
@metamask-previews/rate-limit-controller@8.0.0-preview-70269bbdb
@metamask-previews/react-data-query@2.0.0-preview-70269bbdb
@metamask-previews/remote-feature-flag-controller@7.0.0-preview-70269bbdb
@metamask-previews/sample-controllers@6.1.0-preview-70269bbdb
@metamask-previews/seedless-onboarding-controller@12.1.0-preview-70269bbdb
@metamask-previews/selected-network-controller@27.1.0-preview-70269bbdb
@metamask-previews/sentinel-api-service@2.3.0-preview-70269bbdb
@metamask-previews/shield-controller@7.1.2-preview-70269bbdb
@metamask-previews/signature-controller@40.1.1-preview-70269bbdb
@metamask-previews/smart-transactions-controller@27.3.0-preview-70269bbdb
@metamask-previews/snap-account-service@4.0.0-preview-70269bbdb
@metamask-previews/social-controllers@3.22.0-preview-70269bbdb
@metamask-previews/solana-test-validator-up@2.0.0-preview-70269bbdb
@metamask-previews/stellar-quickstart-up@0.0.0-preview-70269bbdb
@metamask-previews/storage-service@2.0.0-preview-70269bbdb
@metamask-previews/subscription-controller@15.3.0-preview-70269bbdb
@metamask-previews/transaction-controller@74.2.0-preview-70269bbdb
@metamask-previews/transaction-pay-controller@32.0.0-preview-70269bbdb
@metamask-previews/transaction-pay-middleware@2.0.4-preview-70269bbdb
@metamask-previews/type-utils@0.1.0-preview-70269bbdb
@metamask-previews/user-operation-controller@42.1.2-preview-70269bbdb
@metamask-previews/utils@12.0.2-preview-70269bbdb
@metamask-previews/wallet@21.0.4-preview-70269bbdb
@metamask-previews/watch-only-account-service@0.1.0-preview-70269bbdb

@Kriys94
Kriys94 force-pushed the feature/MarketStats branch from 70269bb to cf24e3c Compare November 18, 2026 16:29
@github-actions

Copy link
Copy Markdown
Contributor

Preview builds have been published. Learn how to use preview builds in other projects.

Expand for full list of packages and versions.
@metamask-previews/account-tree-controller@11.2.0-preview-cf24e3cc8
@metamask-previews/accounts-controller@40.2.0-preview-cf24e3cc8
@metamask-previews/address-book-controller@8.0.0-preview-cf24e3cc8
@metamask-previews/advanced-chart-core@1.1.2-preview-cf24e3cc8
@metamask-previews/ai-controllers@2.0.0-preview-cf24e3cc8
@metamask-previews/analytics-controller@4.3.1-preview-cf24e3cc8
@metamask-previews/analytics-data-regulation-controller@0.0.0-preview-cf24e3cc8
@metamask-previews/announcement-controller@9.0.0-preview-cf24e3cc8
@metamask-previews/app-metadata-controller@3.0.0-preview-cf24e3cc8
@metamask-previews/approval-controller@10.0.0-preview-cf24e3cc8
@metamask-previews/assets-controller@20.4.1-preview-cf24e3cc8
@metamask-previews/assets-controllers@113.3.2-preview-cf24e3cc8
@metamask-previews/authenticated-user-storage@4.2.0-preview-cf24e3cc8
@metamask-previews/base-controller@10.1.0-preview-cf24e3cc8
@metamask-previews/base-data-service@2.1.0-preview-cf24e3cc8
@metamask-previews/bitcoin-regtest-up@2.0.0-preview-cf24e3cc8
@metamask-previews/bridge-controller@83.2.0-preview-cf24e3cc8
@metamask-previews/bridge-status-controller@78.0.3-preview-cf24e3cc8
@metamask-previews/build-utils@4.0.0-preview-cf24e3cc8
@metamask-previews/byte-utils@0.1.0-preview-cf24e3cc8
@metamask-previews/chain-agnostic-permission@2.1.0-preview-cf24e3cc8
@metamask-previews/chomp-api-service@7.1.0-preview-cf24e3cc8
@metamask-previews/claims-controller@1.1.0-preview-cf24e3cc8
@metamask-previews/client-controller@2.0.0-preview-cf24e3cc8
@metamask-previews/client-utils@3.4.0-preview-cf24e3cc8
@metamask-previews/compliance-controller@3.0.0-preview-cf24e3cc8
@metamask-previews/composable-controller@13.0.0-preview-cf24e3cc8
@metamask-previews/config-registry-controller@6.0.0-preview-cf24e3cc8
@metamask-previews/connectivity-controller@1.0.0-preview-cf24e3cc8
@metamask-previews/controller-utils@13.0.0-preview-cf24e3cc8
@metamask-previews/core-backend@14.1.0-preview-cf24e3cc8
@metamask-previews/cryptography@1.1.2-preview-cf24e3cc8
@metamask-previews/delegation-controller@4.0.0-preview-cf24e3cc8
@metamask-previews/earn-controller@13.1.0-preview-cf24e3cc8
@metamask-previews/eip-5792-middleware@4.1.1-preview-cf24e3cc8
@metamask-previews/eip-7702-internal-rpc-middleware@1.0.0-preview-cf24e3cc8
@metamask-previews/eip1193-permission-middleware@3.0.0-preview-cf24e3cc8
@metamask-previews/error-utils@0.1.0-preview-cf24e3cc8
@metamask-previews/eth-block-tracker@16.0.0-preview-cf24e3cc8
@metamask-previews/eth-json-rpc-middleware@26.0.1-preview-cf24e3cc8
@metamask-previews/eth-json-rpc-provider@7.0.0-preview-cf24e3cc8
@metamask-previews/eth-sig-util@10.0.1-preview-cf24e3cc8
@metamask-previews/foundryup@2.0.0-preview-cf24e3cc8
@metamask-previews/gas-fee-controller@27.1.1-preview-cf24e3cc8
@metamask-previews/gator-permissions-controller@6.1.2-preview-cf24e3cc8
@metamask-previews/geolocation-controller@2.0.0-preview-cf24e3cc8
@metamask-previews/java-tron-up@2.0.0-preview-cf24e3cc8
@metamask-previews/json-rpc-engine@11.0.0-preview-cf24e3cc8
@metamask-previews/json-rpc-middleware-stream@9.0.0-preview-cf24e3cc8
@metamask-previews/key-tree@11.0.0-preview-cf24e3cc8
@metamask-previews/keyring-controller@28.2.2-preview-cf24e3cc8
@metamask-previews/kyc-controller@0.16.0-preview-cf24e3cc8
@metamask-previews/local-node-utils@2.0.0-preview-cf24e3cc8
@metamask-previews/logging-controller@10.0.0-preview-cf24e3cc8
@metamask-previews/marketing-consent-controller@1.1.0-preview-cf24e3cc8
@metamask-previews/message-manager@15.0.1-preview-cf24e3cc8
@metamask-previews/messenger@3.0.0-preview-cf24e3cc8
@metamask-previews/messenger-cli@1.0.0-preview-cf24e3cc8
@metamask-previews/mfa-recovery-controller@0.1.0-preview-cf24e3cc8
@metamask-previews/money-account-api-data-service@2.4.0-preview-cf24e3cc8
@metamask-previews/money-account-balance-service@3.2.1-preview-cf24e3cc8
@metamask-previews/money-account-controller@3.0.1-preview-cf24e3cc8
@metamask-previews/money-account-lifecycle-controller@1.1.0-preview-cf24e3cc8
@metamask-previews/money-account-mfa-whitelist@0.3.0-preview-cf24e3cc8
@metamask-previews/money-account-upgrade-controller@7.0.0-preview-cf24e3cc8
@metamask-previews/money-account-utils@2.2.1-preview-cf24e3cc8
@metamask-previews/multichain-account-service@14.1.0-preview-cf24e3cc8
@metamask-previews/multichain-api-middleware@5.1.1-preview-cf24e3cc8
@metamask-previews/multichain-network-controller@4.1.1-preview-cf24e3cc8
@metamask-previews/multichain-transactions-controller@8.0.0-preview-cf24e3cc8
@metamask-previews/name-controller@10.0.0-preview-cf24e3cc8
@metamask-previews/network-connection-banner-controller@1.1.0-preview-cf24e3cc8
@metamask-previews/network-controller@38.0.1-preview-cf24e3cc8
@metamask-previews/network-enablement-controller@7.1.3-preview-cf24e3cc8
@metamask-previews/node-utils@0.1.0-preview-cf24e3cc8
@metamask-previews/notification-services-controller@30.1.0-preview-cf24e3cc8
@metamask-previews/passkey-controller@4.1.0-preview-cf24e3cc8
@metamask-previews/permission-controller@14.1.0-preview-cf24e3cc8
@metamask-previews/permission-log-controller@6.0.0-preview-cf24e3cc8
@metamask-previews/perps-controller@24.1.0-preview-cf24e3cc8
@metamask-previews/phishing-controller@18.3.1-preview-cf24e3cc8
@metamask-previews/platform-api-docs@0.2.1-preview-cf24e3cc8
@metamask-previews/polling-controller@17.0.0-preview-cf24e3cc8
@metamask-previews/preferences-controller@24.0.0-preview-cf24e3cc8
@metamask-previews/profile-controller@3.1.0-preview-cf24e3cc8
@metamask-previews/profile-metrics-controller@5.2.2-preview-cf24e3cc8
@metamask-previews/profile-sync-controller@36.1.2-preview-cf24e3cc8
@metamask-previews/ramps-controller@30.1.0-preview-cf24e3cc8
@metamask-previews/rate-limit-controller@8.0.0-preview-cf24e3cc8
@metamask-previews/react-data-query@2.0.0-preview-cf24e3cc8
@metamask-previews/remote-feature-flag-controller@7.0.0-preview-cf24e3cc8
@metamask-previews/sample-controllers@6.1.0-preview-cf24e3cc8
@metamask-previews/seedless-onboarding-controller@12.1.0-preview-cf24e3cc8
@metamask-previews/selected-network-controller@27.1.0-preview-cf24e3cc8
@metamask-previews/sentinel-api-service@2.3.0-preview-cf24e3cc8
@metamask-previews/shield-controller@7.1.2-preview-cf24e3cc8
@metamask-previews/signature-controller@40.1.1-preview-cf24e3cc8
@metamask-previews/smart-transactions-controller@27.3.0-preview-cf24e3cc8
@metamask-previews/snap-account-service@4.0.0-preview-cf24e3cc8
@metamask-previews/social-controllers@3.22.0-preview-cf24e3cc8
@metamask-previews/solana-test-validator-up@2.0.0-preview-cf24e3cc8
@metamask-previews/stellar-quickstart-up@0.0.0-preview-cf24e3cc8
@metamask-previews/storage-service@2.0.0-preview-cf24e3cc8
@metamask-previews/subscription-controller@15.3.0-preview-cf24e3cc8
@metamask-previews/transaction-controller@74.2.0-preview-cf24e3cc8
@metamask-previews/transaction-pay-controller@32.0.0-preview-cf24e3cc8
@metamask-previews/transaction-pay-middleware@2.0.4-preview-cf24e3cc8
@metamask-previews/type-utils@0.1.0-preview-cf24e3cc8
@metamask-previews/user-operation-controller@42.1.2-preview-cf24e3cc8
@metamask-previews/utils@12.0.2-preview-cf24e3cc8
@metamask-previews/wallet@21.0.4-preview-cf24e3cc8
@metamask-previews/watch-only-account-service@0.1.0-preview-cf24e3cc8

@Kriys94
Kriys94 force-pushed the feature/MarketStats branch 2 times, most recently from c552582 to 3927e09 Compare November 19, 2026 09:21
@github-actions

Copy link
Copy Markdown
Contributor

Preview builds have been published. Learn how to use preview builds in other projects.

Expand for full list of packages and versions.
@metamask-previews/account-tree-controller@11.2.0-preview-3927e09
@metamask-previews/accounts-controller@40.2.0-preview-3927e09
@metamask-previews/address-book-controller@8.0.0-preview-3927e09
@metamask-previews/advanced-chart-core@1.1.2-preview-3927e09
@metamask-previews/ai-controllers@2.0.0-preview-3927e09
@metamask-previews/analytics-controller@4.3.1-preview-3927e09
@metamask-previews/analytics-data-regulation-controller@0.0.0-preview-3927e09
@metamask-previews/announcement-controller@9.0.0-preview-3927e09
@metamask-previews/app-metadata-controller@3.0.0-preview-3927e09
@metamask-previews/approval-controller@10.0.0-preview-3927e09
@metamask-previews/assets-controller@20.4.1-preview-3927e09
@metamask-previews/assets-controllers@113.3.2-preview-3927e09
@metamask-previews/authenticated-user-storage@4.2.0-preview-3927e09
@metamask-previews/base-controller@10.1.0-preview-3927e09
@metamask-previews/base-data-service@2.1.0-preview-3927e09
@metamask-previews/bitcoin-regtest-up@2.0.0-preview-3927e09
@metamask-previews/bridge-controller@83.2.0-preview-3927e09
@metamask-previews/bridge-status-controller@78.0.3-preview-3927e09
@metamask-previews/build-utils@4.0.0-preview-3927e09
@metamask-previews/byte-utils@0.1.0-preview-3927e09
@metamask-previews/chain-agnostic-permission@2.1.0-preview-3927e09
@metamask-previews/chomp-api-service@7.1.0-preview-3927e09
@metamask-previews/claims-controller@1.1.0-preview-3927e09
@metamask-previews/client-controller@2.0.0-preview-3927e09
@metamask-previews/client-utils@3.4.0-preview-3927e09
@metamask-previews/compliance-controller@3.0.0-preview-3927e09
@metamask-previews/composable-controller@13.0.0-preview-3927e09
@metamask-previews/config-registry-controller@6.0.0-preview-3927e09
@metamask-previews/connectivity-controller@1.0.0-preview-3927e09
@metamask-previews/controller-utils@13.0.0-preview-3927e09
@metamask-previews/core-backend@14.1.0-preview-3927e09
@metamask-previews/cryptography@1.1.2-preview-3927e09
@metamask-previews/delegation-controller@4.0.0-preview-3927e09
@metamask-previews/earn-controller@13.1.0-preview-3927e09
@metamask-previews/eip-5792-middleware@4.1.1-preview-3927e09
@metamask-previews/eip-7702-internal-rpc-middleware@1.0.0-preview-3927e09
@metamask-previews/eip1193-permission-middleware@3.0.0-preview-3927e09
@metamask-previews/error-utils@0.1.0-preview-3927e09
@metamask-previews/eth-block-tracker@16.0.0-preview-3927e09
@metamask-previews/eth-json-rpc-middleware@26.0.1-preview-3927e09
@metamask-previews/eth-json-rpc-provider@7.0.0-preview-3927e09
@metamask-previews/eth-sig-util@10.0.1-preview-3927e09
@metamask-previews/foundryup@2.0.0-preview-3927e09
@metamask-previews/gas-fee-controller@27.1.1-preview-3927e09
@metamask-previews/gator-permissions-controller@6.1.2-preview-3927e09
@metamask-previews/geolocation-controller@2.0.0-preview-3927e09
@metamask-previews/java-tron-up@2.0.0-preview-3927e09
@metamask-previews/json-rpc-engine@11.0.0-preview-3927e09
@metamask-previews/json-rpc-middleware-stream@9.0.0-preview-3927e09
@metamask-previews/key-tree@11.0.0-preview-3927e09
@metamask-previews/keyring-controller@28.2.2-preview-3927e09
@metamask-previews/kyc-controller@0.16.0-preview-3927e09
@metamask-previews/local-node-utils@2.0.0-preview-3927e09
@metamask-previews/logging-controller@10.0.0-preview-3927e09
@metamask-previews/marketing-consent-sync-service@0.0.0-preview-3927e09
@metamask-previews/message-manager@15.0.1-preview-3927e09
@metamask-previews/messenger@3.0.0-preview-3927e09
@metamask-previews/messenger-cli@1.0.0-preview-3927e09
@metamask-previews/mfa-recovery-controller@0.1.0-preview-3927e09
@metamask-previews/money-account-api-data-service@2.4.0-preview-3927e09
@metamask-previews/money-account-balance-service@3.2.1-preview-3927e09
@metamask-previews/money-account-controller@3.0.1-preview-3927e09
@metamask-previews/money-account-lifecycle-controller@1.1.0-preview-3927e09
@metamask-previews/money-account-mfa-whitelist@0.3.0-preview-3927e09
@metamask-previews/money-account-upgrade-controller@7.0.0-preview-3927e09
@metamask-previews/money-account-utils@2.2.1-preview-3927e09
@metamask-previews/multichain-account-service@14.1.0-preview-3927e09
@metamask-previews/multichain-api-middleware@5.1.1-preview-3927e09
@metamask-previews/multichain-network-controller@4.1.1-preview-3927e09
@metamask-previews/multichain-transactions-controller@8.0.0-preview-3927e09
@metamask-previews/name-controller@10.0.0-preview-3927e09
@metamask-previews/network-connection-banner-controller@1.1.0-preview-3927e09
@metamask-previews/network-controller@38.0.1-preview-3927e09
@metamask-previews/network-enablement-controller@7.1.3-preview-3927e09
@metamask-previews/node-utils@0.1.0-preview-3927e09
@metamask-previews/notification-services-controller@30.1.0-preview-3927e09
@metamask-previews/passkey-controller@4.1.0-preview-3927e09
@metamask-previews/permission-controller@14.1.0-preview-3927e09
@metamask-previews/permission-log-controller@6.0.0-preview-3927e09
@metamask-previews/perps-controller@24.1.0-preview-3927e09
@metamask-previews/phishing-controller@18.3.1-preview-3927e09
@metamask-previews/platform-api-docs@0.2.1-preview-3927e09
@metamask-previews/polling-controller@17.0.0-preview-3927e09
@metamask-previews/preferences-controller@24.0.0-preview-3927e09
@metamask-previews/profile-controller@3.1.0-preview-3927e09
@metamask-previews/profile-metrics-controller@5.2.2-preview-3927e09
@metamask-previews/profile-sync-controller@36.1.2-preview-3927e09
@metamask-previews/ramps-controller@30.1.0-preview-3927e09
@metamask-previews/rate-limit-controller@8.0.0-preview-3927e09
@metamask-previews/react-data-query@2.0.0-preview-3927e09
@metamask-previews/remote-feature-flag-controller@7.0.0-preview-3927e09
@metamask-previews/sample-controllers@6.1.0-preview-3927e09
@metamask-previews/seedless-onboarding-controller@12.1.0-preview-3927e09
@metamask-previews/selected-network-controller@27.1.0-preview-3927e09
@metamask-previews/sentinel-api-service@2.3.0-preview-3927e09
@metamask-previews/shield-controller@7.1.2-preview-3927e09
@metamask-previews/signature-controller@40.1.1-preview-3927e09
@metamask-previews/smart-transactions-controller@28.0.0-preview-3927e09
@metamask-previews/snap-account-service@4.0.0-preview-3927e09
@metamask-previews/social-controllers@3.22.0-preview-3927e09
@metamask-previews/solana-test-validator-up@2.0.0-preview-3927e09
@metamask-previews/stellar-quickstart-up@0.0.0-preview-3927e09
@metamask-previews/storage-service@2.0.0-preview-3927e09
@metamask-previews/subscription-controller@15.3.0-preview-3927e09
@metamask-previews/transaction-controller@74.2.0-preview-3927e09
@metamask-previews/transaction-pay-controller@32.0.0-preview-3927e09
@metamask-previews/transaction-pay-middleware@2.0.4-preview-3927e09
@metamask-previews/type-utils@0.1.0-preview-3927e09
@metamask-previews/user-operation-controller@42.1.2-preview-3927e09
@metamask-previews/utils@12.0.2-preview-3927e09
@metamask-previews/wallet@21.0.4-preview-3927e09
@metamask-previews/watch-only-account-service@0.1.0-preview-3927e09

@Kriys94
Kriys94 marked this pull request as ready for review November 19, 2026 11:54
@Kriys94
Kriys94 requested review from a team as code owners November 19, 2026 11:54

@cursor cursor Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

@Kriys94
Kriys94 force-pushed the feature/MarketStats branch 2 times, most recently from f6d6c8b to 826c10a Compare November 20, 2026 14:24
@github-actions

Copy link
Copy Markdown
Contributor

Preview builds have been published. Learn how to use preview builds in other projects.

Expand for full list of packages and versions.
@metamask-previews/assets-controller@21.0.0-preview-826c10a
@metamask-previews/core-backend@14.1.0-preview-826c10a
@metamask-previews/wallet@21.0.4-preview-826c10a

@cursor cursor Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

@Kriys94
Kriys94 force-pushed the feature/MarketStats branch from 826c10a to afc94f7 Compare November 20, 2026 14:33

@cursor cursor Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

@Kriys94
Kriys94 force-pushed the feature/MarketStats branch from afc94f7 to ef8fdc8 Compare November 20, 2026 21:04
@Kriys94
Kriys94 requested a review from a team as a code owner November 20, 2026 21:04

@cursor cursor Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

error,
},
);
return;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failed subscribe never retries while connected

Medium Severity

#subscribeOnSocket keeps a channel in #channels but never sends it when channelHasSubscription throws, or when subscribe fails with any error that does not contain Request failed. Those channels wait for the next CONNECTED event, so a failure while already connected is not retried and live quotes never start.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit ef8fdc8. Configure here.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not applicable on the current code. A request timeout closes the socket, and the CONNECTED handler sends the tracked channels again in one frame. A gateway refusal goes through #forget and is left closed so a session-cap rejection is not retried. A failure that leaves the channel tracked is sent again on the next connect.

@Kriys94
Kriys94 force-pushed the feature/MarketStats branch 2 times, most recently from e5e37c5 to a81375a Compare November 20, 2026 22:56
@github-actions

Copy link
Copy Markdown
Contributor

Preview builds have been published. Learn how to use preview builds in other projects.

Expand for full list of packages and versions.
@metamask-previews/assets-controller@21.0.0-preview-a81375a
@metamask-previews/core-backend@14.1.0-preview-a81375a
@metamask-previews/social-controllers@3.22.0-preview-a81375a
@metamask-previews/wallet@21.0.4-preview-a81375a

@cursor cursor Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

@Kriys94
Kriys94 force-pushed the feature/MarketStats branch 2 times, most recently from d96e511 to cabf5ed Compare November 20, 2026 23:52

@cursor cursor Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

@Kriys94
Kriys94 force-pushed the feature/MarketStats branch from cabf5ed to e122a49 Compare November 21, 2026 00:08

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

There are 2 total unresolved issues (including 1 from previous review).

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit e122a49. Configure here.

this.#getAssetIdsFromBalanceState(subscription.request),
);
await this.#marketStats.reconcile(this.#candidatesFor(assetIds));
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Teardown loses in-flight stream reconcile

Medium Severity

#reconcileMarketStats only checks #subscription before an await on #filterToSupportedPriceableAssets. If unsubscribe or destroy runs during that fetch, MarketStatsPriceStream still subscribes afterward. MarketStatsService serializes those calls, so a teardown subscribe([]) can be followed by the in-flight list and reopen assets-controller channels after lock, UI close, or controller destroy.

Additional Locations (2)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit e122a49. Configure here.

Co-authored-by: Cursor <cursoragent@cursor.com>
@Kriys94
Kriys94 force-pushed the feature/MarketStats branch from e122a49 to 98d550d Compare November 21, 2026 00:17
@github-actions

Copy link
Copy Markdown
Contributor

Preview builds have been published. Learn how to use preview builds in other projects.

Expand for full list of packages and versions.
@metamask-previews/assets-controller@21.0.0-preview-98d550d
@metamask-previews/core-backend@14.1.0-preview-98d550d
@metamask-previews/social-controllers@3.22.0-preview-98d550d
@metamask-previews/wallet@21.0.4-preview-98d550d

This branch was previously deployed

1 inactive (outdated) deployment
default-branch — 3927e093 Deployed Nov 19, 2026 by Kriys94 via Determine whether this PR is a release PR #7367
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants