Skip to content

Fix notification wrapping and cloud sync layout shifts - #1453

Merged
appergb merged 3 commits into
betafrom
fix/sync-feedback-layout
Nov 18, 2026
Merged

appergb merged 3 commits into
betafrom
fix/sync-feedback-layout

Conversation

@appergb

@appergb appergb commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

Changes

  • Size the shared notification card by its text, icon, and controls so short messages stay on one line at interface zoom. Long messages still wrap to the available width.
  • Remove the extra sync cancellation row. A non-modal surface exposes cancel in the notification; inside a modal, the section or dialog header owns the action so it remains reachable by keyboard.
  • Reserve a line for the last-sync timestamp and keep the password reminder above conditional errors.
  • Verify that channel and cloud-backup deletion use the shared confirmation dialog.
  • Synchronize all five desktop version files to 2.0.3-Beta.1; retain the existing Beta tag/channel, signing, and updater contract.

Verification

  • npm run build
  • Chromium and WebKit cancellation regressions, including keyboard cancellation in the actual welcome modal.
  • CloudSyncSection.test.ts and desktop-version-contract.test.mjs 2.0.3-Beta.1.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T14:31:05.385518Z 80a3c50 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@appergb
appergb requested a review from H-Chris233 November 18, 2026 14:13
@appergb

appergb commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator Author

Independent GPT-6.1 Terra review found that the welcome modal's focus scope disabled the only remaining cancellation action. The follow-up keeps exactly one action in the active modal's header, without reintroducing the lower action row. Terra re-reviewed the changes now at 80a3c505 and reported no blockers. This is a review record, not a GitHub approval.

Local verification passed: both Chromium and WebKit exercised the ordinary sync flow and keyboard cancellation in the actual welcome modal. The cloud-sync section unit test and the five-file 2.0.3-Beta.1 version contract also passed.

@appergb
appergb merged commit 872c329 into beta Nov 18, 2026
15 checks passed
@appergb

appergb commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator Author

Admin release handoff — 2.0.3-Beta.1

The reviewed source was merged to beta as 872c3293a8c8b10760017459a280526f3ebdf625. Exact-source CI run 44328507174 is green across all platform gates; the macOS MSRV runner allocation failure cleared on the targeted retry. The local Apple Silicon test package passed DMG layout and app-signature checks, but is not a cloud-release asset.

Release administrator: please cut v2.0.3-Beta.1-tauri on that exact commit and follow the existing Release (all platforms) signed build and shared GitHub prerelease procedure. The previous public Beta comparison base is v2.0.2-Beta.7-tauri. No tag, cloud release workflow, draft publication, or updater feed was changed by this handoff. The separate onboarding and language-selector changes are intentionally excluded from this Beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant