Skip to content

Redesign Ask Anything with a framed conversation and prompt box - #1456

Open
appergb wants to merge 6 commits into
betafrom
feat/ask-promptbox
Open

appergb wants to merge 6 commits into
betafrom
feat/ask-promptbox

Conversation

@appergb

@appergb appergb commented Nov 18, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Recreate the Rare UI prompt and streaming patterns in React, with a clipped 1950:830 desktop frame and platform-specific circular close button.
  • Keep the typed draft visible and unchanged through voice capture. Localize the recording status and support multiline input without intercepting IME composition.
  • Reuse the native QA stream and Web Search citations; route inline sources through the system browser and retain the response element at completion.

Validation

  • Frontend build
  • Targeted Chromium and WebKit QA/geometry/motion tests
  • Added native work-area scaling coverage for CI

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-18T16:40:43.485490Z ff3f0c5 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fd379326cf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +20 to +22
if (event.touches.length !== 1) return;
const nextY = event.touches[0].clientY;
if (touchY != null && nextY > touchY) scrollAway();

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Update the follow test to emit directional touch events

The existing message follow yields to the reader and resumes at the bottom test in e2e/interaction-polish.spec.ts still dispatches new Event('touchmove') to relinquish follow ownership. This handler now reads event.touches.length, which throws for that synthetic event; even supplying an empty touch list would not relinquish ownership without the new touch-start/direction sequence. Consequently, the subsequent content resize scrolls back to the bottom and the test's held-position assertion fails. Update the fixture to dispatch realistic touchstart and downward touchmove events, or use an upward wheel event, so the existing regression test exercises the new contract.

Useful? React with 👍 / 👎.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e1c2ebc109

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 29 to 31
const scrolled = () => {
if (!following && distance() > 1) movedAway = true;
if (!following && movedAway && distance() <= 1) following = true;
};
const pointerDown = (event: PointerEvent) => {
if (event.target === viewport) userScroll();
if (distance() <= 1) following = true;
};

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve follow opt-out when dragging the scrollbar

When a reader drags the conversation scrollbar upward while an answer is streaming, no wheel, touch, or keyboard event relinquishes follow ownership. The previous implementation handled this through pointerdown, but that listener has been removed, and this scroll handler only re-enables following. Consequently, the next content resize snaps the reader back to the bottom. Restore scrollbar-interaction handling so dragging away from the latest message holds the reader's position until they return to the bottom.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant