Repository navigation
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fd379326cf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (event.touches.length !== 1) return; | ||
| const nextY = event.touches[0].clientY; | ||
| if (touchY != null && nextY > touchY) scrollAway(); |
There was a problem hiding this comment.
Update the follow test to emit directional touch events
The existing message follow yields to the reader and resumes at the bottom test in e2e/interaction-polish.spec.ts still dispatches new Event('touchmove') to relinquish follow ownership. This handler now reads event.touches.length, which throws for that synthetic event; even supplying an empty touch list would not relinquish ownership without the new touch-start/direction sequence. Consequently, the subsequent content resize scrolls back to the bottom and the test's held-position assertion fails. Update the fixture to dispatch realistic touchstart and downward touchmove events, or use an upward wheel event, so the existing regression test exercises the new contract.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e1c2ebc109
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const scrolled = () => { | ||
| if (!following && distance() > 1) movedAway = true; | ||
| if (!following && movedAway && distance() <= 1) following = true; | ||
| }; | ||
| const pointerDown = (event: PointerEvent) => { | ||
| if (event.target === viewport) userScroll(); | ||
| if (distance() <= 1) following = true; | ||
| }; |
There was a problem hiding this comment.
Preserve follow opt-out when dragging the scrollbar
When a reader drags the conversation scrollbar upward while an answer is streaming, no wheel, touch, or keyboard event relinquishes follow ownership. The previous implementation handled this through pointerdown, but that listener has been removed, and this scroll handler only re-enables following. Consequently, the next content resize snaps the reader back to the bottom. Restore scrollbar-interaction handling so dragging away from the latest message holds the reader's position until they return to the bottom.
Useful? React with 👍 / 👎.
Summary
Validation