Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #610 +/- ##
==========================================
+ Coverage 80.18% 80.31% +0.13%
==========================================
Files 70 70
Lines 8442 8454 +12
Branches 1544 1543 -1
==========================================
+ Hits 6769 6790 +21
+ Misses 1182 1177 -5
+ Partials 491 487 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Creating v2 tables from DataFrames or TSV files now raises `MissingColumnsError` if required columns are missing, naming the table, the missing columns, and the file. Previously, this resulted in unspecific pydantic errors or `KeyError`s, or was silently accepted (e.g., a missing `estimate` column defaulted to `True`). `petablint` reports this error without a traceback. `BaseTable.from_df` now handles `None`/empty input, moves named index levels to columns, and checks required columns before delegating to the new abstract `_from_df`. The sciml `HybridizationTable` gets the same check. Relates to PEtab-dev#369. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dweindl
force-pushed
the
v2-missing-columns
branch
from
November 18, 2026 12:54
db38e0d to
b188bb3
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating v2 tables via
from_df/from_tsv(including theProblem.*_dfsetters) now raisespetab.v2.MissingColumnsErrorif required columns are missing. The message names the table, the missing columns, and the file, e.g.,ParameterTable is missing required column(s): estimate. File: .../parameters.tsv.petablintreports this without a traceback.Previously, missing columns resulted in pydantic errors per row, a bare
KeyError(experiment table), or were silently accepted (a missingestimatecolumn defaulted totrue, a missingexperimentIdcolumn to empty experiment IDs).BaseTable.from_dfnow handlesNone/column-less input, moves named index levels to columns, and checks required columns before delegating to the new abstract_from_df. As a side effect, condition and experiment tables now accept their ID column as index, like the other tables. The scimlHybridizationTablegets the same check.Relates to #369.
🤖 This pull request was created by an AI agent (Claude Code).
🤖 Generated with Claude Code