Repository navigation
Fix measurement alignment in goodness-of-fit and residual plots - #612
Open
ChenYueqi2024 wants to merge 2 commits into
Open
ChenYueqi2024 wants to merge 2 commits into
ChenYueqi2024 wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #247.
Goodness-of-fit and residual-versus-simulation plots currently pair values by row position, although residual calculation matches measurement metadata. Shuffling simulation rows therefore changes scatter points and regression statistics; repeated measurements backed by a single simulation row can also cause unequal-length errors.
Extract the existing residual calculation lookup into a shared private helper and use the same matching/ambiguity rules to align plotted simulation values with measurement order. This preserves replicate points, measurement-aligned colors, empty optional fields, and the input tables. Add a changelog fragment and four regression cases covering both plots, shuffled rows, multiple observables/conditions, repeated measurements, and duplicate DataFrame indices.
Validation on Windows / Python 3.12:
math/test_math.py,test_model_pysb.py, andtest_priors.pybecause the optional PySB/benchmark dependencies were not installed. The full v2 suite was not run.Implemented and validated with OpenAI Codex assistance.