Skip to content

FOUR-34380: Subprocess Inline to group task to reduce the visualizacion of BPMN-FE - #1970

Open
rodriquelca wants to merge 16 commits into
feature/FOUR-34328from
feature/FOUR-34380
Open

rodriquelca wants to merge 16 commits into
feature/FOUR-34328from
feature/FOUR-34380

Conversation

@rodriquelca

@rodriquelca rodriquelca commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Issue & Reproduction Steps

Implement bpmn:SubProcess as an embedded subprocess (not call activity): collapsed on the main canvas, internal flow edited via drill-down on the same paper.

From the toolbar, add Sub Process (processmaker-modeler-embedded-sub-process).
Enter via crown or the + on the shape; model Start → tasks → End inside.
Use Back to process to return to the main view; save and reopen the diagram.
Expected behavior:
Main canvas shows only the collapsed subprocess and main-level flows. Inside drill-down, only subprocess children are shown and editable. BPMN XML: model children under bpmn:SubProcess; DI as two diagrams (main process + subprocess plane per BPMN 2.0 §12).

Actual behavior (before):
Call activity covered “sub process”; no true embedded subprocess, no drill-down, or inconsistent DI/UX (duplicates, ghost selection, bad flow targets).

Solution

  • Node type processmaker-modeler-embedded-sub-process, drill-down (enterSubProcess / exitSubProcess), toolbar Back to process.
  • Children in subProcessContainer / flowElements of the subprocess; DI in a second BPMNDiagram.
  • Visibility, selection, connections, crown, and parse/export aligned with subprocess context.
image image

How to Test

  1. Add embedded subprocess; drill down; complete an internal flow; return to the main process.
  2. Reopen saved BPMN: main view collapsed; internal content only after entering the subprocess.
  3. Select and connect inside the subprocess—only internal elements.
  4. Export: subprocess children in MODEL under subProcess; two BPMNDiagram in DI.
  5. npx jest tests/unit/embeddedSubProcessDiagram.spec.js

Related Tickets & Packages

PR's Related

ProcessMaker/processmaker#9160

ci:processmaker:feature/FOUR-34328

@pmPaulis
pmPaulis requested a review from caleeli November 13, 2026 18:16
@pmPaulis pmPaulis changed the title FOUR-34380: Subprocess Inline to group task to reduce the visualizacion of BPMN - FE FOUR-34380: Subprocess Inline to group task to reduce the visualizacion of BPMN-FE Nov 13, 2026
@pmPaulis

Copy link
Copy Markdown
Contributor

@rodriquelca please review the Sonar observations

@cypress

cypress Bot commented Nov 17, 2026

Copy link
Copy Markdown

modeler    Run #1799

Run Properties:  status check passed Passed #1799  •  git commit a24775b9b9: FOUR-34380: Subprocess Inline to group task to reduce the visualizacion of BPMN-...
Project modeler
Branch Review feature/FOUR-34380
Run status status check passed Passed #1799
Run duration 06m 09s
Commit git commit a24775b9b9: FOUR-34380: Subprocess Inline to group task to reduce the visualizacion of BPMN-...
Committer Rodrigo Quelca
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 83
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 311
View all changes introduced in this branch ↗︎

@decisions-sonarqube

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants