Repository navigation
FOUR-34335: Add Responder Tracking and Personalized Email Links for Actions by Email - #9169
sanjacornelius wants to merge 31 commits into
Conversation
… existing ABE send/click tests
PR SummaryMedium Risk Overview On click with tracking on, request data gains a nested Require Login now parks the full click query in cache behind an unencrypted Reviewed by Cursor Bugbot for commit 0f1bfca. Bugbot is set up for automated code reviews on this repo. Configure here. |
…params are not HTTP 500
|
QA server K8S was successfully deployed https://tenant-1.ci-654cabc8d7.engk8s.processmaker.net |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want fixes drafted automatically? Bugbot Autofix can create code changes for findings. A team admin can enable Autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0f1bfca. Configure here.
| return []; | ||
| } | ||
|
|
||
| $decoded = json_decode(base64_decode($encoded, true) ?: '', true); |
There was a problem hiding this comment.
Base64 query params break signatures
Medium Severity
abe_groups is standard Base64 placed in a query string and bound into the HMAC. Base64 + is a space in query parsing, and many email clients decode %2B back to + before the click. Strict base64_decode then fails, verification returns null, and email, user_id, and groups are all dropped even though the action still completes.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 0f1bfca. Configure here.
|
|
||
| $pending = Cache::pull(self::ABE_CLICK_CACHE_PREFIX . $ticket); | ||
| if (!is_array($pending) || ($pending['abe_uuid'] ?? null) !== $abe->uuid) { | ||
| return null; |
There was a problem hiding this comment.
Click ticket consumed on mismatch
Low Severity
Cache::pull deletes the parked ABE click before the cached abe_uuid is checked. A request that has the ticket cookie but hits a different token still burns the one-shot entry, so the later Require Login return cannot restore varName, varValue, or the signed recipient params and fails validation.
Reviewed by Cursor Bugbot for commit 0f1bfca. Configure here.
|
|
QA server K8S was successfully deployed https://tenant-1.ci-654cabc8d7.engk8s.processmaker.net |






This PR adds optional responder tracking for ABE, allowing the system to track which recipient clicked and completed an email action. When enabled, each recipient receives a personalized signed link and responder information is captured in request data. This work also introduces staggered email delivery to help reduce provider rate limiting and preserves responder tracking through Require Login scenarios.
Changes:
-
abe_email-
abe_user_id-
abe_groups-
abe_sigabe_responderobject within request data.abe_click_ticket.-
email-
authenticated_email-
identity_mismatchabe_email_stagger_secondsto reduce provider throttling and rate limiting.-
docs/abe-responder-tracking.mdDependencies:
-
EmailProvider::sendAsync()delayed send supportHow to Test
Responder Tracking Disabled
abe_responderdata is written to the requestResponder Tracking Enabled
abe_responderobject.Request Data Validation
Group Deduplication
Large Recipient Groups
Require Login / Forwarded Email Scenario
authenticated_emailcontains User B's email.identity_mismatchis set totrueRelated Tickets & Packages
ci:connector-send-email:subtask/FOUR-34335
ci:package-actions-by-email:subtask/FOUR-34335
ci:deploy
Code Review Checklist