Repository navigation
Firmware page: read the set's pins, point at omnipython-builds, say mcuctl - #254
Merged
Merged
Conversation
…cuctl The page threw on a set built after the pins moved to DEPENDENCIES.lock (firmware.json has one entry per pin, not UPSTREAM, deps.lock and modules.lock), so the board list never loaded. The verify line, the ELF and map links and the flash guide still named micropython-pydevices; the files are attested by, and the Release lives in, PyDevices/omnipython-builds. The terminal install text said mpftp, which is mcuctl now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The page's board list never loads for a set built from today's omnipython-builds.
renderPinsreadpins.UPSTREAM,pins['deps.lock']andpins['modules.lock'];firmware.jsonnow has one entry per pin ({commit, tag}or{version}), so the page stops with "Cannot convert undefined or null to object" and shows no boards. It now lists each pin with its tag or the first 12 characters of its commit.Three more things named the old repository or tool. The verify line (
gh attestation verify ... --repo PyDevices/micropython-pydevices) fails for these files, which are attested by PyDevices/omnipython-builds; the ELF, map and app-image links pointed at a Release that isn't there; and the install-from-a-file text said mpftp, which is mcuctl now. All three come from one constant,REPO, and a few strings.I staged the set built by omnipython-builds run 44233554945 (16 builds, 75 files) into a local copy of this branch, served it, and loaded every board with Playwright: no console errors, every served image matches its firmware.json sha256, every Release link names a file in the set. The verify command passes with the new repo and fails with the old one. Not covered: the ESP Web Tools Install button (needs a person at Chrome); the GIGA page still leaves its ROMFS image out of the steps.