Repository navigation
fix(microsoft-extensions-ai): pass chat options to the IChatClient - #1503
Open
pcbeingused333 wants to merge 1 commit into
Open
pcbeingused333 wants to merge 1 commit into
pcbeingused333 wants to merge 1 commit into
Conversation
GetChatCompletions built ChatOptions (temperature, max output tokens and the rendered function tools) but called GetResponseAsync(messages) without them, so the client always used its own defaults and the model never received the tool definitions. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No linked issue (sibling of the provider-state fixes in #1486/#1488: found by comparing what each chat provider does with the conversation state).
MicrosoftExtensionsAIChatCompletionProvider.GetChatCompletionsbuilds aChatOptionsfrom the conversation state (temperature,max_tokens) and adds every rendered agent function tooptions.Tools, but then calls_client.GetResponseAsync(messages)without it. The options are silently discarded: the client always runs with its own defaults, and the model never receives the function definitions, so agents cannot call functions through this provider.Fix: pass
optionstoGetResponseAsync.Test:
MicrosoftExtensionsAIChatOptionsTestsruns the provider against a capturingIChatClientand checks that temperature and max output tokens from the state, and a rendered function as a tool, reach the client. Both tests fail on main (the client receivesnulloptions) and pass with the change. Adds a project reference to the Microsoft.Extensions.AI plugin inBotSharp.Core.UnitTests.This change was prepared with the assistance of an AI coding tool (Claude Code); the author is responsible for the submission.