Repository navigation
fix(openai): subtract cached tokens from realtime input usage - #1504
Open
pcbeingused333 wants to merge 1 commit into
Open
pcbeingused333 wants to merge 1 commit into
pcbeingused333 wants to merge 1 commit into
Conversation
'a ?? 0 - b ?? 0' parses as 'a ?? (0 - b) ?? 0' in C#, so the cached token counts were never subtracted from text/audio input tokens in the OpenAI Realtime response.done handler. Parenthesize both operands. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No linked issue (sibling of the usage fixes in #1486: same token-accounting pattern, found by comparing the providers).
In
RealTimeCompletionProvider.OnResponsedDone,TextInputTokensandAudioInputTokensare computed asx ?? 0 - y ?? 0. In C#-binds tighter than??, so this parses asx ?? (0 - y) ?? 0and the cached count is never subtracted wheneverxis present. The reported input tokens therefore include the cached ones, which are also reported separately inCachedTextInputTokens/CachedAudioInputTokens, so cached input is counted twice in cost accounting. The Chat and Live providers already subtract the cached count.Fix: parenthesize both operands:
(x ?? 0) - (y ?? 0).Test:
OpenAiRealtimeUsageTestsfeeds aresponse.doneevent with 100 text / 50 audio input tokens, of which 30 / 20 are cached, through the provider and captures theTokenStatsModelpassed to the content-generating hook. It fails on main (text input = 100, expected 70) and passes with the change.This change was prepared with the assistance of an AI coding tool (Claude Code); the author is responsible for the submission.