Repository navigation
Conversation
…ssion ends a call with ConversationRelay:EndingLinesInterruptible (also per agent), off by default. On, the goodbye to a caller who stayed silent and the apology of a failed turn go out like any other line instead of interruptible:false. Why: Twilio acts on the "end" that follows such a line only once the line has played, and a playback it takes as still going never has. Only lines kept playing to the end were seen to get stuck so, and such a call stays up, silent, until the caller hangs up. A line the caller may cut into ends at their first word, and the call with it. What it costs when on: a caller who speaks over the goodbye cuts it short; the call ends there and their words are not answered, as before. Tests: BotSharp.Core.UnitTests ConversationRelay 17 of 17 (3 new). Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Contributor
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
Contributor
Author
|
Closing without merging: these two lines were never seen to get stuck, and the goodbye is said to a caller who has already stayed silent, so a caller's word is unlikely to be there to cut it. Not worth a setting. The branch stays on the fork in case it is needed later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A ConversationRelay session says two lines that always play to the end (
interruptible:false), each followed byend:GoodbyeOnSilence, or theidle-goodbyeprompt)Twilio acts on
endonly once what is queued has played. On some calls Twilio said the agent started speaking and never that it stopped; nothing queued behind that line played and none of the caller's words came through. Every case seen was on a line kept playing to the end; lines the caller may cut into never got stuck. If that happens on one of these two lines, theendbehind it is never acted on and the call stays up, silent, until the caller hangs up.What changed
ConversationRelay:EndingLinesInterruptible(andConversationRelay:Agents:<id>:EndingLinesInterruptible), off by default, so nothing changes unless it is set.interruptible:false): the caller's first word stops the line, and Twilio then acts on theend.What it costs when on
A caller who speaks over the goodbye or the apology cuts it short. The call ends there, and what they said is not answered: the session has already ended, as before.
Not verified
Whether a caller's word frees a playback Twilio takes as stuck has not been seen on a call (interruptible lines never got stuck, so there was nothing to free).
Tests
BotSharp.Core.UnitTests,ConversationRelay*: 17 of 17 (3 new: the goodbye with the setting on, shared and for one agent; the apology with it on). The existing tests still find both linesinterruptible:falsewith it off.🤖 Generated with Claude Code