Skip to content

refactor(twilio): raise OnStreamingStopped through HookEmitter.Emit - #1507

Merged
yileicn merged 1 commit into
SciSharp:masterfrom
yileicn:feat/twilio-streaming-stopped-hook
Nov 20, 2026
Merged

yileicn merged 1 commit into
SciSharp:masterfrom
yileicn:feat/twilio-streaming-stopped-hook

Conversation

@yileicn

@yileicn yileicn commented Nov 20, 2026

Copy link
Copy Markdown
Member

No description provided.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@qodo-code-review

Copy link
Copy Markdown
Contributor

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The refactor centralizes Twilio stream-stop callback dispatch through the shared emitter while retaining per-hook exception isolation, and no active review issues remain.

No open issues 🎉

What changed in this PR

Refactors Twilio stream termination handling to dispatch OnStreamingStopped callbacks through the shared HookEmitter.Emit infrastructure.

Changes:

  • Replaces the middleware's manual hook iteration and exception handling with HookEmitter.Emit.
  • Preserves callback execution in the termination path with per-hook exception isolation.
File Description
src/​Plugins/​BotSharp.Plugin.Twilio/​TwilioStreamMiddleware.cs Routes Twilio stream-stop callbacks through the shared hook emitter while preserving termination handling and exception isolation.

Review effort: Lite

@yileicn
yileicn merged commit 8785a70 into SciSharp:master Nov 20, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants