Repository navigation
Mage weapons follow their template's classes and two-handed flag - #80
Draft
XxFran10xX wants to merge 1 commit into
Draft
XxFran10xX wants to merge 1 commit into
XxFran10xX wants to merge 1 commit into
Conversation
…efresh Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status record
Left alone from the review:
isOutdatedcompares the final class tag whileapplysets the original layer of a class stat history, so a weapon whose history added a class would rebuild on every touch. No Mage weapon can get there today (runes carry no classes and every template now lists classes).Why
Mage is getting three weapon paths (ServerAssets PR): the staff, wand and blade templates list Arcanist, Evoker and Battlemage instead of Mage, and every Mage weapon becomes two-handed. A crafted mage weapon is rebuilt from its own data on refresh, so weapons players already hold would keep
required-class: Mageand stay one-handed. Nobody could use them after the change.What
GearTemplateSync: a weapon is outdated when its classes (as a set, ignoring case) or its two-handed flag differ from its MMOItems template. A refresh then copies only those two stats from the template. With a class stat history only its original layer changes; a template without classes or two-handed removes them.GearRefreshertreats that as one more reason to rebuild, and applies the sync while rewriting. Sockets, runes, part stats, name, skin and requirements are carried as before.Not in this PR
No release, nothing on Main or Tutorial.
🤖 Generated with Claude Code