Skip to content

docs: update outdated versioning section in CONTRIBUTING - #1603

Open
minilan677-netizen wants to merge 2 commits into
TestableIO:mainfrom
minilan677-netizen:docs/fix-typo-contributing-occured
Open

minilan677-netizen wants to merge 2 commits into
TestableIO:mainfrom
minilan677-netizen:docs/fix-typo-contributing-occured

Conversation

@minilan677-netizen

Copy link
Copy Markdown

What

Fixes a typo in the versioning section of CONTRIBUTING.md.

"occured" is corrected to "occurred" in the sentence that explains how the final version number is calculated from the base version and later changes.

Why

The contributor guide is the first document new contributors read. This is a clear spelling fix in that section.

Change

One-word spelling correction in CONTRIBUTING.md. No code or versioning-config changes.

Checks

  • Re-fetched CONTRIBUTING.md from current main and confirmed the typo was still present (line 7) and unclaimed by any open or closed PR.
  • Reviewed the one-line diff; only this typo was changed.
  • Ran codespell on CONTRIBUTING.md (clean after this change).
  • git diff --check is clean.

This PR was created with AI assistance and reviewed for correctness before submitting.

Corrected "occured" to "occurred" in the versioning section of the
contributor guide. No other changes.
@mergify

mergify Bot commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue). If it does not match the queue conditions yet, it enters the queue once it does.

  • Queue this pull request once it meets the queue conditions

@vbreuss vbreuss left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I appreciate the typo fix, the whole paragraph is out-of-date, as the version.json is no longer used for versioning, but instead uses tags for this.
Would you be willing to iterate on a fix of this paragraph instead?

@minilan677-netizen minilan677-netizen changed the title docs: fix typo in CONTRIBUTING ("occured") docs: update outdated versioning section in CONTRIBUTING Nov 21, 2026
@minilan677-netizen

Copy link
Copy Markdown
Author

Done, rewrote the Versioning and Branches / tags sections: versions now come from GitVersion and the v* release tags (no version.json), and only tag builds publish to nuget.org. Thanks for the review!

@vbreuss vbreuss left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the PR description, as it is now out-of-date.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants