Repository navigation
fix(server): keep LlamaProxy reusable after freeing its model - #2421
Open
cloudgpuapp wants to merge 1 commit into
Open
cloudgpuapp wants to merge 1 commit into
cloudgpuapp wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
LlamaProxy.free()removes_current_modelentirely. Callingfree()again, or asking the same proxy to load a model afterward, then raisesAttributeErrorbefore reaching the existing empty-model handling.Keep the attribute set to
Noneafter a successful close. A failed close still propagates its exception and retains the reference for a retry. This changes neither model selection nor the native close implementation and adds no concurrency guarantee.Validation on macOS arm64, Python 3.12.16:
server/model.pyandserver/settings.py, mocked model creation, and replaced the native package at import. It did not load the compiled backend or a model. The test file itself is a normal pytest file using the package imports.make lintandgit diff --checkpassed.make test, HTTP serving and GPU memory behavior were not run. In a built checkout with server/test extras, runpython -m pytest tests/test_server_model_lifecycle.py -qfor a normal-import check.AI assistance was used to prepare the change and tests. This is a server-proxy lifecycle fix; it does not add a provider or promotional link.