Repository navigation
Conversation
…ables, state, typed errors and events) The 1.x engine (assignment, holdouts, switchbacks, exposure queue, publish/close state machine) is kept as is behind a new public surface: - ABsmartlyClient.builder() replaces ABSmartly/ABSmartlyConfig/Client/ClientConfig/DefaultHTTPClientConfig. - ContextOptions (immutable builder) replaces ContextConfig. - context()/contextAsync()/newContext()/context(options, data); ContextState replaces the is* booleans. - treatment(), typed variable(key, default) and variable(key, Class, default), noun accessors. - Unchecked ABsmartlyException hierarchy; blocking twins rethrow the cause, not CompletionException. - Typed ContextEvent classes via onEvent() listeners and a Flow.Publisher (events()). - Transport interface; JdkHttpTransport (java.net.http) in a separate source set Android never loads. - Java 11 floor, JSpecify @NullMarked, SLF4J 2, Jackson shaded and relocated; core-api-java6, Apache HttpClient, jsr305 and findbugs-annotations removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… and publish for main and release/1.x - main.yml runs on push/PR for main and release/** (JDK 11 floor + JDK 25, and a JDK 21 lane). - publish.yml keeps the tag == VERSION check, publishes v* tags, and creates the GitHub release with --latest=false for 1.x versions so a 1.x patch never becomes latest. - The example app uses the new API. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…-events test Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…iew-gate follow-ups - Follow redirects (never https to http), retry dropped connections and connect timeouts, do not retry refused connections, and use HTTP/1.1 for plain http (no h2c upgrade), as the 1.x Apache transport did. Docs list the remaining differences instead of claiming the same policy. - Tests for I/O-error retry, max retries, refused connections, redirects, h2c, Long variables, owned transport close and stream overflow; wait for READY in the event tests (1.x ordering, now documented on ReadyEvent). - Contexts use the client's executor for their event streams; the shaded jar has no Class-Path entry. - Import order and Eclipse formatting per gradle/spotless.eclipseformat.xml; MIGRATING names the removed Default* classes; SWITCHBACK.md and CHANGELOG state switchback availability. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…out and stream drops - Contexts' events() streams run on the client's executor (counting executor test). - JdkHttpTransport's 3 s connect timeout default and the 'timed out connecting' message are asserted. - EventStream counts dropped events; a slow subscriber that requested nothing never blocks the producer and loses exactly the events past the buffer. - The shaded jar manifest rewrite drops only Class-Path and its continuation lines. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… when the client cannot be built Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Independent sdk-review on fdb1835: REQUEST_CHANGES on process gates only (CI not yet run on this head; cross-sdk pin/merge order, now written in the PR description), 0 P1/P2/P3 open. 5 P2 fixed across 5 reviewer passes (9d479fd: 4 P2 + 9 P3; b4d5373: 0 code P2 + 4 P3; c30262c: 2 P3; fdb1835: none). Reviewers were fresh subagents each time, not anchored on my conclusions. Final reviewer report and evidence log (fdb1835)REQUEST_CHANGES at Re-reviewed
Verified fixed (from the
|
| Tree | Identifier | How obtained | Verified |
|---|---|---|---|
| Released | Maven Central core-api:1.9.0 |
curl repo1.maven.org/.../core-api-1.9.0.jar → 200; maven-metadata latest/release 1.9.0 |
sha256 1dd0bafe… = earlier pass's copy (sources = tag v1.9.0 except SdkVersion) |
| Main / merge base | 07807b516df5 |
git merge-base origin/main HEAD |
|
| Head | fdb1835 |
git rev-parse HEAD |
Version / X-Agent / CHANGELOG agree: yes (VERSION = "2.0.0"; wire absmartly-java-sdk/2.0.0 ×20; ## 2.0.0 (unreleased)). git show --stat HEAD: ABsmartlyClient.java (+9/-1) and ABsmartlyClientTest.java (+30/-11).
2. Backwards compatibility
- API diff:
javap -public -sover allcom/absmartly/sdk/*.classin the shaded jar, prev (c30262c) vs head: 31563 vs 31563 lines,diff→ PUBLIC-API-IDENTICAL.javap -p BuildershowsdefaultTransport(Supplier)anddefaultTransport_as package-private/private. - Android lazy load:
javap -vcounts ofClass com/absmartly/sdk/JdkHttpTransport= 0 in ABsmartlyClient and 0 in Builder. - Consumer probes
v2n/P.java,f2/F.java,b2/B.javawere recompiled against the head jar (+ slf4j-api 2.0.16, jspecify 1.0.0) and compiled.v1n/P.javawas recompiled against the main jar. - Released tests vs head: N/A (API reshaped by the declared major, judged in earlier passes).
- Sweep:
collector.pyon ports 18921 (main) and 18922 (head), thenjava P http://127.0.0.1:<port>/v1:diff out_m.txt out_h.txt→ FULL-IDENTICAL (11 lines).norm.py+ agent mask → WIRE-IDENTICAL-MASKED (20 requests).x-application-version=1004in 20 of 20 requests on both.
- Error/null/logging contract: the commit only routes the default transport through a Supplier; the error path is unchanged (IllegalArgumentException is rethrown after the close).
- Public fields/hooks whose effect changed: none.
- Entry points: the default-transport seam is only in
ABsmartlyClientconstruction, which all creation APIs share.
3. Parity
- JS reference: NOT RUN (engine untouched; outputs and wire identical to main, §2).
- Numeric edge table: NOT RUN (same reason).
- cross-sdk-tests (companion
16eaaef=git ls-remote origin feat/java-sdk-v2-lanes):- Build: the head shaded jar was copied into
$S/m2ascore-api-2.0.0.jar, with the pom from the earlier pass (git diff c30262c HEAD -- core-api/build.gradle build.gradle→ empty). java-wrappercopy:gradle-8.5 -Dmaven.repo.local=$S/m2 -PcoreApiVersion=2.0.0 bootJar(JDK 21). Gradle 9.6.1 failed onsourceCompatibility, a tool artefact. The bundledcore-api-2.0.0.jarsha25679496196…= the head jar.- Run:
java -jar ... --server.port=3000, thenSDK_URLS_OVERRIDE=java=http://localhost:3000 python -I orchestrator/test_runner.py --sdk java --report $S/report_java.json→ rc=0,java ✓ PASS (304/304 tested, 1 skipped), Total Scenarios 305, skip 323. The first attempt without--reportreached 304 PASS / 0 FAIL / 1 SKIP and then crashed writing/results(permission), so it was rerun. - The
java-v1lane was not rerun (unaffected).
- Build: the head shaded jar was copied into
4. Tests and mutation
- Full suite on head:
JAVA_HOME=jdk11 ./gradlew --offline clean check -x spotlessCheck -Porg.gradle.java.installations.paths=/usr/lib/jvm/java-25-openjdk-arm64→ BUILD SUCCESSFUL in 17 s. XML sums:test705 tests, 0 failures, 0 errors, 0 skipped (5.7 s);testJdk25705/0/0/0 (3.6 s). 704 → 705 = 1 new test. - Flake check: 4×
sh -c 'while :; do :; done'on a 4-core box, then 12×--tests '*ABsmartlyClientTest' --tests '*JdkHttpTransportTest' --rerun-tasks→ pass=12 fail=0. - Mutants (
$S/mutrun.sh, full:core-api:test -PskipJdk25, worktreemut, reset after each):
| # | Mutant (file:line) | Killed by | Result |
|---|---|---|---|
| M9b | ABsmartlyClient:66 ctor-failure close if (false) |
transportIsClosedWhenTheClientCannotBeBuilt | killed |
| M9c | ABsmartlyClient:62 ownsTransport_ = true |
3 tests (closeLeavesSuppliedSchedulerAndTransportRunning, builderRequiresEveryConnectionSetting, transportIsClosed…) | killed |
| M9d | ABsmartlyClient:61 supplier bypassed → defaultTransport() |
transportIsClosedWhenTheClientCannotBeBuilt | killed |
| M9e | ABsmartlyClient:65 catch narrowed to IllegalStateException | transportIsClosedWhenTheClientCannotBeBuilt | killed |
| M9 | ABsmartlyClient close path if (false) |
clientClosesTheTransportItCreated | killed |
| C1 | Context ctor ignores parent executor | contextStreamsUseTheClientExecutor | killed |
| C2 | ABsmartlyClient EventDispatcher ignores builder executor | contextStreamsUseTheClientExecutor | killed |
| SA1 | Context:2658 empty application put as "" |
missingApplicationLeavesKeyOutOfMap | killed |
| SA2 | Context:2659 inject app_version=9.9.9 |
4 tests incl. appVersionIsNotAnAudienceVariable | killed |
| SA3 | Context:1653 split uses traffic seed | splitHashesUnitWithExperimentSeed, splitRuleRandomizesOverTheServingUnit | killed |
| SA4 | Context buildPublishAttributes filters user app_version |
publishKeepsUserSetAppVersionApplicationAndEnvironment | killed |
| SA5 | Client:71 raw X-Application-Version | applicationVersionIsNormalized | killed |
| M10 | Client:72 hardcoded agent | — | SURVIVED (also survives on main) |
| S2 | Context no attrsSeq copy |
— | SURVIVED (also survives on main) |
| S4 | Context no ruleKey copy |
— | SURVIVED (also survives on main) |
| F1 | Experiment ignoreUnknown=false |
5 tests | killed |
| E1 | Context rule scope env → null | userEnvironmentAttributeDoesNotChangeRuleScope, matchesRuleForEnvironment | killed |
Totals: 17 run / 14 killed / 3 survived, all pre-existing.
- Main check:
mutrun_main.shwith--no-daemon -Dfile.encoding=UTF-8. Unmutated main → BUILD SUCCESSFUL (752). M10-main, S2-main and S4-main → SURVIVED. The first attempt on the shared daemon (file.encoding=US-ASCII) had 8 Buffers/Hashing failures (AIOOBE inBuffers.encodeUTF8) on unmutated main; that was a daemon artefact and was discarded. - Fix-commit audit (
fdb1835):
| Commit | New state | Where else it must apply | Entry points skipping it | Mutant |
|---|---|---|---|---|
| fdb1835 | Builder.defaultTransport_ Supplier (package-private seam), default ABsmartlyClient::defaultTransport |
only the ctor's default-transport branch; ownsTransport_ still keyed on transport_ == null |
none (every build goes through the ctor) | M9d killed; Android constant-pool check 0 refs |
| fdb1835 | stream test asserts thread name | — | — | C1, C2 killed; 12/12 under load |
5. Performance
| Path | main | head | probe size / runtime | counter test exists? |
|---|---|---|---|---|
| warmed treatment+peek+variableValue, no rules | 297.2–297.6 ns / 3 reads, 0.0 B (rounds 2–4) | 295.5–295.7 ns / 3 reads, 0.0 B | B data.json, JDK 11 HotSpot aarch64 |
no new caches |
6. Forward compatibility
java F fx/*.jsonwith 17 fixtures (unknown keys at root, exp, variant, app and holdout; missing/null variant config; null name and unitType; assignmentRules null,"", bad, object, number and unknown type; reordered; null experiments):diff fo_h.txt /tmp/sdkrev2.cnxz/fo_h.txt→ FWD-IDENTICAL-TO-b4d5373.- vs main: only
null_experimentsdiffers (ready=false vs ready=true, both failed=true; intended). - THREW count 0.
7. Build / CI
clean check -x spotlessCheck→ BUILD SUCCESSFUL (tests ×2 JDKs, animalsniffer, jacoco, verifyShadedJar).- Spotless offline: added lines have 0 trailing-whitespace hits and 0 over 120 columns. The wrap style matches 8 existing ternaries (
grep -E '\? [^:]*$').removeUnusedImportsis a no-op (AtomicInteger is still used). Eclipse/greclipse: NOT RUN (network). - Floors: unchanged (
options.release = 11). - Newest runtime: JDK 25, 705/705.
- CI on this exact head:
gh run list --commit fdb1835…→[](unpushed). Gate. - Pins: companion
sdk-branches.sh:26 ["java-sdk"]="next/major"(feature branch). Gate.:29 java-sdk-v1 = v1.9.0OK.
8. Docs / CHANGELOG
git diff c30262c HEAD --stat -- '*.md'→ empty (none needed for a test seam and tests).- Stale strings:
git grep -n "1\.7\.0\|1\.8\.0\|1\.9\.0" -- '*.java' '*.gradle' README.md | grep -v src/test→ 0 hits.defaultTransportin docs → 0 hits (not public).
Findings
| Sev | Title | Evidence line above | Fixed in |
|---|---|---|---|
| Gate | CI + Spotless eclipse not run on head (unpushed) | §7 | — |
| Gate (release) | cross-sdk pin next/major and merge order |
§3, §7 | — |
| Fixed | flaky stream-executor test (12/12 under load) | §4 | fdb1835 |
| Fixed | M9b owned transport not closed on ctor failure (killed, plus M9c/d/e) | §4 | fdb1835 |
| Pre-existing | M10, S2, S4 survive on main and head | §4 | — |
Verification limits
- Spotless eclipse/greclipse: NOT RUN (network).
- CI: none (head unpushed).
- JS vectors / numeric edge table: NOT RUN (engine unchanged by this commit; outputs identical to main).
- cross-sdk
java-v1lane: NOT RUN (unaffected);javalane is a local orchestrator run against a JDK 21 wrapper, not Docker/CI. - Android/ART: NOT RUN. publishToMavenLocal: NOT RUN (signing).
|
Important Review skippedToo many files! This PR contains 199 files, which is 49 over the limit of 150. To get a review, reduce the PR to 150 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to Team to raise the limit.
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Independent sdk-review on edf3e1b: APPROVE, 0 P1/P2/P3 open. This push only applies the Spotless groovy formatting that CI flagged on fdb1835 (reproduced with the real Eclipse formatter from a mirror). Totals so far: 5 P2 fixed across 6 reviewer passes. Reviewer report and evidence log (edf3e1b)APPROVE (for push) at
Re-reviewed Verified fixed (from the
|
| Tree | Identifier | How obtained | Verified |
|---|---|---|---|
| Released | Maven Central core-api:1.9.0 |
curl repo1.maven.org/.../maven-metadata.xml → latest/release 1.9.0 |
jar = tag v1.9.0 per earlier passes (not re-hashed) |
| Main / merge base | 07807b516df5 |
git merge-base origin/main HEAD |
|
| Head | edf3e1b |
git rev-parse HEAD |
Version / X-Agent / CHANGELOG agree: yes (VERSION = "2.0.0", CHANGELOG.md:3 ## 2.0.0 (unreleased)). git show --stat edf3e1b → build.gradle (+3/-1), core-api/build.gradle (+3/-1).
2. Backwards compatibility
- API diff: the artifact is unchanged. Built the shaded jar on head and on prev (
clean build -x spotlessCheck), unzipped both,diff -r x_head x_prev→ JAR-CONTENT-IDENTICAL. - POM:
:core-api:generatePomFileForReleasePublicationon both → sha256bbb353431eee…on both. - Consumer probe / released tests / sweep: carried over from
fdb1835(artifact identical); not re-executed. - Error/null/logging contract, public fields/hooks, entry points: no source change (
git show --stat), so unchanged.
3. Parity
- JS reference / numeric edge table: NOT RUN (no source change; artifact identical).
- cross-sdk-tests: not re-executed. Companion
16eaaef=gh pr view 27 -R absmartly/cross-sdk-tests --json headRefOid(OPEN, draft). Prior result 304 eligible / 1 skip of 305 (skip 323) on a byte-identical jar. - Pin:
gh api .../sdk-branches.sh?ref=feat/java-sdk-v2-lanes→:26 ["java-sdk"]="next/major",:29 ["java-sdk-v1"]="v1.9.0". - Merge order: java-sdk#27 body line 195 and cross-sdk-tests#27 body "## Merge order" both state it.
4. Tests and mutation
- Full suite on head (worktree
head):JAVA_HOME=jdk11 ./gradlew --offline clean build -x spotlessCheck -Porg.gradle.java.installations.paths=/usr/lib/jvm/java-25-openjdk-arm64→ BUILD SUCCESSFUL in 16 s.- XML sums:
test705/0 fail/0 err/0 skip;testJdk25705/0/0/0.
- JDK 21 (worktree
mut, unmutated):JAVA_HOME=jdk21 ./gradlew --offline :core-api:test -PskipJdk25→ BUILD SUCCESSFUL; 705 tests, 0 failures. - Mutants:
/tmp/sdkrev6.h3yA/tools/run.sh(python replace, full:core-api:test -PskipJdk25,git checkout -- .after each):
| # | Mutant (file:line) | Killed by | Result |
|---|---|---|---|
| E1 | Context:1620 rule scope from user environment attribute |
1 test failed | killed |
| SA1 | Context:2658 empty application put as "" |
1 failed | killed |
| SA2 | Context:2659 inject app_version=9.9.9 |
4 failed | killed |
| SA3 | Context:1653 split uses traffic seed | 2 failed | killed |
| SA4 | Context:2697 user-set app_version filtered from publish |
1 failed | killed |
| SA5 | Client:71 raw X-Application-Version | 1 failed | killed |
| M10 | Client:72 hardcoded agent string | — | SURVIVED (pre-existing; also survives on main per fdb1835 pass) |
| M9b | ABsmartlyClient:67 ctor-failure close if (false) |
1 failed | killed |
| F1 | internal/json/Experiment ignoreUnknown=false |
5 failed | killed |
| B1 | core-api/build.gradle:69-71 drop runtimeClasspath from wrapped shadowJar list |
verifyShadedJar "Relocated Jackson is missing" | killed |
| B2 | build.gradle:54-56 "core-api" → "core-apix" in wrapped list |
build fails evaluating :core-api |
killed |
Totals: 11 run / 10 killed / 1 survived (M10, pre-existing).
- Fix-commit audit (
edf3e1b):
| Commit | New state | Where else it must apply | Entry points skipping it | Mutant |
|---|---|---|---|---|
| edf3e1b | none (whitespace/newline layout of 2 Groovy list literals) | every non-empty list literal in Spotless-targeted *.gradle (root, core-api, example); gradle/*.gradle is not targeted |
none: real greclipse passes on all 3 projects | B1, B2 killed; artifact identical |
5. Performance
| Path | main | head | probe size / runtime | counter test exists? |
|---|---|---|---|---|
| warmed treatment+peek+variableValue | not re-run | not re-run (jar identical to fdb1835: 295.5–295.7 ns/3 reads, 0 B) | — | no new caches |
6. Forward compatibility
- NOT RE-RUN: jar identical to
fdb1835, where 17 fixtures gave 0 throws.
7. Build / CI
- CI on
fdb1835(the pushed head):gh run view 44210628708.buildfailed at "Build Java SDK",:spotlessGroovyGradleCheck FAILED,build.gradle @@ -51,7 +51,9 @@ -\t["core-api"].contains(it.name) +\t[ +\t\t"core-api" +\t].contains(it.name).test-jdk21✓. - Formatter config:
gradle/spotless.groovyformat.prefshasgroovy.formatter.longListLength=1. Upstreamgroovy-eclipseGroovyBeautifier.formatListswraps whenrbrackOffset - lbrackOffset > longListLength(fetched viagh api repos/groovy/groovy-eclipse/contents/.../GroovyBeautifier.java). - Local real Spotless (scratch
headworktree only):gradle/spotless.gradleedited toeclipse()/greclipse().withP2Mirrors(["https://download.eclipse.org/eclipse/updates/4.26/": "https://ftp.fau.de/eclipse/releases/2022-12/202212071000/", …]).GrEclipseFormatterStep/EclipseJdtFormatterStepdefault version 4.26 (javap -constantson spotless-lib-extra 2.45.0).- First attempts: unmapped →
UnknownHostException download.eclipse.org; genericftp.fau.de/eclipse/→ 404 oneclipse/updates/4.26(the mirror only has 4.33+). The 2022-12 train worked. One run hit a transient mirror resolve error and was rerun. - Control:
fdb1835's two gradle files →:spotlessGroovyGradleCheckviolation (same hunk as CI) and:core-api:spotlessGroovyGradleCheckviolation (configurations = [project.configurations.runtimeClasspath]at :66). - Head:
./gradlew --no-daemon spotlessCheck --rerun-tasks→ BUILD SUCCESSFUL (spotlessGroovyGradleCheck ×3, spotlessJavaCheck ×2). - Teeth: injected
returnin ABsmartlyClient.java and[ "core-api" ].each { }in example/build.gradle → both reported (:core-api:spotlessJavaCheck,:example:spotlessGroovyGradleCheck).
- Package:
clean buildok; verifyShadedJar ok. publishToMavenLocal NOT RUN (signing). - Floors: unchanged (
options.release = 11; no source/build-logic change). - Newest runtime: JDK 25 705/705.
- CI on this exact head: none (unpushed). Gate.
- Pins: companion
next/major(feature branch). Release gate, with the merge order documented in both PRs.
8. Docs / CHANGELOG
git diff fdb1835 HEAD --stat -- '*.md'→ empty (none needed).- Released sections:
CHANGELOG.mdheadings2.0.0 (unreleased),1.9.0 (unreleased)(main-era, pre-existing),1.8.0 (2026-11-11),1.7.0 (2026-11-11).git diff origin/main HEAD -- CHANGELOG.md | grep '^-## '→ 0 removed headings. - Stale strings:
git grep -n "1\.7\.0\|1\.8\.0\|1\.9\.0" -- '*.java' '*.gradle' README.md | grep -v src/test | wc -l→ 0.
Findings
| Sev | Title | Evidence line above | Fixed in |
|---|---|---|---|
| Fixed | CI red on fdb1835: spotlessGroovyGradleCheck (root and core-api build.gradle list wrapping) | §7 | edf3e1b |
| Gate | CI not yet run on edf3e1b (unpushed) | §7 | — |
| Gate (release) | cross-sdk pin next/major; merge order now documented |
§3 | — |
| Pre-existing | M10 survives on main and head | §4 | — |
Verification limits
- GitHub Actions on edf3e1b: none (unpushed).
- Spotless ran via a Eclipse 4.26 p2 mirror (ftp.fau.de 2022-12 train), not download.eclipse.org. Results match CI's on fdb1835.
- Not re-executed, because the artifact is byte-identical to fdb1835: behaviour sweep, wire probe, forward-compat, cross-sdk orchestrator, perf, JS vectors and the numeric edge table.
- Android/ART: NOT RUN. publishToMavenLocal: NOT RUN (signing).
|
Review submitted The automated review has been submitted. See the review for the verdict and any findings. Head: |
jervasion-absmartly
left a comment
There was a problem hiding this comment.
❌ Changes requested
The Java 2.0 migration has four reproducible issues to fix: request deadlines do not cover stalled response bodies, list defaults can hide valid variables, late event-stream subscribers never finish, and the installed example cannot start. The existing tests and exact-head CI pass, but do not catch these cases.
Next step: Fix the four inline findings and add focused regression coverage.
Must fix
- Bound response-body receipt by the request timeout — a stalled collector can keep a configured-deadline request waiting indefinitely.
- Infer collection types without requiring a concrete implementation match — valid list variables fall back to empty defaults.
- Preserve event-stream completion across lazy initialization — subscribing after close waits forever.
- Restore the example's SLF4J runtime dependency — its generated launcher fails before any request.
Suggestions (optional)
- Small comment-hygiene notes are listed below; none blocks this review.
What I checked
- ✅ Exact-head Actions
buildandtest-jdk21passed, including formatting and the Java 11/21/25 test lanes. - ✅ Local core suite: 705 tests passed on Java 11 and 705 on Java 25; Android signature validation, coverage gates and shaded-jar validation passed.
- ✅ Ran public-API probes against the shaded JAR on Java 11, reproducing the timeout, list-default and stream-completion failures.
- ❌ Built and launched the installed example with its required environment variables; it fails with
NoClassDefFoundError: org/slf4j/LoggerFactory.
Review details
Head: edf3e1bf7ecf597911fd5257a6aefc31c9cea410. Base and merge-base: 07807b516df5ad0d7d92e5b682041982802cd871. Initial review, round 1; complete merge-base-to-head scope.
Intent and scope: intentional major-version API breaks, Java 11 floor, immutable options and typed variables/events/errors, JDK HTTP transport, shaded Jackson, preserved assignment/exposure/publish/refresh engine semantics. JVM consumers and Kotlin/Scala/Android wrappers are affected. The owner explicitly defers release/1.x creation/workflow copying and defines the companion cross-SDK merge/repin order; those are not additional findings. Owner-reported cross-SDK results were read, not independently rerun.
Commands and evidence:
JAVA_HOME="${JAVA_HOME_11:?}" ./gradlew build -x spotlessCheck :example:installDist --console=plain: passed. Independent passes forced:core-api:test -PskipJdk25 --rerun-tasks(705 passing tests) and ran core checks including Java 25 (705 passing tests). Verified local Java and javac 11.0.33.- Local Spotless resolution was blocked by Eclipse DNS; exact-head Actions run 44214183482 passed both completed jobs and covers formatting. Commit statuses contain no separate statuses.
- Java 11 shaded-JAR public probe: JSON list
[actual]-> raw[actual], inferredCollections.emptyList()->[], explicitList.class->[actual]. - Same probe: first
events()call after context/client closure -> no terminal callback; code trace confirms no later close trigger. - Same probe with loopback HTTP server: 500 ms request timeout, immediate headers/first byte, final byte after 3 seconds -> future still incomplete after 1500 ms, eventually HTTP 200 after 3109 ms rather than a timeout.
JAVA_HOME="${JAVA_HOME_11:?}" ABSMARTLY_APIKEY=test ABSMARTLY_APP=app ABSMARTLY_ENV=test example/build/install/example/bin/example: startup class-loading failure, before network I/O.- Inspected CI/release configuration, publication POM, relocated Jackson/service files, typed error propagation, listener isolation, engine changes and test coverage. No Android ART runtime, external collector workflow, signing or publication was executed.
Passes (non-blocking): run: core runtime/API/security/data (new API and changed engine adapters); dedicated error specialist (changed HTTP, decoding and lifecycle failure paths; completed); tests/CI/packaging (changed suites, dependencies and artifacts); deployment/operations/observability (release workflow and event/drop logging); cross-cutting simplicity (new client, dispatch and transport machinery); behaviour-bearing data/policy (build/runtime configuration); comment hygiene; diff composition. Not run: shared frontend blast radius (no frontend source changed).
Comment hygiene (non-blocking): 391 comment / 5193 code lines, ratio ~1:13.3.
threshold T=52; restatements counted: no (10 × C < E).
Flagged small blocks: ABsmartlyClient.java:196 (restates scheduler ownership branch); EventStream.java:42 (restates drop-counter purpose); ContextState.java:3 (narrates 1.x naming history); TestContexts.java:9 (narrates old construction API); TestJson.java:9,14 (narrates old serializer/deserializer API). The short historical test-helper explanations are non-blocking and below T; no comment finding promoted. Platform constraints, event-ordering constraints and one-line API documentation were preserved.
Diff composition (non-blocking): every file is required for the change; none flagged. Ran the pinned introduced_blobs.py successfully and inspected/scanned all 201 content writes (201 unique blobs), including intermediate content, with no credential or scratch artifact identified. Rename-aware diff accounting excludes unchanged moved content.
Simplifications (non-blocking): none. In particular the lazy stream class and separate JDK transport source set serve the explicit Android loading constraint.
…treams after close; example runtime Addresses jervasion-absmartly's review of edf3e1b: - JdkHttpTransport enforces requestTimeout on the whole exchange, up to the last body byte (HttpRequest.timeout stops at the headers), failing with RequestTimeoutException without a retry. - variable/peekVariable infer List or Map from a List or Map default (Collections.emptyList(), List.of...) instead of the default's implementation class, so a JSON array or object is returned. - An events() stream first requested after the context or client closed is complete from the start. - The example declares slf4j-api and slf4j-simple (the project dependency resolves the plain core variant), and CI launches the installed example. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ible collection defaults Review-gate follow-ups to the timeout and collection-default fixes: - orTimeout completes on the JDK's shared delay thread, so the post-attempt step and the retry back-off now run on the callback executor; a blocking callback on a timed-out request no longer stalls retries. A timed-out exchange is cancelled; requestTimeout rejects values beyond a year (they overflow the millisecond deadline). - variable/peekVariable keep a constructible collection default's class (TreeMap, LinkedList) and convert into it; only non-constructible List/Map defaults (Collections.emptyList(), List.of...) infer the interface. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ric conversions Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ct float reads Review-gate follow-ups: - The request deadline now goes on a copy of the HTTP future, so cancelling the original reaches the exchange and stops the download (from JDK 16; JDK 11's client keeps reading, a JDK limit). - Non-constructible collection defaults convert into a class of the same shape: TreeMap for sorted maps, LinkedHashSet/TreeSet for sets, so emptySortedMap()/emptySet() defaults no longer throw or fall back. - Double/Float reads accept every exact conversion (2^60 as Double, 0.3f widened, 0.1 as Float) and reject NaN/infinity with the default, logged. - Tests: cancelled download, caller Content-Type not duplicated, retry completion on the callback executor. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ults; untyped Infinity Review-gate P3 follow-ups: - Double/Float lossless checks use the computed shortest decimal and digit counts instead of Double.toString / Float.toString, whose output changed in JDK 19 (and differs on Android), so every JDK agrees. - A collection default gets a substitute only when the substitute implements every interface of the default's class and extends its public superclass; an EnumSet default falls back to the default instead of failing the caller's cast. - Non-finite numbers fall back only for Double/Float/BigDecimal reads; Object/Number reads keep Infinity. - The back-off test records where the retry is submitted; the requestTimeout Javadoc states the JDK 11 limit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…es do not block substitutes Review-gate follow-ups to 1e124f5: - A Double/Float read is lossless when the result is the exact source value or its computed shortest decimal equals the source's, so 7-digit decimals (1234.567 as a Float) read as written on every JDK. - Collection substitutes skip marker interfaces with no methods (Kotlin's KMappedMarker), so Kotlin emptyList()/emptySet()/emptyMap() defaults convert again; the unused skeleton set is gone. - Tests: 7-digit decimals (and 1e23) as Float, marker-interface defaults, Infinity read as BigDecimal. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ty collection defaults convert Review-gate follow-ups to 897fd45: - Double/Float reads now follow Java's own conversion: the nearest value, rejecting only whole-number sources that are not exact (2^53 + 1, a large ID), overflow, NaN/Infinity and underflow to zero. The earlier digit-count heuristics rejected valid values at powers of two and differed by JDK; every finite float written as the JDK prints it now reads back as itself on JDK 11 and 25. - Collection substitutes also skip final classes in the superclass walk, so Kotlin's public final EmptyList and EmptySet defaults convert (tested against kotlin-stdlib, a test-only dependency). - The shortest-decimal helper handles powers of two; README and Javadoc state the numeric rules. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…g IDs read as Double must be exact Review-gate follow-ups to f3a2e59: - Skipping final classes broke defaults typed as a caller's own final collection (ClassCastException) and made ConcurrentHashMap.newKeySet() depend on the JDK; now only kotlin.collections.EmptyList/EmptySet/EmptyMap are exempt, and every other default without a compatible JDK substitute returns the default. - Tests: a Long 2^53 + 1 read as Double falls back; a public final collection default falls back; the shortest-decimal neighbour search at a power of two. - README and Javadoc say exactness applies to whole-number JSON values written without a decimal point. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Review-gate follow-ups to 4123503: - core-api.jar carries META-INF/proguard/absmartly-core-api.pro: keep the relocated Jackson, the internal JSON models and the attributes Jackson reads, keep the names of Kotlin's empty collections (typed variables match them by name), and silence the java.net.http transport Android never loads. Verified with R8 8.5.35: a minified app with no SDK rules crashed in ABsmartlyClient.build() and now runs; without -keepnames a Kotlin emptyList() default silently stayed empty. verifyShadedJar checks the file is in the jar. - MIGRATING tells Android users to drop the 1.x Jackson rules. - Tests: the final-collection fixture has no no-argument constructor, so it exercises the substitute check on every lane; a kotlin.UIntArray default is not treated as an empty collection. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
….create() Review-gate follow-ups to e3e8adc: - New r8-check module (part of check, so CI runs it): minifies a probe app with R8 8.5.35 using only the rules shipped in core-api.jar, then runs it alone. It decodes a payload with an unknown field, reads typed and class-mapped variables with list and Kotlin defaults, and builds a client on the default transport. Emptying the rules file or dropping -keepattributes, the JSON-model keep or the Kotlin -keepnames each fails it. - The rules keep JdkHttpTransport.create(), which a minified JVM app needs for the default transport; the error for a missing transport no longer blames Android only. - Docs: standalone ProGuard needs -include of the rules; apps keep the fields of their own variable classes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…onsumer rule is pinned Review-gate follow-ups to aa3ce2b: - r8-check minifies the probe a second time against only java.base and java.logging (jmod-extracted), as Android has no java.net.http, java.sql or java.beans; the probe now reads a generic List<Slot> field and a Kotlin emptySet() default. Removing any single line of the shipped rules fails the build. - Two -dontwarn lines that nothing needed are gone; the rules header says R8 applies them and ProGuard needs -include. - -PskipR8Check skips the probe offline (R8 comes from Google's Maven repository); CHANGELOG and CONTRIBUTING mention the rules and the probe. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…oid comments; R8 task inputs Review-gate P3s on 0abc49e: the probe needs only Signature and annotations, and each fails the build when removed; the comments name what Android lacks; extractAndroidLikeLibrary is keyed on java.home, and the Android minify passes its rules once. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Independent sdk-review on 1b62faf: APPROVE, 0 P1/P2/P3 open. This push answers jervasion-absmartly's four findings on edf3e1b. The commits since then went through 10 fresh reviewer passes (cf8a705 through 1b62faf), which found and fixed 12 more P2s: the timeout callback thread and cancellation, collection-default casts, Kotlin empty collections, JDK-dependent float reads, missing R8 consumer rules and their tests. Each pass's report is in .git/sdk-review/.md. Final reviewer report and evidence log (1b62faf)APPROVE at Compared:
The consumer rules and Re-reviewed Verified fixed:
Must fixNone. Tests needed (current implementation correct)12 full-build mutations: 10 killed, 2 survived. Both survivors are in the test harness itself, not in shipped rules. Neither is a finding:
Compatibility / parity / forward-compat evidence
PerformanceNot applicable: no runtime path changed. Real-android DEX size is 1,550,220 B at API 34, down from 1,567,292 B with the attribute pair. That is an observation, not a claim. P3 / notes
Version and release notes
Pre-existing on main (not this PR)
Verification limits / provenance:
sdk-review evidence: java-sdk#27
1. Trees
Version / X-Agent / CHANGELOG: unchanged by this commit ( 2. Backwards compatibility
3. Parity
4. Tests and mutation
Totals: 12 run / 10 killed / 2 survived. Both survivors are harness mutants, not findings.
Fix-commit audit:
5. Performance
6. Forward compatibility
7. Build / CI
8. Docs / CHANGELOG
Findings
Verification limits
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ace a stream close Review follow-ups (independent reviewers on d2f02dc): - JdkHttpTransport no longer lets the JDK client follow redirects: it would resend every header, the API key included, to any host a redirect names. The transport follows up to 5 redirects itself, only to the same scheme, host and port (301/302/303 as GET, 307/308 with method and body); a redirect elsewhere is returned as the 3xx response. 1.x's Apache client followed cross-host redirects; MIGRATING lists the change. - EventStream.submit drops an event whose stream closes between the isClosed check and offer() instead of throwing IllegalStateException into treatment()/track(). - Tests: same-origin redirect with headers, no request to another origin, 308 keeps method and body, redirect loops stop, origin comparison, and a deterministic close-in-the-gap stream test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jervasion-absmartly
left a comment
There was a problem hiding this comment.
❌ Changes requested
This follow-up fixes the four earlier defects, but the exact head is not ready to merge: the new R8 Gradle module fails the repository formatter, and four runtime failure/lifecycle paths remain reproducibly broken.
Next step: fix the five inline findings below and add focused regression coverage for the runtime cases.
Must fix
- R8 module fails Spotless — the exact-head build fails
:r8-check:spotlessGroovyGradleCheck; see the inline finding. - Typed numeric reads lose JSON precision — values that the new contract says to reject are returned as converted values.
- The documented async checkout can deadlock — a single-thread executor can block the worker needed to publish during try-with-resources close.
- Rejected retry scheduling leaves requests pending forever — a 503 retry can remain incomplete after the configured timeout.
- Event-stream scheduling failure changes a successful load to FAILED — stream delivery must not determine context-load outcome.
What I checked
- ✅ Exact-head Actions
test-jdk21passed. - ❌ Exact-head Actions
buildfailed; the check annotation identifies:r8-check:spotlessGroovyGradleCheck. - ✅ Local JDK 11 build/test path passed through the core, example and R8 probe when R8 was supplied from the published 8.5.35 archive; 1440 core test cases passed across the JDK 11/25 lanes.
- ✅ Installed example reaches
ContextLoadExceptionrather than a class-loading failure. ⚠️ Android/ART was not run; exact-head CI is already a material failure, so approval is withheld.
Review details
Head: 1b62fafe9cee039dfccba764726cb31467cb607d; base and merge-base: 07807b516df5ad0d7d92e5b682041982802cd871; review round 2; follow-up to review PRR_kwDOFfwdN88AAAABYp6VdA. The four earlier findings are resolved and their threads are outdated/resolved.
Convergence summary — review round 2
- Unresolved original blockers: 0
- Remediation regressions: 4
- Independent PR-change findings: 1
- Acceptance criteria still open: Spotless passes for the complete build; typed numeric reads preserve the source value until conversion; documented async checkout completes on a single-worker executor; rejected retry scheduling settles the request; stream delivery failure cannot fail a successful load.
- Human adjudication requested: no
Passes (non-blocking): run: core runtime/API/security/data, error handling and error messages (delegated specialist completed), tests/CI/packaging/end-to-end harnesses, deployment/operations/observability, cross-cutting simplicity, behaviour-bearing data/policy, comment hygiene, diff composition | not run: shared-component blast radius (no frontend source changed)
Comment hygiene (non-blocking): 573 comment / 5793 code lines, ratio ~1:10.1, 5 blocks flagged
core-api/src/main/java/com/absmartly/sdk/ContextState.java:3, narrates the removed 1.x API;core-api/src/main/java/com/absmartly/sdk/ReadyEvent.java:7-9, narrates the old event timing;core-api/src/test/java/com/absmartly/sdk/ABsmartlyClientTest.java:558,566,618, narrates compatibility/test sequencing;core-api/src/main/java/com/absmartly/sdk/EventStream.java:42, restates the test counter;core-api/src/main/java/com/absmartly/sdk/Context.java:225, narrates 1.x semantics.
threshold T=58; restatements counted: no (10 × C < E). These are below the measured promotion threshold and do not block.
Diff composition (non-blocking): every file is required for the change; none flagged. The introduced-content audit retained 256 writes across 256 unique blobs and found no credential or scratch artifact.
Simplifications (non-blocking): 5 candidates
Client.java:109-128: use lambdas/thenAcceptwithout changing the three async stages;EventDispatcher.java:50-58: return a lambda subscription;JdkHttpTransport.java:118-135: share timeout-exception construction;VariableConverter.java:203-229: specialize the private shortest-decimal helper;core-api/build.gradle:113-140: reuse oneZipFilescope.
Run a simplification pass locally before pushing: these candidates cost less to address now than as a further review round.
Validation commands included JAVA_HOME=... ./gradlew build :example:installDist -x spotlessCheck --continue, the same build with R8 8.5.35 supplied from its published archive, local spotlessCheck using the repository formatter, the installed example launcher, and focused Java 11 probes. The ordinary build could not resolve R8 from dl.google.com, so the published R8 archive was used for the equivalent R8 tasks; the formatter reproduced the remote failure exactly.
…implementation class Attributes are snapshotted into unmodifiable lists and maps, so the class check in ExprEvaluator.compare made eq and in fail against the ArrayList/LinkedHashMap literals parsed from the audience. Caught by cross-sdk-tests scenarios 101-104 and 111. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…content; test empty and nested cases Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jervasion-absmartly
left a comment
There was a problem hiding this comment.
✅ Approved
The post-approval changes are ready to merge. They correctly bound variant lookup to the prepared slots, preserve the negative-override behavior, resolve redirect targets only for redirect responses, and make the deadline regression test exercise the real hop timing.
Next step: None — ready to merge.
What I checked
- ✅ Exact-head Actions
buildandtest-jdk21passed onffad16ef87b4ed7d1d6aaf83b352f70d0bd0a528. - ✅ Focused local Java 11 validation passed: 109 tests across
JdkHttpTransportTestandABsmartlyClientTest. - ✅ The changed redirect cases passed, including non-redirect
Location, deadline-bounded draining, production cancellation timing, and expired-hop behavior. - ✅ The changed context cases passed, including negative overrides, cleared absent overrides, malformed/throwing variant configs, and stored-slot bounds.
⚠️ The full localchecktask could not load the repository formatter because the environment could not resolvedownload.eclipse.org; exact-head CI supplied the passing formatter/build evidence.
Review details
Reviewed head: ffad16ef87b4ed7d1d6aaf83b352f70d0bd0a528
Base: 07807b516df5ad0d7d92e5b682041982802cd871
Responsibility baseline: approved commit 2e86e8585a04ab5dc2d2fea40d651daf0c2c97b5
Review round: 7; post-approval follow-up.
Convergence summary — review round 7
- Unresolved original blockers: 0
- Remediation regressions: 0
- Independent PR-change findings: 0
- Acceptance criteria still open: none
- Human adjudication requested: no
Passes (non-blocking): run: core runtime/API/security/data; error handling and error messages (delegated specialist completed); tests/CI/packaging/end-to-end harnesses; deployment/operations/observability; cross-cutting simplicity; behaviour-bearing data/policy; comment hygiene; diff composition | not run: shared-component blast radius (no frontend source changed)
Comment hygiene (non-blocking): 7 comment / 75 code lines, ratio ~1:10.7, none flagged
threshold T=5; restatements counted: no (10 × C < E)
Diff composition (non-blocking): every file is required for the change; none flagged. The pinned introduced-content audit completed successfully and retained 10 content-write records; no credential, scratch artifact, build output, or other unnecessary file was identified.
Simplifications (non-blocking): none.
The adversarial runtime pass and the delegated error specialist found no candidate introduced between the approved commit and this head. Existing accepted behavior was not reopened.
…RATING with the two exceptions Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
New commits were added after this approval. Jervasion will reassess the updated head.
|
Final independent sdk-review on 6d52f41: APPROVE, 0 P1/P2/P3. Delta since ffad16e:
Results on cb0676d, the last code change:
Per the new owner policy, the cross-sdk-tests changes are listed in the PR body under "cross-sdk-tests changes needed". They are on branch Reviewer report and evidence log (cb0676d)APPROVE at Re-reviewed Must fixNone. Tests needed (current implementation correct)5 full-suite mutation runs (
Fix-commit audit (
Compatibility / parity / forward-compat evidenceDirect
* In 1.9.0 these inputs never arise from an ArrayList attribute, because 1.x stored the caller's object as-is. Under 1.x an ArrayList/LinkedHashMap attribute matched and every other List/Map implementation did not. At
PerformanceStatic only, no timing claimed. The new branch costs two P3 / notes
Version and release notesNo version change in this commit. The 2.0.0 section is unreleased. Released sections are untouched ( Pre-existing on main (not this PR)
Verification limits / provenance: Spotless could not resolve its formatters offline ( Evidence log: head
|
| attribute value vs literal | 1.9.0 eq/in | head eq/in |
|---|---|---|
ArrayList[1,2,3] vs [1,2,3] |
true/true | true/true |
Arrays.asList |
false/false | true/true |
List.of |
false/false | true/true |
unmodifiableList(ArrayList) |
false/false | true/true |
ArrayList subclass |
false/false | true/true |
LinkedList |
false/false | true/true |
empty ArrayList vs [] |
true/true | true/true |
List.of() vs [] |
false/false | true/true |
LinkedHashMap{a:1} vs {"a":1} |
true/true | true/true |
HashMap / Map.of / TreeMap |
false/false | true/true |
empty LinkedHashMap vs {} |
true/true | true/true |
ArrayList[List.of(1), Map.of(a,List.of(2))] vs [[1],{"a":[2]}] |
true/true | true/true |
ArrayList[1L] vs [1] |
false/false | false/false |
ArrayList[1.0] vs [1] |
false/false | false/false |
List.of(1L) vs [1] |
false/false | false/false |
empty list vs {} |
false/false | false/false |
Verdict on the claim: it is accurate for the top-level attribute value. In 1.9.0 a list matched only if its class was exactly ArrayList (a subclass also failed), and a map only if it was exactly LinkedHashMap. Every widened row is one the CHANGELOG describes, and nothing that matched in 1.9.0 stops matching at head. Two nuances are not stated; they are optional P3 wording (P3-a below):
- the class check applied only to the outer value, because nested containers used
equals(content). AList.ofnested inside anArrayListalready matched in 1.9.0; - the claim assumes the default audience deserializer. 1.9.0 exposed
ABSmartlyConfig.setAudienceDeserializer(README v1.9.0:170), and a custom deserializer that produced other classes would have changed which class "matched". That extension point is removed in 2.0 (MIGRATING.md:42), so this is moot for 2.0 users.
The rest of the bullet is also accurate:
- "audience or assignment-rule condition": both paths use
AudienceMatcher→JsonExpr→ExprEvaluator.compare; - "
eqorin":inover a list haystack callscompare(item, needle); - "as javascript-sdk does":
isEqualsDeep, per the cb0676d gate.
MIGRATING.md anchor
MIGRATING.md:5 links #units-attributes-overrides-custom-assignments. The heading is MIGRATING.md:165 ### Units, attributes, overrides, custom assignments. GitHub's slug (lower-case, drop punctuation, spaces → -) is exactly units-attributes-overrides-custom-assignments, and no other heading has the same slug. The "Custom objects as attribute or goal values" paragraph it points to is in that section (MIGRATING.md:184). It resolves correctly.
Tests needed (current implementation correct)
4 full-suite mutation runs (:core-api:test, JDK 11, 769 tests each), targeted at the new assertions. Result: 4 killed, 0 survived.
| Mutant | Result |
|---|---|
| M0: revert the cb0676d fix (cb0676d gate) | killed (2 failed) |
| MA: guard widened to cross-kind, and two empty containers of any kind compare 0 | killed: 1 failed, expected <null> but was <0> (the empty list vs empty map assertions) |
MB: element comparison by class (shallow content, getClass()== per element) |
killed: 1 failed, expected <0> but was <null> (the new nested-snapshot assertion; no other test caught it) |
| MC: Map arm dropped | killed: 2 failed (ABsmartlyClientTest.java:1060, ExprEvaluatorTest.java:288) |
Note: the MA failure comes from the new lines 291-292, or from the pre-existing ExprEvaluatorTest.java:281 (EMPTY_LIST vs EMPTY_MAP). The per-line attribution for MA and MB was not captured (the XML was overwritten by the next run). MB fails only because of a nested assertion, and the only nested unit assertion is the new one at 293-296.
Fix-commit audit (46a13fc):
- New state: none. Docs and tests only;
git show 46a13fc --stattouches nosrc/mainfile. cb0676dwas audited in its own gate. At head there is no new flag, cache or public name, andExprEvaluatoris ininternal.
Compatibility / parity / forward-compat evidence
- Public API: unchanged by the delta.
- Behaviour: see the probe table. Head widens matching towards JS only. Every 1.9.0 match is preserved, and the numeric-type mismatches are identical to 1.9.0.
- Cross-sdk: not re-run for
46a13fc, because there is no main-code change sincecb0676d. The cb0676d gate recordedorch-cb0676d.log: java 304 eligible / 1 skip of 305, 0 FAIL.
Performance
No main-code change in 46a13fc. For cb0676d see its gate: static only, with two instanceof checks on the non-scalar compare path.
P3 / notes
- P3-a (optional wording),
CHANGELOG.md:46-47. "In 1.x a list matched only if it was anArrayList, and a map only if it was aLinkedHashMap" is right for the attribute value itself. Please consider "only if the attribute value itself was exactly anArrayList… (nested lists and maps already compared by content)". That stops a reader from concluding that nestedList.ofvalues used to fail. - P3-b (optional wording),
MIGRATING.md:3. The first sentence still says 2.0 "does not change what the SDK decides or sends", and the next sentence lists two exceptions. Consider "barely changes" or "does not change …, except:". Cosmetic. - Numeric element types in containers: pre-existing in 1.9.0, documented, track separately (as before).
Version and release notes
The 2.0.0 section is still "(unreleased)". Released sections are untouched (the diff hunks are only at CHANGELOG.md:3-7 and :41-50). No version source changed.
Pre-existing on main (not this PR)
- The numeric-type-in-container JS-parity gap (1.9.0 and head both return false for
[1L]vs[1]; JS returns true).
Verification limits / provenance:
- Spotless is NOT RUN: the formatter cannot be resolved offline.
- Manual format check on the added Java lines: none is longer than 120 columns (tab = 4), there is no trailing whitespace and no space indentation.
- CI has not run on
46a13fc. The latest run is 44632929436 (success) onffad16e. Wait for CI (the Spotless step) on the pushed head before calling all gates green. - JS behaviour comes from the cb0676d gate's source reading, not from executed vectors.
Evidence log: head 46a13fce4617a8c2ec5569c1459adf8a575c6fb4
Scratch: mktemp -d → /tmp/tmp.3Wq60px6a9, with detached worktrees head and mut at 46a13fc. The probe dir was /tmp/tmp.zRUmDmsAyf. All were removed afterwards (git worktree remove --force ×2, rm -rf). git worktree list shows no scratch tree of this run, and the pre-existing ones were left as found. git status --short is empty and git rev-parse HEAD = 46a13fce… before and after.
Step 1: trees.
git rev-parse HEAD=46a13fce4617a8c2ec5569c1459adf8a575c6fb4.- Released:
core-api-1.9.0.jar(pom: jackson-databind 2.13.4.2, runtime). Tagv1.9.0. - Pushed head
ffad16e. Delta:git log ffad16e..HEADgives 2 commits.git diff ffad16e HEAD --stat: 5 files, +53/-2.
Step 2: compat.
- v1.9.0 source read:
ExprEvaluator.compare(class check),DefaultAudienceDeserializer(readerForMapOf(Object.class)),InOperator,EqualsOperator,Context.setAttribute(stored as-is). - Head
JsonValues.snapshotValueproduces unmodifiable LinkedHashMap/ArrayList copies. - Probe
com.absmartly.sdk.Probe:new AudienceMatcher(new DefaultAudienceDeserializer()).evaluate(...)witheqandin.- 1.9.0 run: compiled against the 1.9.0 jar + jackson 2.13.5 + slf4j-api 2.0.16 (an slf4j 1.7.36 copy from the Gradle
jars-9cache was instrumented and failed to load, so it was replaced). - Head run: against
core-api/build/libs/core-api.jar(shaded) + slf4j 2.0.16. - Results: the table above.
- 1.9.0 run: compiled against the 1.9.0 jar + jackson 2.13.5 + slf4j-api 2.0.16 (an slf4j 1.7.36 copy from the Gradle
- Public API: no
src/mainchange in46a13fc.
Step 3: parity. No new parity surface. JS isEqualsDeep analysis carried from the cb0676d gate (source-derived). Cross-sdk not re-run: no main-code change since cb0676d, whose log is orch-cb0676d.log (java 304/305 eligible, 0 FAIL).
Step 4: tests and mutants.
JAVA_HOME=/usr/lib/jvm/java-11-openjdk-arm64 GRADLE_USER_HOME=$HOME/.gradle ./gradlew build -x spotlessCheck -PskipR8Check --offline: BUILD SUCCESSFUL in 38s, exit 0.:core-api:test769 tests, 0 failures, 0 errors, 0 skipped (summed from the JUnit XML).jacocoTestCoverageVerification,animalsnifferMain,verifyShadedJar,:example:buildand:r8-check:buildpassed../gradlew :core-api:testJdk25 --offline: exit 0 (up to date; it already ran insidebuild). 769 tests, 0 failures, 0 errors.- Both new tests appear in both result sets (
anAudienceMatchesListAndMapAttributesByContent(),testCompareObjects()). - Mutants MA, MB and MC were applied in the
mutworktree with a Python/sed edit toExprEvaluator.java, then./gradlew :core-api:test --offline -q, then the file was restored. Results are in the table: all killed (1, 1 and 2 failures of 769).
Step 5: perf. NOT RUN: no main-code change in this delta.
Step 6: forward-compat. NOT RUN: no decoder change in this delta.
Step 7: build/CI.
- Build as in step 4.
- Spotless: NOT RUN (offline). Manual check:
git diff ffad16e HEAD -U0 -- '*.java' | grep '^+' | expand -t4 | awk 'length>120'gives no output;grep -P '^\+.*[ \t]+$'gives no output;grep -P '^\+ +'gives no output. gh run list --branch next/major: latest run 44632929436, success, onffad16e. There is no CI run yet on46a13fc.
Step 8: docs. The anchor and claim checks are above. CHANGELOG line references come from grep -n (:44 "This can change…", :49 "1L"). The MIGRATING intro is at :3-7 and the heading at :165 (grep -n '^#' MIGRATING.md). The added CHANGELOG/MIGRATING lines are all 120 columns or less (the awk length check flags only pre-existing lines 14 and 68+).
Reviewer report and evidence log (6d52f41)
APPROVE at 6d52f41: both wording P3s from the 46a13fc gate are closed, the change since that gate touches only docs, and both test lanes pass with 769/769 tests.
Re-reviewed 6d52f41 (4 commits since the pushed head ffad16e). cb0676d and 46a13fc were each gated APPROVE (.git/sdk-review/cb0676d….md, .git/sdk-review/46a13fc….md). This pass audits the two commits after them, 06b43e7 and 6d52f41. Baselines are unchanged from the 46a13fc gate: published core-api-1.9.0, tag v1.9.0, merge base 07807b5. Only this delta counts as a finding.
Must fix
None.
Verified fixed (P3s from the 46a13fc gate)
- P3-a, CHANGELOG wording: closed.
CHANGELOG.md:46-47now reads "In 1.x a list attribute matched only if the value itself was exactly anArrayList, and a map only if it was exactly aLinkedHashMap(lists and maps nested inside it already compared by content)."- This matches the 1.9.0 probe table in the 46a13fc gate: an
ArrayListsubclass failed, and anArrayListholdingList.of/Map.ofalready matched. - The rest of the bullet is unchanged in content. The word diff shows only "attribute", "the value itself", "exactly" ×2 and the parenthetical added; the rest is rewrapped.
- This matches the 1.9.0 probe table in the 46a13fc gate: an
- P3-b, MIGRATING intro: closed.
MIGRATING.md:3now opens "2.0 reshapes the API; apart from two exceptions, it does not change what the SDK decides or sends."MIGRATING.md:4-7then names both exceptions: custom objects, and list/map attributes in audience conditions. The meaning is unchanged; the sentence is only reordered.
Docs accuracy and links
- The claims are unchanged from the 46a13fc gate, where they were measured. The only new claim is the nested-content parenthetical, which is true per the gate's probe row
ArrayList[List.of(1), Map.of(a,List.of(2))](1.9.0 true/true). MIGRATING.md:4-5[Custom objects](#units-attributes-overrides-custom-assignments): the link text now spans a soft line break, which is valid CommonMark. The anchor resolves to the heading### Units, attributes, overrides, custom assignmentsatMIGRATING.md:165, and the target paragraph is at:184.[CHANGELOG](CHANGELOG.md),[MIGRATING.md](MIGRATING.md),[SUPPORT.md](SUPPORT.md)and[SWITCHBACK.md](SWITCHBACK.md)all exist at the repo root.- No added line is over 120 columns, and none has trailing whitespace.
Tests needed (current implementation correct)
0 mutations run in this pass: there is no code change since 46a13fc. That gate recorded 4 run, 4 killed, 0 survived.
Fix-commit audit (06b43e7, 6d52f41): they add no new state, flags, caches or public names. git diff --quiet 46a13fc HEAD -- ':!*.md' exits 0, so the only changes are to CHANGELOG.md and MIGRATING.md.
Compatibility / parity / forward-compat evidence
- Unchanged since
46a13fc(no source change). See that gate and the cb0676d gate (cross-sdk: java 304 eligible / 1 skip of 305, 0 FAIL).
Performance
No code change since 46a13fc.
P3 / notes
None new. Track the numeric types inside lists and maps (1L vs 1, a JS-parity gap) separately. It was already in 1.9.0 and is documented.
Version and release notes
The 2.0.0 section is still "(unreleased)". The hunks touch only CHANGELOG.md:44-50 inside 2.0.0, and no released section changed. The version source is unchanged.
Pre-existing on main (not this PR)
- The numeric-type-in-container JS-parity gap, as above.
Verification limits / provenance:
- Spotless: NOT RUN (formatter offline). The delta has no Java change, so the formatting risk is nil.
- CI has not run on
6d52f41. The latest run is 44632929436 (success) onffad16e. Confirm CI on the pushed head before calling every gate green.
Evidence log: head 6d52f41d4337244712392d6e83ad7d0875fa716f
Scratch: mktemp -d → /tmp/tmp.TlHPy6J46i, with a detached worktree head at 6d52f41. It was removed afterwards (git worktree remove --force, rm -rf). Before and after: git status --short is empty and git rev-parse HEAD = 6d52f41d….
Step 1: trees.
git rev-parse HEAD=6d52f41d4337244712392d6e83ad7d0875fa716f.git log ffad16e..HEAD: 4 commits (cb0676d, 46a13fc, 06b43e7, 6d52f41).git diff --stat ffad16e HEAD: 5 files, +55/-4.git diff --stat 46a13fc HEAD: CHANGELOG.md and MIGRATING.md only, +13/-13.- Release baselines: carried from the 46a13fc gate.
Step 2: compat. NOT RUN afresh: there is no source change since 46a13fc (git diff --quiet 46a13fc HEAD -- ':!*.md' exit 0). The 46a13fc gate's probe (1.9.0 jar vs head jar) still applies.
Step 3: parity. NOT RUN afresh, for the same reason. Cross-sdk evidence is the cb0676d gate's (orch-cb0676d.log: java 304/305 eligible, 0 FAIL).
Step 4: tests.
JAVA_HOME=/usr/lib/jvm/java-11-openjdk-arm64 GRADLE_USER_HOME=$HOME/.gradle ./gradlew build -x spotlessCheck -PskipR8Check --offline -q(in the worktree): exit 0../gradlew :core-api:testJdk25 --offline: exit 0, BUILD SUCCESSFUL (up to date; it ran insidebuild).- JUnit XML sums:
test769 tests / 0 failures / 0 errors / 0 skipped;testJdk25769 / 0 / 0 / 0. - Mutants: 0 run (docs-only delta). The 46a13fc gate recorded 4/4 killed.
Step 5: perf. NOT RUN: no code change.
Step 6: forward-compat. NOT RUN: no decoder change.
Step 7: build/CI.
- Build as in step 4.
- Spotless NOT RUN (offline).
gh run list --branch next/major -L 3: latest run 44632929436, success, onffad16e. There is no run on6d52f41yet.
Step 8: docs.
git diff 46a13fc HEADand--word-diff=porcelainwere reviewed. The word diff shows only the intended wording additions plus rewrapping.- Long lines:
git diff 46a13fc HEAD -U0 | grep '^+[^+]' | expand -t4 | awk 'length>121'gives no output. Trailing whitespace:grep -P '^\+.*[ \t]+$'gives no output. - Links:
ls CHANGELOG.md SUPPORT.md SWITCHBACK.md MIGRATING.mdshows all present.grep -n '^#' MIGRATING.mdshows:165### Units, attributes, overrides, custom assignments, whose slug equals the anchor.grep -n 'Custom objects as attribute'gives:184.
|
Jervasion's approval of ffad16e (review 5991802787: no findings, no suggestions, no simplifications) was dismissed by the push of 6d52f41, which overlapped it. The head moved for a behaviour fix that the local cross-sdk run caught:
The independent gate on 6d52f41 is posted above. CI is green, there are no unresolved threads, and Jervasion is re-requested on 6d52f41. |
jervasion-absmartly
left a comment
There was a problem hiding this comment.
✅ Approved with suggestions
List and map attributes now match equal targeting literals even after the SDK takes an immutable snapshot. The migration notes call out the resulting assignment change for running experiments. No merge blockers found.
Next step: None — ready to merge.
Suggestions (optional)
- Qualify the changelog’s
inexample: an earlier non-comparable candidate can still stop the search before an equal item. - One redundant test comment is noted below.
What I checked
- ✅ Exact-head CI:
buildandtest-jdk21passed, covering Java 11/21/25, formatting, packaging, and the installed example smoke test. - ✅ Java 11: 181 focused tests and four loopback HTTP integration cases passed. The two changed equality tests both failed when I reverted only the production comparison change.
- ✅ Reviewed the author’s companion-suite results: 304 eligible Java 2.x scenarios passed and 1,311 comparisons agreed. That run used
cb0676d; production source is unchanged from that commit to this head. I did not rerun that suite.
Review details
Head: 6d52f41d4337244712392d6e83ad7d0875fa716f. Base and merge-base: 07807b516df5ad0d7d92e5b682041982802cd871. Post-approval responsibility baseline: ffad16ef87b4ed7d1d6aaf83b352f70d0bd0a528.
Convergence summary — review round 8
- Unresolved original blockers: 0
- Remediation regressions: 0
- Independent PR-change findings: 0 blocking
- Acceptance criteria still open: none
- Human adjudication requested: no
The same evaluator handles audiences and assignment rules. The new branch uses Java collection equality only for same-kind operands; list order, nested numeric Java types, and scalar comparisons retain their existing semantics. Structural comparison is proportional to the compared contents, with no extra copy or allocation introduced by the comparator. The specialist checked strict/non-strict audience fallback, assignment-rule skips, and warnings.
Local commands used the Gradle wrapper under verified Java/Javac 11.0.33. :core-api:test --tests '*ExprEvaluatorTest' --tests '*ABsmartlyClientTest' --tests '*ContextAssignmentRulesTest' --tests '*AudienceMatcherTest' --tests '*EqualsOperatorTest' --tests '*InOperatorTest' and :core-api:test --tests '*LocalHttpServerIntegrationTest' passed. In the detached revert tree, :core-api:test --tests '*ExprEvaluatorTest.testCompareObjects' --tests '*ABsmartlyClientTest.anAudienceMatchesListAndMapAttributesByContent' failed both assertions as expected. git diff --check ffad16e..HEAD passed. Local :core-api:spotlessCheck could not resolve download.eclipse.org; the exact-head build job passed the gate.
Passes (non-blocking): run: core runtime/API/data (comparison and treatment selection), dedicated error handling/messages (completed; matcher fallback and rule skip), tests/CI/packaging (changed Java tests and unchanged build gates), cross-cutting simplicity, comment hygiene, diff composition | not run: deployment/operations/observability (no deployment, release workflow, or logging call changes), shared frontend (no frontend source), behaviour-bearing data/policy (no independently loaded config, policy, or fixture files; in-code test vectors covered by the test pass).
Comment hygiene (non-blocking): 3 comment / 34 code lines, ratio ~1:11.3, 1 block flagged.
threshold T=5; restatements counted: no (10 × C < E).
ExprEvaluatorTest.java:286— restates the comparisons asserted directly below it.
Diff composition (non-blocking): every file is required for the change; none flagged. The pinned helper enumerated 10 content writes across the four commits since approval, including intermediate versions; no scratch artifacts or credential-bearing content found.
Simplifications (non-blocking): none.
… a test; drop a restating test comment Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nt rule is skipped Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…st: more headroom for the download-cancel check Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Final independent sdk-review on bb86022: APPROVE, 0 P1/P2/P3. Delta since 6d52f41, which Jervasion approved in review 5992932170:
Results on bb86022:
Reviewer report and evidence log (c748329)APPROVE at Re-reviewed Must fixNone. Tests needed (current implementation correct)2 full-suite mutations: 2 killed, 0 survived.
Verification of the CHANGELOG claim (CHANGELOG.md:48-51)
P3 / notes
Pre-existing (not this delta)
Version and release notesThe edit is inside the unreleased 2.0.0 section, and released sections are untouched. The added lines are at most 121 columns with no trailing whitespace. Verification limits / provenance: Spotless NOT RUN (the formatter download is offline), so it needs CI on Evidence log (head c748329)
Reviewer report and evidence log (ae14e89)APPROVE at Re-reviewed Verified fixed
Accuracy of CHANGELOG.md:44-55 against the code
P3 / notes
Pre-existing (not this delta)
Version and release notesThe edit is inside the unreleased 2.0.0 "Changed" section. Released sections are untouched. The longest line in 44-55 is 119 columns, with no trailing whitespace. Verification limits / provenance: Spotless NOT RUN (the formatter download is offline), so it needs CI on Evidence log (head ae14e89)
Reviewer report and evidence log (bb86022)APPROVE at Re-reviewed Verified fixed
Accuracy of CHANGELOG.md:44-56 (line by line, at bb86022)
Tests (fix-commit audit)
P3 / notes
Pre-existing (not this delta)
Version and release notesThe edit is inside the unreleased 2.0.0 "Changed" section. Version and X-Agent are unchanged by this delta. Verification limits / provenance: Spotless NOT RUN (the formatter download is offline), so it needs CI on Evidence log (head bb86022)
|
New commits were added after this approval. Jervasion will reassess the updated head.
Takes main's #24 follow-ups (restating test comments removed). The 1.x Client agent Javadoc change does not apply: 2.x removed getAgent/getAgentName/getAgentVersion. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Final independent sdk-review on a92bfee: APPROVE, 0 P1/P2/P3. This head merges Resolution:
Results:
The gate on bb86022, the content just before the merge, is in the comment above. Reviewer report and evidence log (a92bfee)APPROVE at Re-reviewed Merge resolution
PR diff vs main
Parity with 1.x
Tests needed
P3 / notes
Pre-existing (not this delta)
Version and release notesVERSION 2.0.0, X-Agent Verification limits / provenance:
Evidence log (head a92bfee)
|
jervasion-absmartly
left a comment
There was a problem hiding this comment.
✅ Approved with suggestions
The changes since the earlier approval are ready to merge. The merge from main removes comments without changing SDK behavior. The new audience test distinguishes the two in candidate orders, and the download test still catches a missing cancellation.
Next step: None — ready to merge.
Suggestions (optional)
- In
CHANGELOG.md, say that atruecandidate matches whenever the search reaches it. A list of candidates containing onlytruealso matches; no non-boolean candidate is required. No operator change is needed.
What I checked
- ✅ Exact-head CI:
buildandtest-jdk21passed, covering the JDK 11/21/25 lanes, formatting, R8, and the installed example. - ✅ Local build and full core suites passed: 770 tests each on JDK 11 and JDK 25, with no failures or skips.
- ✅ Both changed tests failed under independent negative controls: continuing past an incomparable audience candidate and removing HTTP response cancellation.
- ✅ The merge preserves the 2.x Client API and test types. The only production-source edit since approval deletes a comment.
Review details
Head: a92bfee15de4bd6ab3195befe1ae6bd9491e826c. Base and merge-base: 9b2414bf40ee5b51b0f690d099b7c4e6ce7a5187. Post-approval baseline: 6d52f41d4337244712392d6e83ad7d0875fa716f. Compared the full post-approval delta, including bb86022..a92bfee and the incoming main changes. The 1.x Javadoc examples were attached to getters that 2.x removed, so dropping those examples does not lose an applicable contract. The delta changes docs and tests for the Java 2.0 SDK, not runtime behavior for Java or downstream Kotlin/Scala/Android consumers. No new rollout, cross-SDK repin, or publication requirement was introduced. The companion cross-SDK run and Android ART were not rerun for this delta.
Convergence summary — review round 9
- Unresolved original blockers: 0
- Remediation regressions: 0
- Independent PR-change findings: 0 blocking
- Acceptance criteria still open: none
- Human adjudication requested: no
Validation: JAVA_HOME="$JAVA_HOME_11" ./gradlew build -x spotlessCheck -PskipR8Check --console=plain passed; exact-head Actions covered the omitted Spotless and R8 gates. The exact-head CodeRabbit check was skipped and is not counted as passing validation. The local JUnit XML for test and testJdk25 each reports 770 tests, 0 failures, 0 errors, 0 skipped. In a detached scratch tree, JDK 25 :core-api:testJdk25 --tests '*ABsmartlyClientTest.anInSearchForAListAttributeStopsAtTheFirstDifferentCandidate' --tests '*JdkHttpTransportTest.timedOutDownloadIsCancelled' -x spotlessCheck --console=plain failed both unchanged tests as expected: null-safe comparison continued to the second candidate and served variant 1 instead of 0; removing only sent.cancel(true) left the loopback server writing past the eight-second test bound. JDK 11 intentionally asserts the timeout, not socket cancellation. git diff --check 6d52f41 HEAD passed; the whole-PR check still notes an unchanged blank line at EOF in example/build.gradle, already present at the approved commit.
Passes (non-blocking): run: core runtime/API/data (verified comment-only production delta and traced the audience and HTTP paths); dedicated error handling and error messages (specialist completed; traced audience mismatch, rule skip and timeout/cancellation); tests/CI/packaging (audience test, real HTTP cancellation and full build); cross-cutting simplicity; comment hygiene; diff composition | not run: deployment/operations/observability (no deployment, release or log-emission changes), shared frontend (no frontend source), separate behaviour-bearing data/policy pass (no loaded configuration, policy or fixture changes; inline test inputs covered by test pass).
Comment hygiene (non-blocking): 1 comment / 15 code lines, ratio ~1:15, none flagged.
threshold T=5; restatements counted: no (10 × C < E). The test comment explains the timing separation between cancellation and natural completion.
Diff composition (non-blocking): every file is required for the change; none flagged. The pinned introduced-content helper enumerated 381 writes (379 unique blobs) from merge-base to head, including intermediate versions and 10 writes in the post-approval delta excluding incoming main history; path and content scan found no credential or unrelated artifact.
Simplifications (non-blocking): none.
…n among only booleans Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Final independent sdk-review on 4044c72: APPROVE, 0 P1/P2/P3. Delta since a92bfee (Jervasion-approved in review 5994451478): one docs-only commit. It implements that review's optional suggestion: in CHANGELOG.md, a Checks:
Reviewer report and evidence log (4044c72)APPROVE at Re-reviewed Delta
Clause-by-clause verification (head source)
Probe table (attribute
|
| attr | candidates | 1.9.0 audience/rule | head audience/rule |
|---|---|---|---|
| List.of(1) | [true] | true / 1 | true / 1 |
| List.of(1) | [false] | false / 2 | false / 2 |
| List.of(1) | [false,true] | true / 1 | true / 1 |
| List.of(1) | [[1],true] | false / 2 | true / 1 |
| List.of(1) | [[2],true] | false / 2 | false / 2 |
| List.of(1) | [true,[2]] | true / 1 | true / 1 |
| List.of(1) | [false,[1]] | false / 2 | true / 1 |
| List.of(1) | [[1]] | false / 2 | true / 1 |
| List.of(1) | ["s",true] | false / 2 | false / 2 |
| List.of(1) | [5,true] | false / 2 | false / 2 |
| List.of(1) | [null,true] | false / 2 | false / 2 |
| List.of(1) | [false,false] | false / 2 | false / 2 |
| Map.of("a",1) | [true] | true / 1 | true / 1 |
| Map.of("a",1) | [false,true] | true / 1 | true / 1 |
| Map.of("a",1) | [{"a":1}] | false / 2 | true / 1 |
| Map.of("a",1) | [{"a":2},true] | false / 2 | false / 2 |
| Map.of("a",1) | [true,{"a":2}] | true / 1 | true / 1 |
| Map.of("a",1) | [false,{"a":1}] | false / 2 | true / 1 |
| Map.of("a",1) | [false] | false / 2 | false / 2 |
- Every row agrees with the new CHANGELOG text on both jars.
- The only release-to-head differences (bold) are equal-content list and map candidates. That is the documented "compares by content, whatever the attribute's class" change in the same paragraph.
- The boolean and stop-at-first-differing behaviour is identical to 1.9.0, as the text's "As in 1.x" says.
Tests needed
None. The delta is docs-only and adds no production code. The behaviour the text describes was already pinned by the test added in c748329/bb86022, and this commit does not change it. 0 mutations run, because there is no code delta.
P3 / notes
- None.
Version and release notes
The heading ## 2.0.0 (unreleased) is unchanged. build.gradle VERSION 2.0.0 is unchanged. The entry stays under Changed, which is the right section for an assignment-affecting change.
Pre-existing on main (not this PR)
- Carried from earlier gates: CHANGELOG
## 1.9.0 (unreleased)while 1.9.0 is on Maven Central (a release gate on main, not this PR).
Verification limits / provenance:
- Spotless: NOT RUN, because the formatter download is offline. It needs CI on this head; no run id exists yet because the head is not pushed.
- The 1.9.0 jar is the offline
~/.m2copy, the same as in earlier gates. - The probes call the package-private
evaluateRulesfrom a class in packagecom.absmartly.sdkon the class path. That is not a customer API, but it is the production rule path that Context uses.
Evidence log (head 4044c727ab7dec64a9add921dff0a9ac932b9f9b)
| Step | Command(s) | Tree | Result | Verdict |
|---|---|---|---|---|
| 0 head | git rev-parse HEAD |
repo | 4044c72 | matches the brief |
| 1 trees | Baselines carried from the a92bfee gate (1.9.0 jar sha256 90ef04a2…3321; merge base 9b2414b). git diff a92bfee 4044c72 --stat |
a92bfee→4044c72 | CHANGELOG.md only, +5/-5, 1 hunk | docs-only |
| 2 compat | NOT RUN afresh: no source change (only CHANGELOG.md). Behaviour probe in the table above, 1.9.0 jar vs head shadow jar, JDK 11 | 1.9.0, 4044c72 | 19 cases. The only differences are equal-content list/map rows, and they are documented | OK |
| 3 parity | Clause-by-clause read of InOperator.java:9-26, ExprEvaluator.java:61-71,130-162, AudienceMatcher.java:112-131,182-234. Direct JsonExpr probe | 4044c72 | [[2],true], ["s",true], [null,true] → NPE; [false,false] → false |
text accurate |
| 4 tests | JAVA_HOME=/usr/lib/jvm/java-11-openjdk-arm64 GRADLE_USER_HOME=$HOME/.gradle ./gradlew build -x spotlessCheck -PskipR8Check --offline in a fresh worktree of 4044c72. It ran :core-api:test and :core-api:testJdk25. Then ./gradlew :core-api:testJdk25 (up to date) |
worktree 4044c72 | BUILD SUCCESSFUL, exit 0. JUnit XML: test 770 tests / 0 fail / 0 err / 0 skip; testJdk25 770 / 0 / 0 / 0. Mutations: 0 (no code delta). Fix-commit audit: adds no state | pass |
| 5 perf | NOT RUN: no code change | n/a | n/a | n/a |
| 6 forward-compat | NOT RUN: no decoder change | n/a | n/a | n/a |
| 7 build/CI | Same build as step 4. Spotless NOT RUN (offline formatter); needs CI on this head | 4044c72 | jar built (core-api.jar) | pass except Spotless NOT RUN |
| 8 docs | git show 4044c72; read CHANGELOG.md:42-55 |
4044c72 | inside the unreleased 2.0.0 section; no released section touched; claims verified in step 3 | OK |
| cleanup | git worktree remove of the scratch worktree; git status --short |
repo | empty; HEAD 4044c72 | tree untouched |
|
Jervasion's optional suggestion from review 5994451478 is implemented in 4044c72. The CHANGELOG now says a The summary sentence now reads: a list attribute matches in |
New commits were added after this approval. Jervasion will reassess the updated head.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jervasion-absmartly
left a comment
There was a problem hiding this comment.
❌ CI failed
The changelog now correctly explains that a true candidate matches a list or map attribute whenever the in search reaches it. No code or test changed, and I found no issue with the edit. Approval is withheld because the exact-head test-jdk21 job failed in GitHub Actions, even though all 770 tests passed locally on JDK 21.
Next step: Rerun test-jdk21 on this commit. If it fails again, use the Actions log to identify the failing test or runner step before merging.
What I checked
- ✅ The only change since the earlier approval is one paragraph in
CHANGELOG.md. Twelve direct evaluator cases confirmed the documented list and map behavior, including boolean-only candidate lists. - ✅ The exact-head
buildjob passed, including the JDK 11/25 build and tests, formatting, R8, and the installed example. - ✅ The local JDK 21 suite passed: 770 tests, no failures or skips.
- ❌ Exact-head
test-jdk21failed at the test step with exit code 1. The available annotation did not identify a failing test, and I could not retrieve the hosted log. The cause is unverified.
Review details
Head: 4044c727ab7dec64a9add921dff0a9ac932b9f9b. Base and merge-base: 9b2414bf40ee5b51b0f690d099b7c4e6ce7a5187. Post-approval baseline: a92bfee15de4bd6ab3195befe1ae6bd9491e826c. The author addressed the earlier optional documentation suggestion. No SDK behavior, API, workflow, rollout, or downstream integration changed.
Convergence summary — review round 10
- Unresolved original blockers: 0
- Remediation regressions: 0
- Independent PR-change findings: 0
- Acceptance criteria still open: none for the change; exact-head hosted JDK 21 validation has not passed.
- Human adjudication requested: no
Validation: git diff --check a92bfee HEAD passed. A JDK 11 JShell probe against exact-head compiled classes exercised [true], [false,true], [false], and equal/differing candidates before and after booleans for list and map attributes. Source tracing confirmed that AudienceMatcher translates the comparison exception into an audience mismatch or skips the current assignment rule. JAVA_HOME="$JAVA_HOME_21" ./gradlew :core-api:test -PskipJdk25 --console=plain passed on OpenJDK 21.0.13.0.3; JUnit XML reports 770/0/0/0 tests/failures/errors/skips. Actions run 44757084082: build job 136359542404 passed; test-jdk21 job 136359541958 failed. Job log downloads were inaccessible from this environment and the run has no attached artifacts. A local pass does not establish what failed on the hosted runner.
Passes (non-blocking): run: documentation correctness (checked membership and the existing mismatch/rule-skip paths), test/CI diagnostics (exact-head job evidence and local JDK 21 test run), cross-cutting simplicity, comment hygiene, diff composition | not run: separate runtime/API/security/data or error specialist (only changelog prose changed; no executable or failure-handling change), deployment/operations/observability (no deployment, release instructions or emission changes), shared frontend (no frontend source), behaviour-bearing data/policy (no loaded configuration, policy or fixtures changed).
Comment hygiene (non-blocking): 0 comment / 0 code lines, ratio n/a, none flagged.
threshold T=5; restatements counted: yes (10 × C ≥ E; no source comments added).
Diff composition (non-blocking): every file is required for the change; none flagged. The pinned helper enumerated 382 content writes (380 unique blobs) from merge-base to head. The only write since approval is the changelog paragraph; the path and content audit found no unrelated artifact or credential.
Simplifications (non-blocking): none.
|
Final independent sdk-review on a30de65: APPROVE, 0 P1/P2/P3. Fixes the JDK 21 CI race identified in review 5995138194. Initial SubmissionPublisher subscription delivery now finishes inline before the test enables rejection; subsequent stream delivery must schedule a task and encounter rejection. SDK stages still use the cached pool. Full build: 770 tests each on JDK 11/25. Focused repetitions and two negative controls verified rejection coverage. Independent report and evidenceAPPROVE at Re-reviewed one commit since remote Must fixNone. P1: 0; P2: 0; P3: 0. Verified fixed
The test asserts READY, null failure, treatment 1 and zero subscribers after rejected delivery. Class-level 30-second SEPARATE_THREAD timeout bounds it; finally shuts down the pool. No observed deadlock or timeout. Two focused negative controls were killed on both JDK 11 and 25, establishing that neither rejection propagation nor bypassed rejection can silently pass. Tests needed (implementation correct)None identified. 2 focused controls / 2 killed / 0 survived, each on both runtimes. This is not the skill's standard 8–12 full-suite mutation campaign, explicitly excluded by the user's bounded request. Compatibility / parity / forward compatibilityNo production/API/build/dependency/wire/decoder delta from 4044c72. No new broad release-to-2.0 certification claimed. Downloaded published 1.9.0 sources and matched all 77 tracked tag Java files byte-for-byte; only extra artifact source is generated internal/SdkVersion.java. PerformanceNOT RUN: no production delta, no performance/allocation claim. Version and release notesVERSION 2.0.0 and docs/CHANGELOG unchanged. No customer-visible behaviour introduced by this test hardening. Broader 2.0 migration predates this commit and is not re-audited here. Pre-existing (not this delta)Broader 2.0 branch API/platform/packaging changes predate the test-only fix; they are not attributed to a30de65. This bounded review does not independently certify those changes. Verification limits / provenance: Requested full build passed on exact head; 770 tests each on JDK 11 and 25, no failures/errors/skips. Three additional invocations passed; one accidentally reran the full JDK 11 suite due Gradle option binding, recorded below. Target passed 4 times per runtime including full build. Spotless and R8 intentionally excluded by requested command. Exact-head CI has no runs; PR #27 remote still 4044c72. APPROVE is this local delta gate, not a claim all CI/release gates passed. No commits/pushes/GitHub comments. Source clean. Report destination blocker: Writing Evidence log
1. Trees
2. Backwards compatibility
3. Parity
4. Tests and mutationTree: exact a30de65. Full buildCommand exactly requested: Python ElementTree sums over JUnit TEST-*.xml:
Three additional invocationsAll use JAVA_HOME=/usr/lib/jvm/java-11-openjdk-arm64 GRADLE_USER_HOME=/home/agent/.gradle.
Negative controlsTar copy excluding .git/.gradle/build into scratch probe-tree, never reviewed source. Each command:
Controls Gradle exit 1, BUILD FAILED in 5s/4s respectively, no timeout. Logs mutant-propagate.log / mutant-no-rejection.log; XML mutant-propagate-results / mutant-no-rejection-results. Production scratch restored between controls. Totals 2 focused mutants / 2 killed / 0 survived, four runtime/control executions. Mutant copy and its tar removed after evidence captured. Standard 8–12 full-suite mutants NOT RUN: explicit bounded request; no rule/decoder production change. No survivor finding. Fix-commit audit: a30de65 adds only test executor control flow; no production flags/cache/API. Initial stream task finishes inline; AtomicBoolean saturation set only after subscribe returns and before newContext. Remaining SDK work still cached-pool-backed. No prior initial consumer remains to bypass rejected scheduling. Caller-thread assertions observe READY/failure/treatment/removed subscriber, no worker assertions swallowed. Class-level @timeout=30s SEPARATE_THREAD; pool finally shutdownNow. Verdict: race fixed, meaningful rejection/no observed deadlock. 5. PerformanceNOT RUN: timing/allocations, zero production delta. No ns/op claim or attribution of pre-existing costs. 6. Forward compatibilityNOT RUN: unknown/missing/null/reordered payload and malformed rules probes; zero decoder/model/rule delta. No broad fresh certification claimed. 7. Build / CI / packaging
8. Docs / CHANGELOG
Findings and cleanupP1=0; P2=0; P3=0. Verdict APPROVE for bounded delta. Report write to original .git/sdk-review destination was blocked by worktree isolation; this scratch report preserves all evidence for caller to place at authorized destination. No workaround around denied shared-checkout writes attempted. |
jervasion-absmartly
left a comment
There was a problem hiding this comment.
✅ Approved
The stream rejection test now finishes subscriber setup before turning on rejection, so its initial delivery task can no longer drain a later event without hitting the rejection path. No SDK runtime code changed, and the JDK 21 job that failed on the previous head now passes.
Next step: None — ready to merge.
What I checked
- ✅ Exact-head GitHub Actions:
buildandtest-jdk21passed, including formatting, packaging, the R8 probe, and the installed example smoke test. - ✅ All 770 core tests passed locally on each of JDK 11, 21, and 25. On JDK 21, the revised test failed when I made the SDK propagate the simulated rejection instead of handling it.
- ✅ The changelog now correctly describes a
truecandidate matching whenever theinsearch reaches it, including when all candidates are booleans.
Review details
Head: a30de6558456db4aebc6893936c0c93f4dddcdcb. Base and merge-base: 9b2414bf40ee5b51b0f690d099b7c4e6ce7a5187. Post-approval responsibility baseline: a92bfee15de4bd6ab3195befe1ae6bd9491e826c. This round covers the two intervening commits, including the test follow-up to round 10. The earlier job annotation exposed only an exit code; the subscription race is supported by the code and the author's analysis, not independently established as the historical job's cause.
The Java 2.0 migration targets Java 11+ and downstream Kotlin, Scala, and Android wrappers. This delta changes neither production behavior nor build configuration. The companion conformance results and merge/repin order are documented in the PR; Android ART and the companion suite were not rerun for this test-only runtime delta.
Convergence summary — review round 11
- Unresolved original blockers: 0
- Remediation regressions: 0
- Independent PR-change findings: 0
- Acceptance criteria still open: none
- Human adjudication requested: no
Validation: ./gradlew :core-api:test :core-api:testJdk25 --console=plain ran on JDK 11, and ./gradlew :core-api:test -PskipJdk25 --console=plain -q ran on JDK 21. Each lane ran 770 tests without failures or skips. ./gradlew build :example:installDist -x spotlessCheck -PskipR8Check --console=plain -q passed on JDK 11; the installed example reached the expected ContextLoadException against its placeholder endpoint, not a class-loading failure. Local full build setup could not resolve download.eclipse.org for Spotless; exact-head Actions job 136424544068 passed the full gate including Spotless and R8. Hosted JDK 21 job 136424544436 passed. CodeRabbit was skipped and is not counted as validation. git diff --check a92bfee HEAD passed.
Negative control: In a separate detached worktree I changed only EventStream.submit() to rethrow its caught RuntimeException, then ran JDK 21 :core-api:test -PskipJdk25 --tests '*ABsmartlyClientTest.rejectedStreamDeliveryDoesNotFailALoadedContext'. The unchanged test failed because context.failure() held RejectedExecutionException: saturated. The JDK can schedule rejection on READY or EXPOSURE depending on continuation timing; the test verifies lifecycle isolation and loss of the rejected subscriber, not the identity of the first event.
Passes (non-blocking): run: test/CI/packaging (changed executor setup and exact-head gates); dedicated error handling and messages (specialist completed; offer rejection, subscriber loss, and context lifecycle); documentation correctness (list/map membership and mismatch/rule skip); cross-cutting simplicity, comment hygiene, and diff composition | not run: separate core runtime/API/security/data (no production source change; existing behavior traced for the test and docs), deployment/operations/observability (no workflow, deployment or emitted-message change), shared frontend (no frontend source), behaviour-bearing data/policy (no loaded configuration or fixtures changed).
Comment hygiene (non-blocking): 2 comment / 7 code lines, ratio ~1:3.5, none flagged.
threshold T=5; restatements counted: yes (10 × C ≥ E). The two-line comment records why an already-running consumer can bypass the rejection the test is trying to induce.
Diff composition (non-blocking): every file is required for the change; none flagged. The pinned introduced-content helper found two post-approval writes (the test and changelog) and 383 writes / 381 unique blobs in the cumulative range. No credential-bearing content or unrelated artifact was identified.
Simplifications (non-blocking): none introduced in this delta.
java-sdk 2.0.0: idiomatic API
Status: owner decisions accepted 2026-11-17; implemented on
next/major.java-sdk is the reference implementation and the core that kotlin-sdk (an idiomatic Kotlin wrapper for any JVM,
servers and Android), android-sdk (built on kotlin-sdk) and scala-sdk wrap. 2.0 is where all breaking changes
live: the API is reshaped to read like modern Java (LaunchDarkly, Statsig, Optimizely and PostHog's Java SDKs are the
peers), while assignment, exposure, publish and refresh behaviour stays byte-for-byte the 1.x behaviour and the
cross-SDK contract (javascript-sdk is the contract reference; every cross-sdk-tests scenario must pass).
Owner decisions
All accepted by the owner on 2026-11-17.
com.absmartly.sdk:core-api, now at 2.x.core-api-java6is not continued in 2.x (1.x keeps it).com.absmartly.sdk. 1.x and 2.x cannot share a classpath (same artifact id), so a.v2package buys nothing.client.onEvent(...),context.onEvent(...), typed event classes) plus ajava.util.concurrent.Flow.Publisher<ContextEvent>(events()).com.absmartly.sdk.internal.shaded.jackson. It never conflicts with the user's Jackson and no Jackson type is in the public API....Async(CompletableFuture) pairs for context creation,publish,refreshandclose.ABsmartly(ABsmartlyClient); records-style accessors (units(), notgetUnits()).release/1.xwhen 2.0 merges and gets bug fixes for 12 months (seeSUPPORT.md). No compat shim:MIGRATING.mdonly.java.net.http.HttpClientis the default behind aTransportinterface, in a class Android never loads (see Platform).Goals and non-goals
events.
(
@NullMarkedpackages, explicit@Nullable), no checked exceptions, immutable value types,CompletableFuturefor I/O, synchronous thread-safe reads.
de-duplication, publish batching, retry and refresh are the 1.x engine, moved, not rewritten. The 1.x unit suite is
ported 1:1 (only call sites renamed) and the cross-sdk-tests suite runs against both lines.
API before and after
ABSmartly.create(ABSmartlyConfig.create().setClient(Client.create(ClientConfig.create().setEndpoint(e)...)))orABSmartly.builder()ABsmartlyClient.builder().endpoint(URI.create(e)).apiKey(k).application(a).environment(env).build()ABSmartlyConfig,ClientConfig,Client,DefaultHTTPClientConfig(mutable, setters)ABsmartlyClient.Builder(+JdkHttpTransport.Builderfor HTTP tuning)HTTPClient+ Apache HttpClient 5DefaultHTTPClientTransport+JdkHttpTransport(java.net.http): the 1.x retry policy (5 retries on 502/503, dropped connections and connect timeouts; no retry on a refused connection; same back-off) and redirects (followed, never https to http)ContextConfig.create().setUnit(...).setAttribute(...)(mutable)ContextOptions.builder().unit(...).attribute(...).build()(immutable)sdk.createContext(cfg).waitUntilReady()(a failed load still returns)client.context(options)returns a ready context or throwsContextLoadExceptionsdk.createContext(cfg).waitUntilReadyAsync()client.contextAsync(options)(CompletableFuture<Context>, fails withContextLoadException)sdk.createContext(cfg)client.newContext(options), thencontext.ready()/context.readyAsync()sdk.createContextWith(cfg, data)/sdk.getContextData()(Jackson model)client.context(options, data)/client.contextData()(opaqueContextDatawithtoJson()/fromJson())isReady() isFailed() isClosing() isClosed() isFinalizing() isFinalized()state()→ContextState { LOADING, READY, FAILED, CLOSING, CLOSED },failure()readyError()failure()(@Nullable Throwable)getTreatment(e)/peekTreatment(e)treatment(e)/peekTreatment(e)Object getVariableValue(k, Object def)<T> T variable(k, T def)(typed by the default),<T> T variable(k, Class<T>, T def)(maps JSON objects to your type), untypedvariableValue(k, def);peekVariable…twinsgetVariableKeys()variableKeys()String[] getExperiments()List<String> experiments()getCustomFieldKeys(),getCustomFieldValue(e, k),getCustomFieldValueType(e, k)customFieldKeys(),customFieldValue(e, k),customFieldType(e, k)setUnit,setUnits,getUnit,getUnits,getUnitValue(s)setUnit,setUnits,unit(t),units()setAttribute(s),getAttribute,getAttributessetAttribute(s),attribute(n),attributes()setOverride(s),getOverridesetOverride(s),override(e),overrides(),clearOverride(e)setCustomAssignment(s),getCustomAssignmentsetCustomAssignment(s),customAssignment(e),customAssignments(),clearCustomAssignment(e)track(goal, Map<String, Object>)track(goal),track(goal, Map<String, ?>)publish()/publishAsync(),refresh()/refreshAsync(),close()/closeAsync(),finalizeAsync()finalize*removed; blocking twins throw the unwrappedABsmartlyExceptioninstead ofCompletionExceptiongetPendingCount()pendingEventCount()getData()(Jackson model)data()(opaqueContextData)ContextEventLogger.handleEvent(Context, EventType, Object)EventListener.onEvent(ContextEvent);ReadyEvent,RefreshEvent,ExposureEvent,GoalEvent,PublishEvent,CloseEvent,ErrorEvent, each withtype()for a Java 11switch;events()→Flow.Publisher<ContextEvent>IllegalStateException,IllegalArgumentException, rawException(statusMessage)inCompletionExceptionABsmartlyExceptionroot:ContextNotReadyException,ContextClosedException,ContextLoadException,UnitAlreadySetException,HttpStatusException(statusCode),RequestTimeoutException,DecodingException. Bad arguments stayIllegalArgumentException.ContextDataProvider,ContextEventHandler,VariableParser,AudienceDeserializer,ContextDataDeserializer,ContextEventSerializerTransport(the one seam: tests, proxies, OkHttp on Android). The rest are internal.Example
Kotlin and Scala on top
@NullMarked(JSpecify);@Nullablemarks the few nullable results (unit(t),attribute(n),override(e),failure(),variableValue(k, def)). Kotlin seesString/String?, notplatform types.
@Nullableis preferred overOptionalbecause Kotlin maps it toT?for free.contextAsyncinto asuspend fun(await()),onEventinto acallbackFlow/SharedFlow,and
state()into aStateFlowupdated from theReadyEvent/ErrorEvent/CloseEventstream.CompletableFuturewithFutureConvertersandEventListeneras a function.ContextOptions,Exposure,Goal, the events) are final and immutable; their accessors arerecords-style so a later move to records (Java 16+) is source compatible.
Platform floor and why
java.net.http,FlowandCompletableFutureimprovements; Java 17 would exclude a measurable set of server usersfor no API gain we use (records/sealed are not allowed in the public API anyway, to keep Android desugaring simple).
android-api-level-24signature) still runs on the core sources;java.time(Duration,Instant) is ignored bythat check because core library desugaring provides it.
java.net.httpis not on Android at all, soJdkHttpTransportis compiled from a separate source set (src/jdk) that Animal Sniffer does not check and thatno core class references:
ABsmartlyClientloads it reflectively only when the caller did not supply aTransport. Android callers always supply one (kotlin-sdk ships anHttpURLConnection/OkHttp transport), so ARTnever loads the class.
Context.events()returnsFlow.Publisher(Android API 30+); its implementation lives inits own class that is loaded only when
events()is called, soonEventis the Android path below API 30.Dependencies
org.apache.httpcomponents.client5:httpclient5+httpclient5-fluent5.1.3HttpClient)jackson-databind2.13.4.2 +jackson-datatype-jsr310(unused)jackson-databind2.13.5 shaded and relocated into the jar (kept on 2.13 for the Android API 24 baseline; Jackson 2.14+ needs API 26). jsr310 dropped.jsr3053.0.2,findbugs-annotations3.0.1 (both dead)org.jspecify:jspecify1.0.0 (the only annotation dependency; tiny, no runtime code)slf4j-api1.7.30slf4j-api2.0.x (API-compatible for callers; bindings: any SLF4J 2 provider)streamsupport-minifuture(java6 artifact)core-api-java6The published POM lists only
slf4j-apiandjspecify. A build check fails if any unrelocatedcom/fasterxmlclass ends up in the jar.
JPMS: the jar carries
Automatic-Module-Name: com.absmartly.sdk.Behaviour parity
Contextengine (assignment cache, holdouts, switchbacks, exposure queue, publish/close state machine) is the1.x code with only public method names changed. The 1.x unit tests are ported with renamed call sites and keep the
same assertions (752 tests on 1.9.0+main); new tests cover the new surface (typed variables, state, events, errors,
transport).
ContextEventLoggersemantics map 1:1 onto events: the same event kinds, fired at the same points with the samedata. One deliberate difference: an exception thrown by a user
EventListeneris caught and logged instead ofpropagating into
treatment()/track(). The engine paths that tolerate a throwing logger are kept and stilltested through the internal seam.
PUT {endpoint}/context, same headers:X-API-Key,X-Application,X-Environment,X-Application-Version,X-Agent: absmartly-java-sdk/2.0.0, same JSON).JdkHttpTransport, and thecross-sdk-tests
javalane (2.0 wrapper) next to thejava-v1lane (1.x wrapper).Coexistence with 1.x
mainbecomes 2.x when this PR merges (tagsv2.*).release/1.xis cut by the owner from the last 1.x tag andgets bug fixes for 12 months (
SUPPORT.md). Fix flow: fix onmain, cherry-pick torelease/1.x.main.yml) runs on push and PR formainandrelease/**;publish.ymlpublishes onv*tags and failsif the tag does not equal
VERSION. The same workflow files must be added torelease/1.xonce it is cut (aseparate small PR).
v1.*tags are created with--latest=falseso a 1.x patch never becomes "latest".javalane is pinned tonext/major(thenmain), and a newjava-v1lane runs the 1.xwrapper against
release/1.x(until it exists: the last 1.x commit onmain).Migration
See
MIGRATING.mdfor the 1:1 table with before/after snippets. In short: replace the config objects with the twobuilders,
createContext(...).waitUntilReady()withclient.context(options),get*accessors with their nounforms, the
is*booleans withstate(), casts ofgetVariableValuewithvariable(key, default), andContextEventLoggerwithonEvent.This PR
V1/V2 coexistence checklist
.github/workflows/main.ymlruns on push and PR formainandrelease/**(JDK 11 floor build + JDK 25 tests, plus a JDK 21 lane)..github/workflows/publish.ymlpublishes onv*tags and keeps the tag ==VERSIONcheck. The same workflow files must be added torelease/1.xonce the owner cuts it: a separate small PR torelease/1.xwill follow.v1.*tag is created with--latest=false(inpublish.yml), so a 1.x patch never becomes "latest".release/1.x.cross-sdk-tests changes needed
Owner policy: all cross-sdk-tests changes land in one consolidated PR. The java changes are all committed and pushed on the companion branch
feat/java-sdk-v2-lanes, head16eaaef. Its PR, absmartly/cross-sdk-tests#27, stays open for the consolidation worker to supersede and is no longer updated.Pins
sdk-branches.sh:["java-sdk"]="next/major"until this PR merges, thenmain.["java-sdk-v1"]="v1.9.0": the last 1.x tag. Switch it torelease/1.xonce the owner cuts that branch.sdk-branches.sh: addSDK_REPO_SOURCES=(["java-sdk-v1"]="java-sdk"), a checkout directory cloned from a different repo.setup-sdks.shclones from${SDK_REPO_SOURCES[$repo]:-$repo}..github/workflows/cross-sdk.ymldoes the same and adds the lane{"sdk":"java-v1","repos":"java-sdk-v1"}.javawrapper (java-wrapper/), ported to the 2.x APIABsmartlyClient/ContextOptions/Contextand typed events (EventCollector), with aWrapperTransport(Transport) andSdkSupport. All self-tests are ported: assignment rules, holdouts, holdout arms, switchback.com.absmartly.sdk.WrapperNoEnvironmentcoversclientNoEnvironment(scenarios 253 and 302).ABsmartlyClient.builder()rejects a missing environment, so it builds the context through the SDK's package-private constructors, with no reflection.java-wrapper/Dockerfile:gradle:8.5-jdk17;:core-api:shadowJar, the published shaded jar;:core-api:test -PskipJdk25.build.gradle: only a comment changes (the wrapper needs the 2.x API, which no released core-api has).New
java-v1lane (java-v1-wrapper/)java-wrapper, kept unchanged against core-api 1.x.docker-compose.yml: adds thejava-v1-sdkandjava-v1-unitservices.docker-compose.local-sdk.yml: addsSDK_SOURCE_DIR: ${JAVA_SDK_V1_DIR:-java-sdk-v1}.run-tests.shandrun-e2e-tests.sh: addjava-v1-sdk/java-v1-unittoHEAVY_SDKS.orchestrator/test_runner.py: maps"java-v1": "java"(same SDK family).tests/test_harness.py: lane count 20 → 21, withjava-v1among the holders.Capabilities (
orchestrator/expected-capabilities.json)java: unchanged.java-v1:java's required set minusswitchback:diagnostics,publishFail,variableKeysMap,globalCustomFieldKeys,getUnits,getAttributes,readyError;holdouts,holdout_arms,diagnosticsUtf8,assignmentRules,semverOperators,numericUnitIds;publishThrowsOnFailure,trackRejectsNonObjectProperties,refreshNoOpOnFailedContext,clientNoEnvironment;xAgentHeader,clientRejectsBlankApplication,throwsOnMisuse,singleFinalizeEvent,semverNumericOperands.java-v1unsupported:clientAcceptsBlankApplication: the client rejects a blank application; scenario 322 covers it.switchback: v1.9.0 predates it. Require it again oncerelease/1.xis cut from main.Merge order:
java-sdklane fromnext/majortomainin the consolidated PR.release/1.xis cut, repinjava-v1to it, and require switchback again if it is cut from main.Local verification. I ran the cross-sdk suite at
16eaaefagainst this PR atcb0676d, the last commit that changes code (later commits are docs only), withjava-sdk-v1atv1.9.0. There are 305 scenarios. All SDKs agree across 1,311 comparisons.javaclientAcceptsBlankApplication, an agreed exceptionjava-v1clientAcceptsBlankApplicationThis run caught a 2.x regression, which cb0676d fixes. On ffad16e, scenarios 101-104 and 111 failed on
javaand passed onjava-v1: a list or map attribute did not match an equal audience value. No wrapper or capability change was needed for the fix.Not done here (owner/orchestrator)
Cutting
release/1.x, tags, publishing,absmartly/docs.🤖 Generated with Claude Code