Repository navigation
Conversation
15 tests failed with "'GpArray' object has no attribute 'is_singlenode'". gpstart reads gparray.is_singlenode, but only GpArray.initFromCatalog() sets it. The tests build a GpArray directly, so the attribute is missing. Set is_singlenode to False in GpArray.__init__(), so that every GpArray has it. test_prepare_segment_start_returns_up_and_down_segments expected the segments marked down to be skipped. In Cloudberry, Segment.__init__() sets valid to True for all segments (see the comment there), so gpstart tries to start them all. Change the test to expect that. Backpatch-through: REL_2_STABLE Assisted-by: Claude Code
tuhaihe
marked this pull request as draft
November 20, 2026 07:01
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
15 tests failed with "'GpArray' object has no attribute
'is_singlenode'". gpstart reads gparray.is_singlenode, but only
GpArray.initFromCatalog() sets it. The tests build a GpArray directly,
so the attribute is missing. Set is_singlenode to False in
GpArray.init(), so that every GpArray has it.
test_prepare_segment_start_returns_up_and_down_segments expected the
segments marked down to be skipped. In Cloudberry, Segment.init()
sets valid to True for all segments (see the comment there), so gpstart
tries to start them all. Change the test to expect that.
Type of Change
Test Plan
gppylib.test.unit.test_unit_gpstartpasses as gpadmin in a cbdb-build-rocky9 container with mock 5.0.0 and ademo cluster, run from
gpMgmt/binwith:This PR also changes
gppylib/gparray.py. Running all 60 gpMgmt unit test modules that pass on main shows no regressions.Checklist
Additional Context
No CI job runs this module today, which is why the failure was not seen.
I found it while adding the gpMgmt unit tests to the Behave workflow
(branch
ci-more-gpmgmt-unit-tests). After that change and this PRare merged,
gppylib.test.unit.test_unit_gpstartcan be added to theic-unit-gpmgmtlist.