Skip to content

Fix test_unit_gpstart for singlenode mode and segment state - #2372

Draft
tuhaihe wants to merge 1 commit into
apache:mainfrom
tuhaihe:fix-test-unit-gpstart
Draft

tuhaihe wants to merge 1 commit into
apache:mainfrom
tuhaihe:fix-test-unit-gpstart

Conversation

@tuhaihe

@tuhaihe tuhaihe commented Nov 20, 2026

Copy link
Copy Markdown
Member

What does this PR do?

15 tests failed with "'GpArray' object has no attribute
'is_singlenode'". gpstart reads gparray.is_singlenode, but only
GpArray.initFromCatalog() sets it. The tests build a GpArray directly,
so the attribute is missing. Set is_singlenode to False in
GpArray.init(), so that every GpArray has it.

test_prepare_segment_start_returns_up_and_down_segments expected the
segments marked down to be skipped. In Cloudberry, Segment.init()
sets valid to True for all segments (see the comment there), so gpstart
tries to start them all. Change the test to expect that.

Type of Change

  • Bug fix (non-breaking change)
  • New feature (non-breaking change)
  • Breaking change (fix or feature with breaking changes)
  • Documentation update

Test Plan

  • Unit tests added/updated

gppylib.test.unit.test_unit_gpstart passes as gpadmin in a cbdb-build-rocky9 container with mock 5.0.0 and a
demo cluster, run from gpMgmt/bin with:

PYTHONPATH=.:../sbin:$PYTHONPATH:ext:lib:gppylib python3 -m unittest -v gppylib.test.unit.test_unit_gpstart

This PR also changes gppylib/gparray.py. Running all 60 gpMgmt unit test modules that pass on main shows no regressions.

Checklist

Additional Context

No CI job runs this module today, which is why the failure was not seen.
I found it while adding the gpMgmt unit tests to the Behave workflow
(branch ci-more-gpmgmt-unit-tests). After that change and this PR
are merged, gppylib.test.unit.test_unit_gpstart can be added to the ic-unit-gpmgmt list.

15 tests failed with "'GpArray' object has no attribute
'is_singlenode'".  gpstart reads gparray.is_singlenode, but only
GpArray.initFromCatalog() sets it.  The tests build a GpArray directly,
so the attribute is missing.  Set is_singlenode to False in
GpArray.__init__(), so that every GpArray has it.

test_prepare_segment_start_returns_up_and_down_segments expected the
segments marked down to be skipped.  In Cloudberry, Segment.__init__()
sets valid to True for all segments (see the comment there), so gpstart
tries to start them all.  Change the test to expect that.

Backpatch-through: REL_2_STABLE
Assisted-by: Claude Code
@tuhaihe
tuhaihe marked this pull request as draft November 20, 2026 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant