Repository navigation
core: Process HTTP/1.x requests with a higher minor version like HTTP… - #820
Open
arturobernalg wants to merge 1 commit into
Open
arturobernalg wants to merge 1 commit into
arturobernalg wants to merge 1 commit into
Conversation
arturobernalg
force-pushed
the
fix/httpd-h1-higher-minor-version
branch
2 times, most recently
from
November 20, 2026 05:44
0386b99 to
eb61837
Compare
5 tasks done
…/1.1. h1_post_read_request() added the HTTP1_BODY_IN filter only for proto_num <= 1.1, so a request such as "GET / HTTP/1.2" held its worker until the request body timeout and was then answered 408. Use the major version, as RFC 9110 section 2.5 requires. A request line with another major version on an HTTP/1 connection, e.g. "GET / HTTP/2.0", stalled the same way. It is still an HTTP/1 message: process it as HTTP/1.1, as 2.4.x does and the http_strict tests expect, by setting r->proto_num to 1.1 so that keep-alive and the body follow HTTP/1.1 as well. r->protocol keeps the version the client sent. Requests on HTTP/2 and HTTP/3 connections are not affected. PR: 70361
arturobernalg
force-pushed
the
fix/httpd-h1-higher-minor-version
branch
from
November 20, 2026 06:51
eb61837 to
00de4f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…/1.1.
BZ: https://bz.apache.org/bugzilla/show_bug.cgi?id=70361
h1_post_read_request() added the HTTP1_BODY_IN filter only for proto_num <= 1.1, so a request such as "GET / HTTP/1.2" held its worker until the request body timeout and was then answered 408. Use the major version, as RFC 9110 section 2.5 requires.
A request line with another major version on an HTTP/1 connection, e.g. "GET / HTTP/2.0", stalled the same way. It is still an HTTP/1 message, so it is processed as HTTP/1.1 too, as 2.4.x does and as the http_strict tests (perl framework and pytest_suite) expect: r->proto_num is set to 1.1, so keep-alive and the body follow HTTP/1.1 as well, and r->protocol keeps the version the client sent. Requests on HTTP/2 and HTTP/3 connections are not affected.
(see
SECURITY.mdandhttps://www.apache.org/security/#reporting-a-vulnerability).
APLOGNO()tag;numbers are assigned by a committer at merge time (see
docs/log-message-tags/README).changes-entries/*.txtfile is included,following the template in
README.CHANGES(not needed otherwise).test/modules/xxxdirectory matching themodules/xxxmodule source,or
test/modules/corefor core server changes. On Unix, verify thesepass locally with e.g.
make check-pytest PYTEST_DIRS=test/modules/xxx.