Skip to content

fix: deserialize S3 events without eventTime - #669

Open
gibkim wants to merge 1 commit into
aws:mainfrom
gibkim:fix/s3-event-missing-event-time
Open

gibkim wants to merge 1 commit into
aws:mainfrom
gibkim:fix/s3-event-missing-event-time

Conversation

@gibkim

@gibkim gibkim commented Nov 21, 2026

Copy link
Copy Markdown

Issue #, if available: Fixes #349

Description of changes:

Preserve a missing or JSON-null eventTime as null when deserializing S3 records. Previously it became an empty string, failed timestamp parsing, and triggered the legacy-class fallback, producing a misleading ClassNotFoundException. Valid timestamps and rejection of malformed/empty timestamp strings are preserved.

Run the existing cross-module CI tests against the serialization version just built, using the pattern already present in release.yml. The tests module otherwise selects released 1.4.1 instead of the installed candidate. This keeps its public dependency defaults unchanged.

Target (OCI, Managed Runtime, both): Both (shared serialization library).

Testing:

  • New regression tests: 5 errors on the original source; all 9 pass with the fix, covering missing/null timestamps through string/stream input, valid offsets, malformed input, and mixed records.
  • Serialization clean install, including shaded-class relocation verification; tests module clean verify -Pdev against the candidate: 134 tests, 0 failures/errors/skips (Corretto 8, macOS, en_US).
  • Fixed-snapshot independent review: 9 regression tests and 42 additional boundary cases passed, including actual SDK v1 compatibility; original-source negative control and workflow command routing also verified.
  • Native RIC Docker/OS integration was not run locally.

AI-assisted implementation and tests using Codex/GPT-6.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Pass null for absent S3 event timestamps instead of parsing an empty
string and falling back to an unavailable legacy event class.

Cover missing/null, valid, malformed, and mixed-record inputs. Run the
cross-module CI suite against the serialization version just built,
following the existing release gate without changing dependency defaults.

Assisted-by: Codex/GPT-6

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

eventTime field is required for S3Event deserialization in V3+

2 participants