Repository navigation
Conversation
Pass null for absent S3 event timestamps instead of parsing an empty string and falling back to an unavailable legacy event class. Cover missing/null, valid, malformed, and mixed-record inputs. Run the cross-module CI suite against the serialization version just built, following the existing release gate without changing dependency defaults. Assisted-by: Codex/GPT-6
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: Fixes #349
Description of changes:
Preserve a missing or JSON-null
eventTimeas null when deserializing S3 records. Previously it became an empty string, failed timestamp parsing, and triggered the legacy-class fallback, producing a misleadingClassNotFoundException. Valid timestamps and rejection of malformed/empty timestamp strings are preserved.Run the existing cross-module CI tests against the serialization version just built, using the pattern already present in
release.yml. The tests module otherwise selects released 1.4.1 instead of the installed candidate. This keeps its public dependency defaults unchanged.Target (OCI, Managed Runtime, both): Both (shared serialization library).
Testing:
clean install, including shaded-class relocation verification; tests moduleclean verify -Pdevagainst the candidate: 134 tests, 0 failures/errors/skips (Corretto 8, macOS, en_US).AI-assisted implementation and tests using Codex/GPT-6.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.