Skip to content

feat(contracts): allow branded third-party snapshot producers - #4905

Merged
thymikee merged 1 commit into
callstack:mainfrom
bytemain:jony/vphone-snapshot-producer-open
Nov 22, 2026
Merged

thymikee merged 1 commit into
callstack:mainfrom
bytemain:jony/vphone-snapshot-producer-open

Conversation

@bytemain

@bytemain bytemain commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Keep the built-in snapshot producer registry closed while allowing an explicitly branded third-party producer identity through snapshot provenance and iOS provider acquisition. Unknown producers keep the existing conservative defaults; no runtime registry or vphone-specific code is added. This is the only core change needed by the out-of-tree provider in bytemain/agent-device-vphone#1.

Before / after

Before, IosProviderAcquisitionProducer admitted only known provider-derived registry rows, so a third-party iOS tree could not type-check. After, 'vphone-ios-tree' as ThirdPartySnapshotProducer is accepted, while source-measured known producers remain excluded and unknown facts return undefined.

Validation

Tested 37c32f3d29e5479ba5d4187c0defe8e87190b6d1:

  • Typecheck, build, format, lint, layering, Fallow, production exports, related tests and 45 focused tests: PASS.
  • Independent review: no findings.
  • Hosted Coverage, Repo Guards, Integration, Lint/Typecheck, body rules, and Android/iOS/macOS/Linux smoke checks at 37c32f3d: PASS. The final local full unit run still has Apple CI fetch, AWS region, and upload deadline failures, all reproduced on isolated base 721adbc69; the earlier Apple host case was transient and passes in isolation.
  • Public end-to-end provider transcript, including non-empty vphone-ios-tree: feat: add attach-only vphone provider bytemain/agent-device-vphone#1 (comment)

@bytemain
bytemain force-pushed the jony/vphone-snapshot-producer-open branch from cd095e9 to 37c32f3 Compare November 21, 2026 15:50
@bytemain
bytemain marked this pull request as ready for review November 21, 2026 15:54
@thymikee

Copy link
Copy Markdown
Member

Thanks for the clear change.

The code at 37c32f3 looks correct, but the required Smoke Tests (ios) lane is still running, so the device evidence is missing. It must finish green at this head before merge. No separate live device run is needed, because no known-producer behavior changed. CI is pending, and no conflicts are known.

The two cancelled Body rules runs came from the workflow's cancel-in-progress group after later pushes or edits. Body rules shows success on the latest runs, so it is unrelated to the diff. Not verified here: typecheck, tests and the layering scan at this head, and the out-of-tree provider PR and its transcript.

Not blocking, and you can take or leave these: the ThirdPartySnapshotProducer brand has no constructor or guard, so a cast of 'apple-runner' type-checks and gets the built-in's facts at runtime (a thirdPartySnapshotProducer(name) helper that rejects registry names would close this, or say in the type comment that the brand is advisory); ProducerOnChannel now accepts a third-party name on every channel while the comment above SnapshotProvenance still says a cross-channel pair does not compile, so either scope the third-party arm to xctest or update that comment; SnapshotProducer now aliases KnownSnapshotProducer, which leaves two names for the closed set beside SnapshotProducerIdentity; ADR 0038 could gain one sentence saying producers outside the registry are branded third-party identities that get no facts; and the new contracts test is mostly type-level, so adding vphone-ios-tree to the truncation table in snapshot.test.ts would cover the reader at snapshot.ts:318.

The next step is to wait for Smoke Tests (ios) to pass at 37c32f3.

@bytemain

Copy link
Copy Markdown
Contributor Author

passed

@thymikee

Copy link
Copy Markdown
Member

The missing evidence is in at 37c32f3: Smoke Tests (ios) passed on this head, along with Smoke Tests (macos) and the other smoke lanes. The cancelled Body rules runs were superseded, and Body rules passes on the latest run. Nothing else blocks this head.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Nov 22, 2026
@thymikee
thymikee merged commit a4a35ba into callstack:main Nov 22, 2026
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants