Repository navigation
feat(contracts): allow branded third-party snapshot producers - #4905
Conversation
cd095e9 to
37c32f3
Compare
|
Thanks for the clear change. The code at 37c32f3 looks correct, but the required Smoke Tests (ios) lane is still running, so the device evidence is missing. It must finish green at this head before merge. No separate live device run is needed, because no known-producer behavior changed. CI is pending, and no conflicts are known. The two cancelled Body rules runs came from the workflow's cancel-in-progress group after later pushes or edits. Body rules shows success on the latest runs, so it is unrelated to the diff. Not verified here: typecheck, tests and the layering scan at this head, and the out-of-tree provider PR and its transcript. Not blocking, and you can take or leave these: the The next step is to wait for Smoke Tests (ios) to pass at 37c32f3. |
|
passed |
|
The missing evidence is in at 37c32f3: Smoke Tests (ios) passed on this head, along with Smoke Tests (macos) and the other smoke lanes. The cancelled Body rules runs were superseded, and Body rules passes on the latest run. Nothing else blocks this head. |
Summary
Keep the built-in snapshot producer registry closed while allowing an explicitly branded third-party producer identity through snapshot provenance and iOS provider acquisition. Unknown producers keep the existing conservative defaults; no runtime registry or vphone-specific code is added. This is the only core change needed by the out-of-tree provider in bytemain/agent-device-vphone#1.
Before / after
Before,
IosProviderAcquisitionProduceradmitted only known provider-derived registry rows, so a third-party iOS tree could not type-check. After,'vphone-ios-tree' as ThirdPartySnapshotProduceris accepted, while source-measured known producers remain excluded and unknown facts returnundefined.Validation
Tested
37c32f3d29e5479ba5d4187c0defe8e87190b6d1:37c32f3d: PASS. The final local full unit run still has Apple CI fetch, AWS region, and upload deadline failures, all reproduced on isolated base721adbc69; the earlier Apple host case was transient and passes in isolation.vphone-ios-tree: feat: add attach-only vphone provider bytemain/agent-device-vphone#1 (comment)