Repository navigation
test(listen): move the listen telemetry scenario to the integration suite - #36
Open
cb-muthiahm wants to merge 1 commit into
Open
cb-muthiahm wants to merge 1 commit into
cb-muthiahm wants to merge 1 commit into
Conversation
…uite The scenario that checks spooled `listen_phase` events across failed attempts, drops and reconnects built a Commander program to install the telemetry hooks. Unit tests use no Commander, so it now lives in `src/tests/integration/listen-telemetry.test.ts` and runs the real `chargebee listen` through `runCli`, with the same fake WebSocket and stubbed flush. The unit file drops the imports and the CI-detection hook that only this scenario needed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review: 7
Please check the settings in the CodeRabbit UI or the
|
Contributor
Test coverage✅ Gate passed — all 79 files are at or above the 95% floor.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The listen telemetry scenario built its own Commander program to install the telemetry hooks. Unit tests take no Commander, so the scenario moves to the integration suite and now runs the real
chargebee listen. This follows up a review note on #35.src/tests/ ├── integration/ +│ └── listen-telemetry.test.ts # runCli(["listen", ...]) + installTelemetry, fake WebSocket, stubbed flush └── unit/lib/tunnel/ └── appsync.test.ts # - Commander-driven telemetry scenario # - its imports and the CI-detection hook only it neededThe scenario is unchanged:
error;established;error;reconnected×2;closed.Evidence
unit/lib/tunnel/appsync.test.tsvianew Command()andinstallTelemetry.integration/listen-telemetry.test.tspasses against fix(listen): report reconnects as reconnected and recover expired sessions #35'sappsync.ts. It fails againstadb8cc8's (main before fix(listen): report reconnects as reconnected and recover expired sessions #35) with the old phase sequence, so it still guards the behaviour.bun test: 1423 pass, 0 fail, the same count as fix(listen): report reconnects as reconnected and recover expired sessions #35, because the test moved and wasn't duplicated.bun run typecheck: clean.coverage:gate: functions 99.90%, lines 99.46%.Merge Danger
Door: two-way
Test-only, with no product code changed.
Blast Radius: tests
A
test:commit, so Release Please adds no changelog entry.🤖 Generated with Claude Code