Skip to content

test(listen): move the listen telemetry scenario to the integration suite - #36

Open
cb-muthiahm wants to merge 1 commit into
fix/cli-fixes-nov-18-2026from
test/listen-telemetry-integration
Open

cb-muthiahm wants to merge 1 commit into
fix/cli-fixes-nov-18-2026from
test/listen-telemetry-integration

Conversation

@cb-muthiahm

Copy link
Copy Markdown
Collaborator

Stacked on #35. Review and merge #35 first; this PR's diff is the single commit on top of it.

Summary

The listen telemetry scenario built its own Commander program to install the telemetry hooks. Unit tests take no Commander, so the scenario moves to the integration suite and now runs the real chargebee listen. This follows up a review note on #35.

 src/tests/
 ├── integration/
+│   └── listen-telemetry.test.ts   # runCli(["listen", ...]) + installTelemetry, fake WebSocket, stubbed flush
 └── unit/lib/tunnel/
     └── appsync.test.ts            # - Commander-driven telemetry scenario
                                    # - its imports and the CI-detection hook only it needed

The scenario is unchanged:

  • three failed attempts → one error;
  • first session → established;
  • a drop, then a failed attempt → error;
  • two recoveries → reconnected ×2;
  • Ctrl+C → closed.

Evidence

Merge Danger

Door: two-way

Test-only, with no product code changed.

Blast Radius: tests

A test: commit, so Release Please adds no changelog entry.

🤖 Generated with Claude Code

…uite

The scenario that checks spooled `listen_phase` events across failed
attempts, drops and reconnects built a Commander program to install the
telemetry hooks. Unit tests use no Commander, so it now lives in
`src/tests/integration/listen-telemetry.test.ts` and runs the real
`chargebee listen` through `runCli`, with the same fake WebSocket and
stubbed flush. The unit file drops the imports and the CI-detection
hook that only this scenario needed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 18, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review: 7

  • main
  • master
  • develop
  • dev
  • develop/.*
  • staging/.*
  • release/.*

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 977dc037-eda1-441a-819f-0825dee9fc2b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@github-actions

Copy link
Copy Markdown
Contributor

Test coverage

✅ Gate passed — all 79 files are at or above the 95% floor.

Status Metric Coverage Threshold
✅ Functions 99.90% 95%
✅ Lines 99.46% 95%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant