Repository navigation
Let gate sessions run ansible-playbook through uv run - #548
Open
shipmill-romamo[bot] wants to merge 1 commit into
Open
shipmill-romamo[bot] wants to merge 1 commit into
shipmill-romamo[bot] wants to merge 1 commit into
Conversation
CI runs `uv run ansible-playbook --syntax-check`; the uv run hook refused it, so implementers met the syntax check first in CI. Fixes #547 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
There was a problem hiding this comment.
Review of 0a2de4d: merge
- One file,
.github/shipmill.toml:[hooks] uv_rungains"ansible-playbook", and its comment names the syntax check (#547) - Matches CI:
.github/workflows/ci.yml:65runsuv run ansible-playbook --syntax-check - The file parses (
tomllib), and nothing outside the gate'suv runhook reads[hooks]. No release, lane, or autonomy key changes - Security: allows one more program under
uv runin gate sessions, one CI already runs on every PR; no secrets, no new write path
Contributor
Author
|
@romamo Decision needed: may gate sessions'
The gate also prints Reply here with a number or your own answer; shipmill takes this up on the tick after your reply. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #547
Plan
.github/shipmill.toml[hooks] uv_run; no test, since it is agent config CI does not readtomlliband readsuv_run = ['ansible-lint', 'ansible-playbook']; a gate session'suv run ansible-playbook --syntax-checkpasses the hook after mergeCI runs
uv run ansible-playbook --syntax-check(.github/workflows/ci.yml:65), but[hooks] uv_runallowed onlyansible-lint, so gate sessions could not run the syntax check before pushing. Addansible-playbookto the list, as #332 did foransible-lint.Change
.github/shipmill.toml:[hooks] uv_run = ["ansible-lint", "ansible-playbook"], comment updatedConfig only: no code, no user-facing contract, no changelog entry (as #332).
🤖 Generated with Claude Code