Skip to content

Let gate sessions run ansible-playbook through uv run - #548

Open
shipmill-romamo[bot] wants to merge 1 commit into
mainfrom
fix/547-uv-run-ansible-playbook
Open

shipmill-romamo[bot] wants to merge 1 commit into
mainfrom
fix/547-uv-run-ansible-playbook

Conversation

@shipmill-romamo

Copy link
Copy Markdown
Contributor

Fixes #547

Plan

  • Serves: quality bar
  • Files: .github/shipmill.toml
  • Order: one edit to [hooks] uv_run; no test, since it is agent config CI does not read
  • Proof: the file parses with tomllib and reads uv_run = ['ansible-lint', 'ansible-playbook']; a gate session's uv run ansible-playbook --syntax-check passes the hook after merge

CI runs uv run ansible-playbook --syntax-check (.github/workflows/ci.yml:65), but [hooks] uv_run allowed only ansible-lint, so gate sessions could not run the syntax check before pushing. Add ansible-playbook to the list, as #332 did for ansible-lint.

Change

  • .github/shipmill.toml: [hooks] uv_run = ["ansible-lint", "ansible-playbook"], comment updated

Config only: no code, no user-facing contract, no changelog entry (as #332).

🤖 Generated with Claude Code

CI runs `uv run ansible-playbook --syntax-check`; the uv run hook refused
it, so implementers met the syntax check first in CI.

Fixes #547

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@shipmill-romamo shipmill-romamo Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review of 0a2de4d: merge

  • One file, .github/shipmill.toml: [hooks] uv_run gains "ansible-playbook", and its comment names the syntax check (#547)
  • Matches CI: .github/workflows/ci.yml:65 runs uv run ansible-playbook --syntax-check
  • The file parses (tomllib), and nothing outside the gate's uv run hook reads [hooks]. No release, lane, or autonomy key changes
  • Security: allows one more program under uv run in gate sessions, one CI already runs on every PR; no secrets, no new write path

@shipmill-romamo

Copy link
Copy Markdown
Contributor Author

@romamo Decision needed: may gate sessions' uv run start ansible-playbook, as this PR adds to [hooks] uv_run in .github/shipmill.toml?
CI on 0a2de4d: 2 checks green

  1. Merge it (recommended): sessions run the same uv run ansible-playbook --syntax-check CI runs (.github/workflows/ci.yml:65) before pushing, so a syntax error no longer costs a ~25-minute CI round (Target the component's own servers in deploy, rollback and restart #242). The hook lets through one more program, one CI already runs on every PR
  2. Leave the hook as it is: no change to what gate sessions may start; implementers keep meeting the syntax check first in CI

The gate also prints base: red: converge / converge failed on main@92481fc. That is a stale failure: the failed job is in Release run 44391818494, and the newer runs 44391773941 and 44408318149 on the same commit ran converge green. That is the gate behaviour reported in #535; nothing on main needs fixing.

Reply here with a number or your own answer; shipmill takes this up on the tick after your reply.

@shipmill-romamo shipmill-romamo Bot added the needs-decision A shipmill session asked a question here; waits for a reply label Nov 19, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-decision A shipmill session asked a question here; waits for a reply

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow ansible-playbook in the uv run hook

0 participants