Skip to content

Pass converge with a notice on a tree without the converge harness - #549

Open
shipmill-romamo[bot] wants to merge 1 commit into
mainfrom
fix/516-converge-skip-without-harness
Open

shipmill-romamo[bot] wants to merge 1 commit into
mainfrom
fix/516-converge-skip-without-harness

Conversation

@shipmill-romamo

Copy link
Copy Markdown
Contributor

Part of #516

Repairs: https://github.com/cloudfall-dev/cloudfall/actions/runs/44391818494

Plan

  • Serves: quality bar
  • Files: .github/workflows/converge.yml, .github/workflows/release.yml (a comment), docs/decisions.md
  • Order: the harness check step, then the guard on every later step, then D-28 in the log
  • Proof: this PR's own converge run takes the present path and must converge as before; the absent path is the step's [ -d ... ] test, which run 44391818494 shows is what failed

Summary

The maintainer chose option 1 on #516: converge passes with a notice on a tree without the converge harness, and D-23 is limited to trees that carry it.

The 0.7.1 hotfix run (44391818494) converged the release commit on release/0.7 with main's converge.yml. That tree predates engine/tests/converge/project, the job's default working directory, so "Install dependencies" failed to start and no 0.7.1 was cut. The failed check is recorded against main's head (92481fc), so main reads red and the merge gate lands nothing (D-75).

  • A new first step, Check the tree carries the converge harness, runs from the repository root and sets present=true or present=false; when the project is missing it prints ::notice::no engine/tests/converge/project in this tree, so nothing is converged (D-28)
  • Every later step runs only when present == 'true'; the failure dump step keeps failure() and adds the same guard
  • A tree with the harness (main, every 0.8 candidate) converges exactly as before
  • D-28 records the rule and supersedes D-23; release.yml's comment names it

Decisions for you

  1. Zone security (.github/): this PR changes a CI workflow, so it waits for your review per the option you chose on Decide whether 0.7.x gets a patch release that refuses Python 3.15 #516. Once it merges, main's head is no longer red, and the hotfix lane can run again (lane=hotfix, hotfix-prs=532, hotfix-from=v0.7.0) to cut 0.7.1 with CI green and no Debian converge
  2. Supersede, not amend: D-23 is marked Superseded by: D-28, and D-28 restates that the wait for converge still holds for every tree that carries the harness. The alternative is editing D-23's rule in place, which the log's format doesn't do

🤖 Generated with Claude Code

The 0.7.1 hotfix run converged its release commit on release/0.7 with
main's converge.yml, and that tree has no engine/tests/converge/project,
so every step failed to start and main@92481fc reads red. converge.yml
now checks for the fixture project first and, when it is missing, passes
with a notice and runs nothing. D-28 records the rule and supersedes D-23.

Part of #516

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@shipmill-romamo

Copy link
Copy Markdown
Contributor Author

@romamo Decision needed: may this CI change to .github/workflows/converge.yml land? It is option 1 you chose on #516: converge passes with a notice on a tree without engine/tests/converge/project and runs nothing; D-28 supersedes D-23.

Why it matters now: main's head (92481fc) reads red from the failed 0.7.1 hotfix converge (run 44391818494), so nothing lands on main. Waiting on it: #546 (the RabbitMQ profiles spec, answered and green), #525, #526, #517 to #523, #428, #504, #464. This PR's Repairs: line lets it land on the red base, and once it merges, main is green again.

  1. Merge it once CI is green (recommended): every later step is guarded by the new check, so a tree with the harness converges exactly as before; this PR's own converge run proves that path
  2. Change it: reply with what you want instead, and nothing merges until then

Reply here with a number or your own answer; shipmill takes this up on the tick after your reply.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-decision A shipmill session asked a question here; waits for a reply

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants