Repository navigation
Pass converge with a notice on a tree without the converge harness - #549
Open
shipmill-romamo[bot] wants to merge 1 commit into
Open
shipmill-romamo[bot] wants to merge 1 commit into
shipmill-romamo[bot] wants to merge 1 commit into
Conversation
The 0.7.1 hotfix run converged its release commit on release/0.7 with main's converge.yml, and that tree has no engine/tests/converge/project, so every step failed to start and main@92481fc reads red. converge.yml now checks for the fixture project first and, when it is missing, passes with a notice and runs nothing. D-28 records the rule and supersedes D-23. Part of #516 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
@romamo Decision needed: may this CI change to Why it matters now: main's head (92481fc) reads red from the failed 0.7.1 hotfix converge (run 44391818494), so nothing lands on main. Waiting on it: #546 (the RabbitMQ profiles spec, answered and green), #525, #526, #517 to #523, #428, #504, #464. This PR's
Reply here with a number or your own answer; shipmill takes this up on the tick after your reply. |
This was referenced Nov 19, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #516
Repairs: https://github.com/cloudfall-dev/cloudfall/actions/runs/44391818494
Plan
.github/workflows/converge.yml,.github/workflows/release.yml(a comment),docs/decisions.mdconvergerun takes the present path and must converge as before; the absent path is the step's[ -d ... ]test, which run 44391818494 shows is what failedSummary
The maintainer chose option 1 on #516: converge passes with a notice on a tree without the converge harness, and D-23 is limited to trees that carry it.
The 0.7.1 hotfix run (44391818494) converged the release commit on
release/0.7with main'sconverge.yml. That tree predatesengine/tests/converge/project, the job's default working directory, so "Install dependencies" failed to start and no 0.7.1 was cut. The failed check is recorded against main's head (92481fc), so main reads red and the merge gate lands nothing (D-75).Check the tree carries the converge harness, runs from the repository root and setspresent=trueorpresent=false; when the project is missing it prints::notice::no engine/tests/converge/project in this tree, so nothing is converged (D-28)present == 'true'; the failure dump step keepsfailure()and adds the same guardDecisions for you
security(.github/): this PR changes a CI workflow, so it waits for your review per the option you chose on Decide whether 0.7.x gets a patch release that refuses Python 3.15 #516. Once it merges, main's head is no longer red, and the hotfix lane can run again (lane=hotfix,hotfix-prs=532,hotfix-from=v0.7.0) to cut 0.7.1 with CI green and no Debian convergeSuperseded by: D-28, and D-28 restates that the wait for converge still holds for every tree that carries the harness. The alternative is editing D-23's rule in place, which the log's format doesn't do🤖 Generated with Claude Code