Repository navigation
Render HTTP/2 on managed nginx vhosts only when cloudfall_nginx_site_http2 is on - #553
shipmill-romamo[bot] wants to merge 1 commit into
Conversation
…http2 is on NGINX2Root (CVE-2026-123007) is an RCE in nginx's HTTP/2 flow control (1.9.5 to 1.31.8, fixed in 1.31.9), and distribution packages with the fix are not out yet. The cloudfall_nginx_site template always enabled HTTP/2, so a hand edit removing it was undone by the next domains run. The role now takes cloudfall_nginx_site_http2, default false. When it is true the TLS server block spells HTTP/2 as before, by the installed nginx version; `| bool` accepts the string from a key=value extra var. The routes test renders with it on, so its golden files stay byte-identical to the old output. Fixes #551 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Refused: this PR duplicates #552 and departs from the decision recorded on #551. #551 was decided at notify (#551 (comment)): #552 implements the decided design (default What would change this: a |
Fixes #551
NGINX2Root (CVE-2026-123007) is an RCE in nginx's HTTP/2 flow control (nginx 1.9.5 to 1.31.8, fixed in 1.31.9). Until fixed packages are installed, the mitigation is to stop serving HTTP/2, but
cloudfall_nginx_sitealways rendered it, so a hand edit was undone by the nextdomainsrun.Plan
http2; a key=valuetrue/falsestring is honoured; the version tests render with the switch on); then the role default and the template branch; then the routes test renders with the switch on so its golden files still match; then the changelog fragment[decisions]in .github/shipmill.toml) the fragment is under### Changed;test_http2_is_off_by_defaultfails on main (the template rendersssl http2;/http2 on;) and passes here; the routes golden files are unchanged and still byte-identical; ruff, mypy,cloudfall config validate --project config/examples, ansible-lint with CI'sANSIBLE_CONFIG, and the full pytest suite (2768 passed, 1 skipped) pass locallySummary
cloudfall_nginx_site_http2, defaultfalselisten 443 ssl;andlisten [::]:443 ssl;with nohttp2listen ... ssl http2;before nginx 1.25.1 andhttp2 on;from it;| boolaccepts the string from--extra-vars cloudfall_nginx_site_http2=true🤖 Generated with Claude Code