Repository navigation
Move workflows to Node 24 actions - #28
Merged
Merged
Conversation
The publish run for 0.4.3 warned that actions/checkout@v4 and the Docker image actions still target the deprecated Node.js 20 runtime and were forced onto Node.js 24. Use the current majors, which run on Node.js 24: actions/checkout v7, docker/setup-qemu-action v4, docker/setup-buildx-action v4, docker/login-action v4, and docker/build-push-action v7. None of their breaking changes apply here. checkout v6 keeps persisted credentials in a separate file, which git push in the runner update workflow still uses. checkout v7 only blocks fork checkouts under pull_request_target and workflow_run, which these workflows do not use. The Docker actions dropped inputs and variables these workflows never set. The README smoke workflow and the compatibility suite run on runnerctl runners, whose Actions runner 2.338.2 meets the 2.327.1 minimum, so they move to checkout v7 too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The 0.4.3 publish run warned that
actions/checkout@v4and the Docker image actions target the deprecated Node.js 20 runtime and were forced onto Node.js 24.Change
actions/checkoutdocker/setup-qemu-actiondocker/setup-buildx-actiondocker/login-actiondocker/build-push-actionAll of them run on
node24. The README smoke workflow andtests/workflows/compatibility.ymlmove to checkout v7 too; they run on runnerctl runners, whose Actions runner 2.338.2 meets the 2.327.1 minimum.None of the breaking changes apply:
git pushinrunner-update.ymlstill uses them.pull_request_targetandworkflow_run, which these workflows do not use.DOCKER_BUILD_NO_SUMMARY,DOCKER_BUILD_EXPORT_RETENTION_DAYS) that these workflows never set.The
ubuntu-latestmove to Ubuntu 26 needs no change here.Verification
ci.ymlwith checkout v7 on Linux, macOS and Windows.publish.ymlandrunner-image.yml(they push an image and a crate),runner-update.yml(it opens a PR), and the compatibility suite. The next release or runner update is their first run with these versions.🤖 Generated with Claude Code