Repository navigation
Show progress while pulling the runner image - #33
Merged
Merged
Conversation
Send docker pull output to stderr instead of discarding it, so the result JSON stays alone on stdout. Docker draws its progress bars when stderr is a terminal and prints per-layer lines otherwise. Add --quiet to hide the progress. Closes #32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #32
Problem
runnerctl image pulldiscardeddocker pullstdout, so nothing was printed until the pull finished (up to the 600 s timeout).Change
Pulling <image>...and forwarddocker pullstdout to runnerctl's stderr. stdout still carries only the result JSON.-q/--quietto hide the progress.Verification
cargo fmt --check,cargo clippy --all-targets --locked -- -D warnings,cargo test --lockedrunnerctl image pull --image ghcr.io/clroot/runnerctl-runner:v0.4.3 > out.json 2> pull.log→out.jsonhas only the JSON,pull.loghas the per-layer logrunnerctl image pull 2>/dev/null | jq .returns the same JSON as before--quiet: no stderr output, same JSON