Repository navigation
chore: update login to mention OATs - #7532
Conversation
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
@miparnisari bro you need to sign the DCO |
80961e0 to
0f2f4ab
Compare
thaJeztah
left a comment
There was a problem hiding this comment.
thanks! (sorry for the delay); I left a comment, and will open a PR in our docs to update the redirect.
Still slightly looking if we can somehow keep the information shorter for the flag descriptions, because it becomes a bit difficult to navigate with all the different combinations, but no good suggestions (yet)
docker login --help
Usage: docker login [OPTIONS] [SERVER]
Authenticate to a registry.
Defaults to Docker Hub if no server is specified.
Options:
-p, --password string Password, Personal Access Token (PAT), or Organization Access Token (OAT), or "-" to read from stdin
--password-stdin Take the Password, Personal Access Token (PAT), or Organization Access Token (OAT) from stdin
-u, --username string Username, or organization name when using an Organization Access Token (OAT)| out.PrintNote("A Personal Access Token (PAT) or Organization Access Token (OAT) can be used instead.\n" + | ||
| "To create a PAT, visit " + aec.Underline.Apply("https://app.docker.com/settings") + "\n" + | ||
| "To create an OAT, visit " + aec.Underline.Apply("https://app.docker.com") + " and select your organization, then Identity & auth > Access tokens.\n" + | ||
| "When using an OAT, use your organization name as the username.\n\n") |
There was a problem hiding this comment.
Looks like we have https://docs.docker.com/security/access-tokens/ in our documentation now, which contains information for both PAT and OAT.
I think we can update the /go/ redirect to that page, then all instructions are available, which means we can use a permalink (the /go/ redirect), and make sure the information is always up-to-date if it changes.
It currently points to PAT, so we can update that; https://github.com/docker/docs/blob/4089da36f9f99a51a8afd6c69b211fdd7db18b5f/data/redirects.yml#L18-L19
"/security/access-tokens/personal-access-tokens/":
- /go/access-tokens/
|
|
@miparnisari I played a bit with alternatives, and opened a PR against your branch; Also opened the combined changes as a draft PR; Let me know what you think! If you merge miparnisari#1, my changes should show up here as well, but it's good to squash them then with your commit (we generally try to avoid "fix up" commits to keep a cleaner history). Also more than happy to carry your changes. |
85cb5b9 to
fa8e375
Compare
Signed-off-by: Maria Ines Parnisari <maria.parnisari@docker.com>
fa8e375 to
ac057b7
Compare
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM (thanks for fixing the DCO)
Summary
Update
docker loginto mention OATs.Release notes (optional)
A picture of a cute animal (not mandatory but encouraged)