Repository navigation
Conversation
The e2e tsconfig still mapped $env/dynamic/private (to a file that no longer exists) while the app reads $app/env/private, so global setup failed before any spec ran. Add a stand-in that reads process.env after global setup assigns the throwaway configuration. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- InMemoryEventLog subscribed to the bus: recent events plus a shared ack (who and when), retention via GITOPS_EVENTS_EXPIRATION (default 7d), capped at 10,000 events - /org/<org>/events: events the viewer may read (each definition's readPermission, checked in the event's project or organization), filters by module and status, ack action - request context store is process-wide so the long-lived bus sees the actor after Vite HMR - sidebar entry, es/en translations, unit tests and an e2e spec Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…n:events - /org/<org>/settings/events, listed under organization settings in the sidebar - new organization:events permission: read to open the page, update to acknowledge - default Organization Admin role gets organization:events:all; existing roles are not migrated, the permission shows up in the role editor to enable it - e2e: page in the organization settings permission matrix Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parte de #76 · Base: #87 (
feature/78-alertas-eventos-access)Qué incluye
/org/<org>/settings/events: entrada "Eventos" en el sidebar, dentro de los ajustes de la organización.organization:events:readpara abrir la página yupdatepara marcar como revisado (el botón se oculta si no se tiene). El rol por defecto Organization Admin recibeorganization:events:all. No se migran los roles existentes: el permiso aparece en el editor de roles para activarlo.organization:events:*, cada evento solo se muestra, y solo se puede marcar como revisado, si el usuario tiene elreadPermissionde su definición, comprobado en el proyecto (permisosproject:*) o en la organización (organization:*).InMemoryEventLog(eventLogen#lib/server/events): está suscrito a'*'en el bus.GITOPS_EVENTS_EXPIRATION(documentada en.env.example): admite30d,12h,45m, o un número sin unidad en segundos. Por defecto7d. Un valor inválido usa el valor por defecto y deja un aviso en el log.CLAUDE.mdactualizados.Bug corregido (encontrado por el e2e)
En dev, Vite vuelve a evaluar
request-context.tsy crea unAsyncLocalStoragenuevo, pero el bus deglobalThisseguía leyendo el anterior. Por eso todos los eventos salían con actorsystem. Ahora el almacén también es único por proceso, y hay un test de regresión.Arreglo aparte (commit propio)
La suite e2e no arrancaba en
development:e2e/tsconfig.jsonmapeaba$env/dynamic/private, pero el código usa$app/env/private. Añadoe2e/env-private.tsy el mapeo correspondiente. Con eso la suite completa pasa.Tests
GITOPS_EVENTS_EXPIRATION.org-events.spec.ts: CI completa un análisis con una API key → el org admin lo ve atribuido a la API key → lo marca como revisado → aparece en "Revisados". Un usuario de otra organización y un org developer, que no tieneorganization:events:read, no pueden entrar. La ruta también está en la matriz deorganization-settings.spec.ts.bun run check✅bun run test✅ (451)bun run test:e2e✅ (55)🤖 Generated with Claude Code