Repository navigation
Avoid breaking line comments on non-breaking spaces. - #1530
Merged
Merged
Conversation
`JavaCommentsHelper.wrapLineComments` previously wrapped line comments on `CharMatcher.whitespace()` (which matches U+00A0 NO-BREAK SPACE) while `LINE_COMMENT_MISSING_SPACE_PREFIX` matched ASCII `\s` (which does not match U+00A0). Wrapping a comment at `\u00a0` produced a continuation line starting with `//\u00a0`, and subsequent passes inserted a space (`// \u00a0`) and wrapped at `idx = 3`, inserting a new empty `//` line on every run. Break line comments only on `CharMatcher.breakingWhitespace()`, enable `Pattern.UNICODE_CHARACTER_CLASS` on `LINE_COMMENT_MISSING_SPACE_PREFIX`, and use `CharMatcher.whitespace().trimFrom(...)` in `indentLineComments`. Fixes #562 PiperOrigin-RevId: 1024644076
copybara-service
Bot
force-pushed
the
test_1010281496
branch
from
November 18, 2026 15:13
3314e20 to
63b5d18
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid breaking line comments on non-breaking spaces.
JavaCommentsHelper.wrapLineCommentspreviously wrapped line comments onCharMatcher.whitespace()(which matches U+00A0 NO-BREAK SPACE) whileLINE_COMMENT_MISSING_SPACE_PREFIXmatched ASCII\s(which does not match U+00A0). Wrapping a comment at\u00a0produced a continuation line starting with//\u00a0, and subsequent passes inserted a space (// \u00a0) and wrapped atidx = 3, inserting a new empty//line on every run.Break line comments only on
CharMatcher.breakingWhitespace(), enablePattern.UNICODE_CHARACTER_CLASSonLINE_COMMENT_MISSING_SPACE_PREFIX, and useCharMatcher.whitespace().trimFrom(...)inindentLineComments.Fixes #562