Skip to content

fix(code): include inline comments in list pr_comment - #528

Draft
BlueLabelscotch wants to merge 1 commit into
mainfrom
fix/pr-comment-include-inline
Draft

BlueLabelscotch wants to merge 1 commit into
mainfrom
fix/pr-comment-include-inline

Conversation

@BlueLabelscotch

Copy link
Copy Markdown
Collaborator

Fixes #297

list pr_comment sent kind=comment, which excludes inline diff comments and their thread replies (kind=change-comment). It now sends both kinds, so inline review comments, including AI Code Review's, show up. System activity stays excluded.

The API only accepts repeated keys (kind=a&kind=b), and query_params can't express that today, so the query is written in the spec path. This relies on the client keeping the path's existing query string. Proper array support is tracked in #527.

Tested on harness-core/125148: 1 -> 9 comments; --limit 3 returns 3; a PR with only plain comments is unchanged.

@augmentcode augmentcode Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deep Code Review Agent🐛

Review completed with 0 suggestions.

Reviewed commit: cc5e2f3

@BlueLabelscotch
BlueLabelscotch marked this pull request as draft November 20, 2026 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Comments not showing up with pr_comment, but are showing up with pr:conversation

1 participant