Repository navigation
Preserve case-sensitive local Wally dependency paths - #92
Merged
Merged
Conversation
Apply lowercase validation only to registry references while retaining string validation in every dependency realm. Cover mixed local and registry dependencies without rewriting the manifest.
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the change preserving case-sensitive local dependency paths.
No open issues 🎉
What changed in this PR
Updates the Wally format checker to preserve case-sensitive local dependency paths while retaining lowercase requirements for registry references.
Changes:
- Exempts caret-prefixed local paths from lowercase validation.
- Keeps string-type validation for shared, server, and development dependencies.
- Adds regression coverage for mixed-case local paths, uppercase registry rejection, and invalid dependency types.
| File | Description |
|---|---|
| Tests/CheckWallyFormatTest.spec.luau | Adds local-path, registry-case, and dependency-type regression tests. |
| Scripts/CheckWallyFormat.exec.luau | Preserves local path casing and clarifies the checker’s documentation. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recognize caret-prefixed Wally dependencies as case-sensitive local filesystem paths rather than registry references. Registry package names and references still require lowercase, and dependency values must remain strings in shared, server, and development sections. The checker does not rewrite manifests or require paths to exist.
Regression tests cover preserved mixed-case paths, uppercase registry rejection alongside local dependencies, and dependency type validation. The complete suite passes all 419 tests, with formatting, static analysis, and
git diff --checkalso passing.