Skip to content

Preserve case-sensitive local Wally dependency paths - #92

Merged
horsenuggets merged 1 commit into
mainfrom
bugfix/local-wally-path-validation
Nov 18, 2026
Merged

horsenuggets merged 1 commit into
mainfrom
bugfix/local-wally-path-validation

Conversation

@horsenuggets

Copy link
Copy Markdown
Owner

Recognize caret-prefixed Wally dependencies as case-sensitive local filesystem paths rather than registry references. Registry package names and references still require lowercase, and dependency values must remain strings in shared, server, and development sections. The checker does not rewrite manifests or require paths to exist.

Regression tests cover preserved mixed-case paths, uppercase registry rejection alongside local dependencies, and dependency type validation. The complete suite passes all 419 tests, with formatting, static analysis, and git diff --check also passing.

Apply lowercase validation only to registry references while retaining string validation in every dependency realm. Cover mixed local and registry dependencies without rewriting the manifest.
@horsenuggets horsenuggets self-assigned this Nov 18, 2026
Copilot AI balanced review requested due to automatic review settings November 18, 2026 07:40

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the change preserving case-sensitive local dependency paths.

No open issues 🎉

What changed in this PR

Updates the Wally format checker to preserve case-sensitive local dependency paths while retaining lowercase requirements for registry references.

Changes:

  • Exempts caret-prefixed local paths from lowercase validation.
  • Keeps string-type validation for shared, server, and development dependencies.
  • Adds regression coverage for mixed-case local paths, uppercase registry rejection, and invalid dependency types.
File Description
Tests/​CheckWallyFormatTest.spec.luau Adds local-path, registry-case, and dependency-type regression tests.
Scripts/​CheckWallyFormat.exec.luau Preserves local path casing and clarifies the checker’s documentation.

Review effort: Balanced

@horsenuggets
horsenuggets merged commit 0c021cc into main Nov 18, 2026
13 checks passed
@horsenuggets
horsenuggets deleted the bugfix/local-wally-path-validation branch November 18, 2026 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants