Repository navigation
test(claude-messages): cover tools in the handler-owned settings test - #276
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jeffdupont
marked this pull request as ready for review
November 4, 2026 19:55
tonytrinh3
approved these changes
Nov 19, 2026
…into jdupont/aic-3737-owned-tools-test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The claude-messages handler takes
model, the messages, the system prompt andtoolsfrom the config, never frommodel.parameters. The existing test (test_config_cannot_override_model_or_messages) covered every one excepttools. This PR addstools:search), andmodel.parameterssets a differenttoolslist.toolsholds onlysearch, and that the parameters' tool appears nowhere in the call arguments.No handler code changes.
Tests
uv run ruff check .,uv run ruff format --check .: pass.uv run pytest packages/claude-messages: 171 passed.🤖 Generated with Claude Code
Note
Overview
Extends
test_config_cannot_override_model_or_messagessotoolsis covered alongsidemodel,messages, andsystem: config defines asearchtool (with a stub handler),model.parameterssupplies a differenttoolslist, and the test checks the Anthropic call uses onlysearchand nevernot-the-real-tool.No handler changes—this is test coverage only, locking in that tool definitions are handler-owned from config, not overridable via
model.parameters.Reviewed by Cursor Bugbot for commit 1304568. Bugbot is set up for automated code reviews on this repo. Configure here.