Repository navigation
fix(browser): keep the keys in the palette opened over a focused page - #1196
Merged
Merged
Conversation
The browser pane took the focus back on every frame it was focused, so the palette and the pane traded it each frame. Each trade reset the selection Gio types over, and every letter landed at offset 0. The pane now asks terminalTakesKeys first, as the terminal panes do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With a browser pane focused, opening the command palette (Ctrl+K) and typing piled every letter at the start of the field ("abc" came out as "cba").
browserInputtook the focus back for the page on every frame the pane was focused, with no check for anything open over it. The palette refocuses its field each frame it lacks it, so the two traded focus every frame. EachFocusCmdresets the router's editor state, so the selection Gio's window types over (EditorInsert) stayed at 0.The pane now asks
terminalTakesKeysbefore taking the focus back, the same gate the terminal panes use (stage_layout.go). That also covers the worktree dialog, comment editing and the sidebar, dock and git panel fields over a page.Test plan
TestAnOpenPaletteKeepsTheKeysFromAFocusedPanetypes "abc" into the palette over a focused pane the way Gio'sEditorInsertdoes; it fails on main (the text goes to the page) and passes here.TestTheClosingNoteKeepsTheKeysOfAFocusedPane: only its window fixture changed, sincebrowserInputnow reads the panelsterminalTakesKeysasks.native/:gofmt -l .,go vet ./...,go fix -diff ./...,go test ./...clean.