Repository navigation
ci: publish to NuGet with trusted publishing - #62
Merged
Merged
Conversation
Replaces long-lived API keys with nuget.org trusted publishing: the manually dispatched publish workflow exchanges the job's GitHub OIDC token for a short-lived key via NuGet/login. Runs only from main and in the "nuget" environment so approvals can gate releases. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Publishes to nuget.org with trusted publishing instead of a long-lived API key.
.github/workflows/publish.yml, run manually (Actions → Publish to NuGet → Run workflow) and only frommain.ModernUO.Serialization.Annotations,ModernUO.Serialization.GeneratorandModernUOSchemaGenerator, thenNuGet/login@v1exchanges the job's GitHub OIDC token for a one-hour API key and pushes with--skip-duplicate.nugetenvironment, which the nuget.org policy is scoped to; add required reviewers there to gate releases.NUGET_USERorganization secret.build.yml, which pushed with theNUGET_API_KEYsecret. Delete that secret and revoke the key after the first trusted publish.Configuration (done)
ModernUO, repomodernuo/SerializationGenerator, workflowpublish.yml, environmentnuget, scoped to this repo's packages.NUGET_USERorganization secret.Release steps
Bump
PackageVersionin the csproj, merge, run the workflow. A version already on nuget.org is skipped without failing the run.Test plan
dotnet packof each listed project locally; package contents checked