Repository navigation
CI: Set minimal permissions for GITHUB_TOKEN - #562
Merged
Merged
Conversation
joverlee521
approved these changes
Nov 18, 2026
joverlee521
left a comment
Contributor
There was a problem hiding this comment.
CI failure due to unrelated issue outside of this PR.
Self-documenting and safe.
victorlin
force-pushed
the
victorlin/update-workflow-permissions
branch
from
November 19, 2026 01:23
331c283 to
ddac06a
Compare
victorlin
commented
Nov 19, 2026
Comment on lines
+16
to
+17
| Jobs which use this action should provide to GITHUB_TOKEN the `contents: read` | ||
| permission for higher GitHub API rate limits. |
Member
Author
There was a problem hiding this comment.
Added 0fd713b and moved the contents: read to job-specific permissions blocks in force-push.
Contributor
There was a problem hiding this comment.
I didn't think contents: read need to be job specific because it's part of the default permissions?
Member
Author
There was a problem hiding this comment.
Not necessary, but my general approach in https://github.com/nextstrain/private/issues/262 has been to explicitly set permissions wherever the token is used as a self-documenting measure and guard against future changes to defaults.
joverlee521
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self-documenting and safe.
Checklist