Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1236 +/- ##
==========================================
+ Coverage 94.13% 94.18% +0.04%
==========================================
Files 291 291
Lines 28900 29255 +355
Branches 2932 2976 +44
==========================================
+ Hits 27206 27553 +347
- Misses 1672 1680 +8
Partials 22 22 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
4 tasks done
Contributor
|
🚀 Deploying Preview to Cloudflare 🚀Preview Deployments by commit
|
ovflowd
marked this pull request as ready for review
November 3, 2026 20:39
avivkeller
reviewed
Nov 4, 2026
ovflowd
force-pushed
the
perf/drop-positions
branch
from
November 4, 2026 18:23
b65c0b7 to
b88b1d5
Compare
Member
Author
|
Went with the nit, one walk per entry now :) |
ovflowd
force-pushed
the
perf/drop-positions
branch
from
November 6, 2026 19:30
b88b1d5 to
357bf41
Compare
Nothing after `metadata` reads where a node came from in the source: the type warnings that print positions run while it parses. Dropping them shrinks every entry the main thread holds and copies to and from the workers. On Node.js's docs that is ~480k position objects, about 80MB, and builds are ~5% faster. `json-simple`, which writes the metadata as it is, no longer has them either, and is about a third of its size. Assisted-by: Claude Opus 5.5 <noreply@anthropic.com> Assisted-by: Claude Sonnet 5.5 <noreply@anthropic.com>
An entry's heading and stability are nodes of its content, so walking the content alone covers them, without a loop over the three of them and a check for a missing one. The test now checks the heading and the stability too. Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>
ovflowd
force-pushed
the
perf/drop-positions
branch
from
November 6, 2026 19:43
357bf41 to
db7ba56
Compare
This was referenced Nov 9, 2026
The test and the comment say position rather than where a node came from, and the comment says which reader of it already ran. The test no longer checks how many children the entry's content has, which isn't about positions. Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR drops
positionfrom every node ofmetadata's entries once they're parsed. Nothing aftermetadatareads it (the type warnings that print positions run while it parses), and on Node.js's docs it's ~480k objects, about 80MB, that the main thread holds and copies to and from the workers.json-simplewrites the metadata as is, so it loses them too, at about a third of its size.Validation
Added
drops position from every node of an entry, which checks that no node of a parsed entry's content has aposition.json-simpleis the only target whose output changes.Related Issues
Split out of #1205.
Check List
node --run testand all tests passed.node --run format:check&node --run lint.