Skip to content

fix: follow up the full-source review: wrapping, labels, crowded routes, WSL fallback - #77

Merged
hyamero merged 9 commits into
stagingfrom
fix/review-follow-up
Nov 14, 2026
Merged

hyamero merged 9 commits into
stagingfrom
fix/review-follow-up

Conversation

@hyamero

@hyamero hyamero commented Nov 14, 2026

Copy link
Copy Markdown
Member

Summary

Follow-up to #74 and #75: the items those PRs left open, including the layout decisions that change shipped diagrams.

packages/
├── layout/  4 commits  wrap on the axis the fold shortens (height for top-down, width for left-to-right),
│                       and keep a fold only when the diagram then fits at least 15% larger;
│                       a fan-out or fan-in label sits at the end of its run nearest the far card;
│                       crowded lane routes no longer share a port run;
│                       isLarge rules out lane and sequence kinds itself
├── schema/  1 commit   new warning semantics/group-outside-phases: a group beside phases can lie across their bands
├── core/               LARGE_DIAGRAM, now the one limit layout and validation share
├── viewer/  1 commit   a presentation leaves ⌘/Ctrl/Alt key combinations to the browser
└── cli/     1 commit   on WSL, explorer.exe is tried after PowerShell (for machines that block PowerShell),
                        and a WSL kernel counts as WSL only with the Windows interop registered (not Docker Desktop)
site/        1 commit   the docs search e2e waits for the failed fetch before retrying it
 wrap gate
-  if width > 1600                      # whatever the direction
+  if flow axis > limit                 # width 1600 left to right, height 1143 top-down
+  and the folded diagram fits >= 15% larger

Not done: under Bun on macOS a 300-node, 1200-edge graph still overflows the stack. The recursion is inside the elkjs bundle.

Evidence

  • Before: a 60-node top-down chain lays out as one 360×8168 column, a 61-node one wraps.
    After: 16, 60 and 61 nodes all wrap (60: 2365×1416, 61: 2365×1552).
  • Before: fuzzed lane diagrams of 35 nodes and 210 edges show 30–37 port-run overlaps per 25.
    After: 0, asserted by the crowded fuzz test.
  • Before: in a presentation, Ctrl+End jumps to the last step.
    After: a new e2e presses Alt+ArrowRight, Ctrl+End and Meta+ArrowRight and stays on step 1.
  • Before: the docs search loads its index again after a failed fetch fails every time once the aborted fetch is delayed by 400 ms (it reopened the search while the failing request was still pending).
    After: passes with and without the delay.
bun run test         core 91, schema 114, layout 755, viewer 167, cli 76   all pass
bun run typecheck    pass
bun run build        pass
cli   smoke + e2e    pass (7)
viewer e2e           101 passed, 14 skipped (the visual spec is Linux-only)
site  test           116 passed; typecheck and build pass
site  e2e            85 passed

The WSL opener changes were tested on macOS only.

Merge Danger

Door: two-way

Each item is its own commit.

Blast Radius: Moderate

  • Shipped diagrams: 8 of 23 lay out differently. repo-architecture is now wrapped (982×1492 to 1292×1139). Seven only have labels moved: groupedPlatform, agent-tool-call, agent-run, web-app, skill/examples/web-app.architecture.json, bookshop, food-delivery. Visual baselines may need the update-visual run.
  • Release: feat(schema) makes the next release a minor version.
  • Users' diagrams: tall top-down diagrams that used to stay one column may now wrap; diagrams with phases and a populated group get a new warning.
  • WSL: once explorer.exe starts, the file counts as opened and no warning is printed, since its exit code says nothing.
  • Two layout tests' top-down "enters by the facing side" checks now apply to cards in the same column only.

@vercel

vercel Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
stackmap-site Ready Ready Preview Nov 14, 2026 1:51pm UTC

@hyamero
hyamero merged commit 9ed8a81 into staging Nov 14, 2026
8 checks passed
@hyamero
hyamero deleted the fix/review-follow-up branch November 14, 2026 14:01
@github-actions

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 0.7.0-rc.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 0.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

This branch was successfully deployed

1 active deployment
Preview — 5ae942ce Deployed Nov 14, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant