Repository navigation
feat(viewer): link the stackmap mark to the website, and export as offline HTML - #78
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
🎉 This PR is included in version 0.7.0-rc.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Merged
Contributor
|
🎉 This PR is included in version 0.7.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes three changes: the viewer header's icon becomes the stackmap mark, linked to the website; the Export menu can save the diagram again as one offline HTML file; and
deliver --openon macOS waits foropento finish.deliverwrites, named after the diagram's title. A page fromserveis saved without its live-reload block, so the file doesn't keep trying to reach the server. The website's viewers have no delivered page to save, so they don't show the item.open: it can take seconds to hand the file to a browser that is starting up. The CLI used to report success after 3s and exit. When an agent's tool then closed its shell, the leftoveropenwas killed, so nothing opened and no warning was printed. The CLI now waits up to 15s foropento exit, the same wait the Windows openers on WSL get.Evidence
platform.html. Its#rootis empty, and opened from disk it renders every card. The mark's link points to the website.serve, the exported HTML contains the diagram data and no live-reload block.undefinedwhen no diagram is embedded.bun run visual:update, 14 of 14 passed. Comparing old and new pixels, the only change is the 20×18 box where the icon sits.bun run typecheckis clean.Merge Danger
Door: two-way
Blast Radius: viewer-header-and-export
Every viewer header changes, including the website's embedded viewers. On macOS,
deliver --opencan now take up to 15s to return whenopenis slow.