Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3874.
references/workflow.mdin the rich Markdown editor and resolve them from the source document's directory.Type and Areas
Bug fix in the shared Markdown editor for Desktop and Web.
Motivation / Impact
Tiptap's URL validator cleared some relative destinations. The remaining file links relied on browser navigation and resolved against the WebView URL.
Verification
pnpm run check:webandpnpm run i18n:auditon the PR branch.pnpm --dir tests/e2e exec wdio run ./config/wdio.markdown-browser.ts --mochaOpts.grep 'opens relative Markdown links'. The test verifies both destination paths and the absence of browser navigation.Reviewer Notes
AI-assisted and tested locally. The fix reuses the existing file tab route and requires no storage or protocol migration.
Checklist