Repository navigation
Conversation
Rom1-B
marked this pull request as ready for review
November 19, 2026 10:05
Rom1-B
requested review from
a team,
Mary-Clb,
MyvTsv and
RomainLvr
and removed request for
a team
November 19, 2026 10:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the plugin compatible with the Content Security Policy sent by GLPI.
The "check all" checkbox of the three item lists used an inline onclick handler, which the CSP blocks. The header checkbox now gets its listener from a script block printed after the table, with the same behaviour (same checkAsCheckboxes call and default row selector). The script is a literal Twig block, so it receives the nonce automatically.
Converted patterns (category a, inline handler attribute):
Reviewed and left unchanged:
Declares csp_compliant => true in plugin_version_databaseinventory().
Blocked by: glpi-project/glpi#26020 (CSP) and its 11.0/12.0 backports. The minimum GLPI version must be raised to the first CSP-enabled release before merging (currently PLUGIN_DATABASEINVENTORY_MIN_GLPI = 11.0.0).
Manual test checklist: