Skip to content

feat: make plugin CSP compliant - #139

Open
Rom1-B wants to merge 1 commit into
11.0/bugfixesfrom
csp-compliance
Open

Rom1-B wants to merge 1 commit into
11.0/bugfixesfrom
csp-compliance

Conversation

@Rom1-B

@Rom1-B Rom1-B commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Make the plugin compatible with the Content Security Policy sent by GLPI.

The "check all" checkbox of the three item lists used an inline onclick handler, which the CSP blocks. The header checkbox now gets its listener from a script block printed after the table, with the same behaviour (same checkAsCheckboxes call and default row selector). The script is a literal Twig block, so it receives the nonce automatically.

Converted patterns (category a, inline handler attribute):

  • templates/computergroupstatic.html.twig: onclick on the "check all" checkbox replaced by a listener in a literal script block.
  • templates/databaseparam_computergroup.html.twig: same change.
  • templates/databaseparam_credential.html.twig: same change.

Reviewed and left unchanged:

  • inc/computergroupdynamic.class.php: 'onclick' => true passed to Html::showToolTip() is a boolean option, not an attribute.
  • inc/computergroupdynamic.class.php and inc/inventoryaction.class.php: Html::scriptBlock() already emits the nonce; the inline JavaScript uses jQuery.
  • No javascript: URLs, no on_change option, no confirmation helpers, no <script> tag printed from PHP.

Declares csp_compliant => true in plugin_version_databaseinventory().

Blocked by: glpi-project/glpi#26020 (CSP) and its 11.0/12.0 backports. The minimum GLPI version must be raised to the first CSP-enabled release before merging (currently PLUGIN_DATABASEINVENTORY_MIN_GLPI = 11.0.0).

Manual test checklist:

  • Open each list with checkboxes and at least two rows: computer groups (static), database parameters computer groups, and database parameters credentials.
  • Click the header checkbox: all row checkboxes are checked. Click it again: all are unchecked.
  • With the browser console open, no "Refused to execute inline event handler" or "Refused to execute inline script" message appears.

@Rom1-B
Rom1-B marked this pull request as ready for review November 19, 2026 10:05
@Rom1-B
Rom1-B requested review from a team, Mary-Clb, MyvTsv and RomainLvr and removed request for a team November 19, 2026 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant