Skip to content

feat: make plugin CSP compliant - #412

Open
Rom1-B wants to merge 1 commit into
11.0/bugfixesfrom
csp-compliance
Open

Rom1-B wants to merge 1 commit into
11.0/bugfixesfrom
csp-compliance

Conversation

@Rom1-B

@Rom1-B Rom1-B commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Checklist before requesting a review

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • I have updated the CHANGELOG with a short functional description of the fix or new feature.
  • This change requires a documentation update.

Description

Make the plugin compatible with the Content Security Policy sent by GLPI. Inline event handlers and javascript: links are replaced by elements with an id or a data attribute, and their behaviour is attached from <script> blocks printed with Html::scriptBlock(). PHP-printed <script> tags use Html::scriptBlock(). Behaviour is unchanged.

Converted patterns:

  • inc/common.class.php
    • getSelectAllReports(): onchange navigation on the report select (handler attribute), replaced by a jQuery change listener.
    • showCentral(): ODT export onClick link (handler attribute), replaced by a click listener calling window.open().
    • showExportForm(): "Check all" and "Uncheck all" onclick links (handler attributes), replaced by click listeners calling markCheckboxes() and unMarkCheckboxes(). The export <script> tag now uses Html::scriptBlock().
    • showGraphDatas(): javascript:showHideDiv() link, replaced by a click listener.
  • inc/dashboard.class.php
    • displayTabContentForItem(): onload on the central iframe, replaced by a jQuery load listener; the <script> tag uses Html::scriptBlock().
    • showDashBoard(): the add-report and per-widget <script> tags use Html::scriptBlock().
  • ajax/dropdownExport.php
    • SVG export button: removed the inline onClick='return false;' (the button is type=button, so it has no default action); the two <script> tags use Html::scriptBlock().
  • front/popup.php
    • "Back" link javascript:window.close(), replaced by a click listener.
  • setup.php: declares 'csp_compliant' => true.

Not changed: inc/graph.class.php prints a <script type="text/javascript+protovis"> block. Browsers do not execute it because of its MIME type, and protovis evaluates it itself.

Blocked by: glpi-project/glpi#26020 (CSP) and its 11.0 and 12.0 backports. The Html::scriptBlock() nonce and the CSP header come from the CSP-enabled GLPI release. Before merging, PLUGIN_MREPORTING_MIN_GLPI (currently 11.0.0) must be bumped to the first CSP-enabled release.

Manual test checklist (keep the browser console open; CSP violations appear as "Refused to execute inline event handler" or "Refused to execute inline script"):

  1. Central page, Dashboard tab: the iframe is resized to its content height after loading.
  2. Dashboard tab: changing "Select a report to display" opens the selected report.
  3. Dashboard tab: the add-report button opens the "Select a report to add" dialog; the close button removes a widget; the configure button opens the configuration dialog.
  4. Report graph: the "data" link shows and hides the data table and switches the arrow icon.
  5. Report list, ODT link: opens the "General Report - ODT" popup. In that popup, "Check all" and "Uncheck all" check and uncheck every report, and "Export" submits the form.
  6. "Back" in the ODT popup closes the window.
  7. SVG export button (graph export form): posts the SVG content.

@Rom1-B
Rom1-B marked this pull request as ready for review November 19, 2026 10:08
@Rom1-B
Rom1-B requested review from a team, Herafia, Lainow and jdurand-teclib and removed request for a team November 19, 2026 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant