Repository navigation
Conversation
Rom1-B
marked this pull request as ready for review
November 19, 2026 10:08
Rom1-B
requested review from
a team,
Herafia,
Lainow and
jdurand-teclib
and removed request for
a team
November 19, 2026 10:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Description
Make the plugin compatible with the Content Security Policy sent by GLPI. Inline event handlers and
javascript:links are replaced by elements with an id or a data attribute, and their behaviour is attached from<script>blocks printed withHtml::scriptBlock(). PHP-printed<script>tags useHtml::scriptBlock(). Behaviour is unchanged.Converted patterns:
inc/common.class.phpgetSelectAllReports():onchangenavigation on the report select (handler attribute), replaced by a jQuerychangelistener.showCentral(): ODT exportonClicklink (handler attribute), replaced by a click listener callingwindow.open().showExportForm(): "Check all" and "Uncheck all"onclicklinks (handler attributes), replaced by click listeners callingmarkCheckboxes()andunMarkCheckboxes(). The export<script>tag now usesHtml::scriptBlock().showGraphDatas():javascript:showHideDiv()link, replaced by a click listener.inc/dashboard.class.phpdisplayTabContentForItem():onloadon the central iframe, replaced by a jQueryloadlistener; the<script>tag usesHtml::scriptBlock().showDashBoard(): the add-report and per-widget<script>tags useHtml::scriptBlock().ajax/dropdownExport.phponClick='return false;'(the button istype=button, so it has no default action); the two<script>tags useHtml::scriptBlock().front/popup.phpjavascript:window.close(), replaced by a click listener.setup.php: declares'csp_compliant' => true.Not changed:
inc/graph.class.phpprints a<script type="text/javascript+protovis">block. Browsers do not execute it because of its MIME type, and protovis evaluates it itself.Blocked by: glpi-project/glpi#26020 (CSP) and its 11.0 and 12.0 backports. The
Html::scriptBlock()nonce and the CSP header come from the CSP-enabled GLPI release. Before merging,PLUGIN_MREPORTING_MIN_GLPI(currently 11.0.0) must be bumped to the first CSP-enabled release.Manual test checklist (keep the browser console open; CSP violations appear as "Refused to execute inline event handler" or "Refused to execute inline script"):