Skip to content

[PR #1469/aa6b596f backport][3.38] Keep the remote's upload time and yank on cached pull-through files - #1473

Merged
jobselko merged 1 commit into
3.38from
patchback/backports/3.38/aa6b596f986c978a2cd5b8b1eaaa7b1388aac7d3/pr-1469
Nov 18, 2026
Merged

jobselko merged 1 commit into
3.38from
patchback/backports/3.38/aa6b596f986c978a2cd5b8b1eaaa7b1388aac7d3/pr-1469

Conversation

@patchback

@patchback patchback Bot commented Nov 18, 2026

Copy link
Copy Markdown

This is a backport of PR #1469 as merged into main (aa6b596).

Closes #1371

On a pull-through distribution with a repository, a file already in the repository replaced the remote's entry on the simple page completely. Its upload time became the time it was cached, so uv --exclude-newer and pip --uploaded-prior-to saw old files as new. A yank on the remote, before or after the file was cached, no longer showed either, so resolvers could pick a yanked release.

When the remote lists the same file (same name and sha256), the entry now keeps the remote's upload time and is yanked when the remote yanked it; a local yank still applies. The URL and everything else still come from the repository, so clients download Pulp's copy.

Testing

  • Unit tests for merge_pull_through_releases: remote upload time kept, remote yank applied, local yank kept, a different file under the same name takes nothing from the remote, a missing remote upload time keeps the local one.
  • The pulp_python unit suite passes.

Checklist

  • Commits are cleanly separated with meaningful messages (simple features and bug fixes should be squashed to one commit)
  • A changelog entry or entries has been added for any significant changes
  • Follows the Pulp policy on AI Usage
  • (For new features) - User documentation and test coverage has been added

Summary by CodeRabbit

  • Bug Fixes
    • Pull-through package pages now show the remote upload time for matching files already cached locally.
    • Cached files now reflect the remote package’s yanked status and, when available, its yank reason. Locally yanked files remain marked yanked when the remote package is not yanked.
    • Files that do not match the remote version retain their local details.

On a pull-through distribution with a repository, a file already in the
repository replaced the remote's entry on the simple page completely. Its
upload time became the time it was cached, so tools filtering releases by
upload time (uv --exclude-newer, pip --uploaded-prior-to) saw old files as
new; and a yank on the remote, before or after caching, no longer showed.

When the remote lists the same file (same name and sha256), the entry now
keeps the remote's upload time and is yanked when the remote yanked it. The
URL and the rest still come from the repository.

Closes: #1371
(cherry picked from commit aa6b596)
@coderabbitai

coderabbitai Bot commented Nov 18, 2026

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 233ddc6c-3c49-4e34-a4d1-352ffaad4b9b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@jobselko
jobselko merged commit 0217aab into 3.38 Nov 18, 2026
15 checks passed
@jobselko
jobselko deleted the patchback/backports/3.38/aa6b596f986c978a2cd5b8b1eaaa7b1388aac7d3/pr-1469 branch November 18, 2026 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants