Repository navigation
[PR #1469/aa6b596f backport][3.38] Keep the remote's upload time and yank on cached pull-through files - #1473
Merged
jobselko merged 1 commit intoNov 18, 2026
Conversation
On a pull-through distribution with a repository, a file already in the repository replaced the remote's entry on the simple page completely. Its upload time became the time it was cached, so tools filtering releases by upload time (uv --exclude-newer, pip --uploaded-prior-to) saw old files as new; and a yank on the remote, before or after caching, no longer showed. When the remote lists the same file (same name and sha256), the entry now keeps the remote's upload time and is yanked when the remote yanked it. The URL and the rest still come from the repository. Closes: #1371 (cherry picked from commit aa6b596)
2 of 4 tasks
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
jobselko
approved these changes
Nov 18, 2026
jobselko
deleted the
patchback/backports/3.38/aa6b596f986c978a2cd5b8b1eaaa7b1388aac7d3/pr-1469
branch
November 18, 2026 11:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #1469 as merged into main (aa6b596).
Closes #1371
On a pull-through distribution with a repository, a file already in the repository replaced the remote's entry on the simple page completely. Its upload time became the time it was cached, so
uv --exclude-newerandpip --uploaded-prior-tosaw old files as new. A yank on the remote, before or after the file was cached, no longer showed either, so resolvers could pick a yanked release.When the remote lists the same file (same name and sha256), the entry now keeps the remote's upload time and is yanked when the remote yanked it; a local yank still applies. The URL and everything else still come from the repository, so clients download Pulp's copy.
Testing
merge_pull_through_releases: remote upload time kept, remote yank applied, local yank kept, a different file under the same name takes nothing from the remote, a missing remote upload time keeps the local one.Checklist
Summary by CodeRabbit