Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
normalize()adds a trailing\nto a value when a line contains a whitespace run at least as wide as the wrap width, sowrite_po()followed byread_po()changes the message:The same happens for
"abc" + " " * 80 + "\n"(gains a second newline) and for tab runs.WORD_SEP.split(line)returns an empty chunk after a trailing separator. When the whitespace chunk before it is too wide, it is put on a line of its own and the empty chunk becomes one more (empty) line, which the "remove empty trailing line" step then mistakes for the trailing line and turns intolines[-1] += '\n'. Empty chunks are now dropped before wrapping.This also stops
normalize()from emitting a stray empty""continuation line in some wrapped values, so a few.pofiles written bywrite_pochange slightly (still equivalent PO). Output for inputs without an empty chunk is unchanged; I checked this with a differential fuzz over a few hundred thousand random strings and widths.Added
test_normalize_roundtrip_with_long_whitespace(fails without the change).tests/messagesand thepofiledoctests pass.