Skip to content

Remove the unpack_sequence benchmark - #522

Open
StanFromIreland wants to merge 1 commit into
python:mainfrom
StanFromIreland:drop-bm-unpack-sequence
Open

StanFromIreland wants to merge 1 commit into
python:mainfrom
StanFromIreland:drop-bm-unpack-sequence

Conversation

@StanFromIreland

Copy link
Copy Markdown
Member

As part of #521, it fixes #450. I suggest we drop this benchmark, as discussed on Discord, since the fix proposed in #451 does not actually work.

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@savannahostrowski savannahostrowski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

unpack_sequence benchmark too fast on modern computers

3 participants