Repository navigation
feat(automations): add topic_id to send_email steps - #162
Merged
kewynakshlley merged 1 commit intoNov 19, 2026
Merged
kewynakshlley merged 1 commit into
kewynakshlley merged 1 commit into
Conversation
klotty
approved these changes
Nov 18, 2026
klotty
left a comment
There was a problem hiding this comment.
cubic analysis
No issues found across 2 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Linked issue analysis
Linked issue: MES-2966: Topics on automations: add topic_id to SDK types
| Status | Acceptance criteria | Notes |
|---|---|---|
| ✅ | Add optional topic_id to send_email step config | SendEmailStepBuilder.topicId adds topic_id to the step config, and the test verifies it is sent in the create request. |
| Typed create and update calls with topic_id compile and round-trip | The test covers a typed create request, but the diff does not show an update call or response round-trip. |
Auto-approved: Adds an optional topicId to SendEmailStepBuilder that sends topic_id in automation step config; behavior is unchanged when not set, and a focused test verifies the request body.
View guided diff | Re-trigger cubic
kewynakshlley
deleted the
feature/mes-2966-topics-on-automations-add-topic_id-to-sdk
branch
November 19, 2026 11:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
topicId(String)toSendEmailStepBuilder, sendingtopic_idin the step config. When set, contacts opted out of that topic are skipped.Mirrors resend/resend-node#1192.
Tests: new
testCreateAutomation_WithTopicId_SendsTopicIdasserts the request body includestopic_id.Summary by cubic
Adds
topicId(String)toSendEmailStepBuilderso send-email automation steps can pass atopic_id. When set, contacts who opted out of that topic are skipped.topic_idin the step config; behavior is unchanged when no topic ID is provided.topic_idis included in the request body.Written for commit c69b9c8. Summary will update on new commits.