Skip to content

feat(automations): add topic_id to send_email steps - #162

Merged
kewynakshlley merged 1 commit into
mainfrom
feature/mes-2966-topics-on-automations-add-topic_id-to-sdk
Nov 19, 2026
Merged

kewynakshlley merged 1 commit into
mainfrom
feature/mes-2966-topics-on-automations-add-topic_id-to-sdk

Conversation

@isabellaaquino

Copy link
Copy Markdown
Contributor

Adds topicId(String) to SendEmailStepBuilder, sending topic_id in the step config. When set, contacts opted out of that topic are skipped.

Mirrors resend/resend-node#1192.

Tests: new testCreateAutomation_WithTopicId_SendsTopicId asserts the request body includes topic_id.


Summary by cubic

Adds topicId(String) to SendEmailStepBuilder so send-email automation steps can pass a topic_id. When set, contacts who opted out of that topic are skipped.

  • Sends topic_id in the step config; behavior is unchanged when no topic ID is provided.
  • Adds a test asserting topic_id is included in the request body.

Written for commit c69b9c8. Summary will update on new commits.

View guided diff

@klotty klotty left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cubic analysis

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Linked issue analysis

Linked issue: MES-2966: Topics on automations: add topic_id to SDK types

Status Acceptance criteria Notes
✅ Add optional topic_id to send_email step config SendEmailStepBuilder.topicId adds topic_id to the step config, and the test verifies it is sent in the create request.
⚠️ Typed create and update calls with topic_id compile and round-trip The test covers a typed create request, but the diff does not show an update call or response round-trip.

Auto-approved: Adds an optional topicId to SendEmailStepBuilder that sends topic_id in automation step config; behavior is unchanged when not set, and a focused test verifies the request body.

View guided diff | Re-trigger cubic

@github-actions github-actions Bot added the linear-synced PR has been synced to Linear label Nov 19, 2026
@kewynakshlley
kewynakshlley merged commit 411807d into main Nov 19, 2026
6 checks passed
@kewynakshlley
kewynakshlley deleted the feature/mes-2966-topics-on-automations-add-topic_id-to-sdk branch November 19, 2026 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

linear-synced PR has been synced to Linear

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants