Repository navigation
[SEL-343] python-pytest: bundle transport v0.3.0 with HTTP manifest upload - #3
Merged
Merged
Conversation
Pins transport v0.3.0 (a447773), which uploads the test manifest over HTTP when the server offers it (SEL-161) and falls back to the WebSocket otherwise. Conformance now passes --require-features manifest_http, so a transport that drops the feature fails instead of reporting n/a. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0186m4Fs9sjoDBCLEPoYs7qD
Contributor
Author
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the transport to
v0.3.0(a447773). It uploads the test manifest over HTTP when the server offers it (SEL-161) and falls back to the WebSocket otherwise; the client sends the sametest_manifestline as before. Conformance now passes--require-features manifest_http, so a transport that drops the feature fails the check instead of reporting n/a.Changes
.github/workflows/ci.yml(TRANSPORT_RELEASE,TRANSPORT_REV, jobstransportandwheel),README.md(tag and rev). 6 lines. This client has no hash table; the wheel is built from source at the rev.--require-features manifest_httpin thetransport-conformancestep in.github/workflows/ci.yml(and the README command that mirrors it).ci.ymlline itself. A harness step checks the line is present; CI exercises it.Proof (head
6ebb853, all in Docker against a local Selective server)transport-Linux-x86_64(sha2560cb66dab…) +--require-features manifest_httpmanifest_http_upload,_fallback,_stopok; the other 26 scenarios unchanged frommain8f92a94)mainaca0ef7)required transport feature manifest_http never exercised×3; the HTTP-path checks go red against the upload serverPins are the
v0.3.0tag and its commita447773(gh api repos/selectiveci/transport/git/ref/tags/v0.3.0); CI builds the transport from source at that rev, so there are no digests to pin.Not established: the new flag line in the CI workflow was only checked for presence locally; this PR's CI is its first execution; no pin-integrity row, since this client has no hash table; the runs used the pre-merge server heads above, not production.
🤖 Generated with Claude Code
https://claude.ai/code/session_0186m4Fs9sjoDBCLEPoYs7qD